#126 - fix
This commit is contained in:
parent
1f01d334ca
commit
0b154af1d5
@ -19,7 +19,7 @@ class CreateAction
|
||||
protected VacationRequestStateManager $stateManager,
|
||||
protected VacationRequestValidator $vacationRequestValidator,
|
||||
protected VacationTypeConfigRetriever $configRetriever,
|
||||
protected WorkDaysCalculator $vacationDaysCalculator,
|
||||
protected WorkDaysCalculator $workDaysCalculator,
|
||||
protected WaitForTechApprovalAction $waitForTechApprovalAction,
|
||||
protected WaitForAdminApprovalAction $waitForAdminApprovalAction,
|
||||
protected ApproveAction $approveAction,
|
||||
@ -52,7 +52,7 @@ class CreateAction
|
||||
|
||||
$vacationRequest->save();
|
||||
|
||||
$days = $this->vacationDaysCalculator->calculateDays($vacationRequest->from, $vacationRequest->to);
|
||||
$days = $this->workDaysCalculator->calculateDays($vacationRequest->from, $vacationRequest->to);
|
||||
|
||||
foreach ($days as $day) {
|
||||
$vacationRequest->vacations()->create([
|
||||
|
@ -18,7 +18,7 @@ class DoesNotExceedLimitRule implements VacationRequestRule
|
||||
{
|
||||
public function __construct(
|
||||
protected VacationTypeConfigRetriever $configRetriever,
|
||||
protected WorkDaysCalculator $vacationDaysCalculator,
|
||||
protected WorkDaysCalculator $workDaysCalculator,
|
||||
) {}
|
||||
|
||||
public function check(VacationRequest $vacationRequest): bool
|
||||
@ -29,7 +29,7 @@ class DoesNotExceedLimitRule implements VacationRequestRule
|
||||
|
||||
$limit = $this->getUserVacationLimit($vacationRequest->user, $vacationRequest->yearPeriod);
|
||||
$vacationDays = $this->getVacationDaysWithLimit($vacationRequest->user, $vacationRequest->yearPeriod);
|
||||
$estimatedDays = $this->vacationDaysCalculator
|
||||
$estimatedDays = $this->workDaysCalculator
|
||||
->calculateDays($vacationRequest->from, $vacationRequest->to)
|
||||
->count();
|
||||
|
||||
|
@ -10,12 +10,12 @@ use Toby\Eloquent\Models\VacationRequest;
|
||||
class MinimumOneVacationDayRule implements VacationRequestRule
|
||||
{
|
||||
public function __construct(
|
||||
protected WorkDaysCalculator $vacationDaysCalculator,
|
||||
protected WorkDaysCalculator $workDaysCalculator,
|
||||
) {}
|
||||
|
||||
public function check(VacationRequest $vacationRequest): bool
|
||||
{
|
||||
return $this->vacationDaysCalculator
|
||||
return $this->workDaysCalculator
|
||||
->calculateDays($vacationRequest->from, $vacationRequest->to)
|
||||
->isNotEmpty();
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user