From 131924da766e4d4d4d5b8eb9dd75c5630b19ecbc Mon Sep 17 00:00:00 2001 From: EwelinaLasowy Date: Mon, 14 Feb 2022 15:30:09 +0100 Subject: [PATCH] #22 - fix --- app/Domain/Validation/Rules/DoesNotExceedLimitRule.php | 4 ++-- tests/Feature/VacationRequestTest.php | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/Domain/Validation/Rules/DoesNotExceedLimitRule.php b/app/Domain/Validation/Rules/DoesNotExceedLimitRule.php index 26705a8..c8c9ab5 100644 --- a/app/Domain/Validation/Rules/DoesNotExceedLimitRule.php +++ b/app/Domain/Validation/Rules/DoesNotExceedLimitRule.php @@ -52,8 +52,8 @@ class DoesNotExceedLimitRule implements VacationRequestRule ->whereRelation( "vacationRequest", fn(Builder $query) => $query - ->whereIn("type", $this->getLimitableVacationTypes()) - ->noStates(VacationRequestState::failedStates()), + ->whereIn("type", $this->getLimitableVacationTypes()) + ->noStates(VacationRequestState::failedStates()), ) ->count(); } diff --git a/tests/Feature/VacationRequestTest.php b/tests/Feature/VacationRequestTest.php index 2aab28e..5b40026 100644 --- a/tests/Feature/VacationRequestTest.php +++ b/tests/Feature/VacationRequestTest.php @@ -56,14 +56,13 @@ class VacationRequestTest extends FeatureTestCase $currentYearPeriod = YearPeriod::current(); - VacationLimit::factory([ + VacationLimit::factory([ "days" => 20, ]) ->for($user) ->for($currentYearPeriod) ->create(); - $this->actingAs($user) ->post("/vacation-requests", [ "type" => VacationType::VACATION->value, @@ -185,7 +184,6 @@ class VacationRequestTest extends FeatureTestCase ]); } - public function testUserCannotCreateVacationRequestAtWeekend(): void { $user = User::factory()->createQuietly();