From 3bea1f41b284d787830d8b230a249f766de1c2d1 Mon Sep 17 00:00:00 2001 From: Kamil Niemczycki Date: Mon, 11 Jul 2022 13:11:15 +0200 Subject: [PATCH] - duplication of code removed --- app/Domain/UserVacationStatsRetriever.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/Domain/UserVacationStatsRetriever.php b/app/Domain/UserVacationStatsRetriever.php index 37dcae4..a59e9a1 100644 --- a/app/Domain/UserVacationStatsRetriever.php +++ b/app/Domain/UserVacationStatsRetriever.php @@ -105,11 +105,10 @@ class UserVacationStatsRetriever public function hasVacationDaysLimit(User $user, YearPeriod $yearPeriod): bool { - $limit = $user->vacationLimits() + return $user->vacationLimits() ->whereBelongsTo($yearPeriod) - ->first()?->days; - - return $limit !== null; + ->first() + ?->hasVacation() ?? false; } protected function getLimitableVacationTypes(): Collection