#23 - wip

app/Http/Controllers/VacationLimitController.php

@@ -5,7 +5,6 @@ declare(strict_types=1);
 namespace Toby\Http\Controllers;
 
 use Illuminate\Http\RedirectResponse;
-use Illuminate\Support\Arr;
 use Inertia\Response;
 use Toby\Http\Requests\VacationLimitRequest;
 use Toby\Http\Resources\VacationLimitResource;
@@ -22,14 +21,14 @@ class VacationLimitController extends Controller
 
     public function update(VacationLimitRequest $request): RedirectResponse
     {
-       foreach ($request->data() as $data) {
-           $limit = VacationLimit::query()->find($data["id"]);
+        $data = $request->data();
 
-           $limit->update(Arr::only($data, ["has_vacation", "days"]));
-       }
+        foreach ($request->vacationLimits() as $limit) {
+            $limit->update($data[$limit->id]);
+        }
 
-       return redirect()
-           ->back()
-           ->with("success", __("Vacation limits have been updated"));
+        return redirect()
+            ->back()
+            ->with("success", __("Vacation limits have been updated"));
     }
 }

app/Http/Requests/VacationLimitRequest.php

@@ -6,6 +6,7 @@ namespace Toby\Http\Requests;
 
 use Illuminate\Foundation\Http\FormRequest;
 use Illuminate\Support\Collection;
+use Toby\Models\VacationLimit;
 
 class VacationLimitRequest extends FormRequest
 {
@@ -19,12 +20,19 @@ class VacationLimitRequest extends FormRequest
         ];
     }
 
+
+    public function vacationLimits(): Collection
+    {
+        return VacationLimit::query()->find($this->collect("items")->pluck("id"));
+    }
+
     public function data(): Collection
     {
-        return $this->collect("items")->map(fn(array $item): array => [
-            "id" => $item["id"],
-            "has_vacation" => $item["hasVacation"],
-            "days" => $item["days"],
+        return $this->collect("items")->mapWithKeys(fn(array $item): array => [
+            $item["id"] => [
+                "has_vacation" => $item["hasVacation"],
+                "days" => $item["days"],
+            ]
         ]);
     }
 }