#116 - cr fix

app/Domain/Notifications/Channels.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Toby\Domain\Notifications;
+
+class Channels
+{
+    public const MAIL = "mail";
+    public const SLACK = "slack";
+}

app/Domain/Notifications/KeyHasBeenGivenNotification.php

@@ -19,10 +19,10 @@ class KeyHasBeenGivenNotification extends Notification
 
     public function via(): array
     {
-        return ["slack"];
+        return [Channels::SLACK];
     }
 
-    public function toSlack($notifiable): string
+    public function toSlack(Notifiable $notifiable): string
     {
         return __(":sender gives key no :key to :recipient", [
             "sender" => $this->getName($this->sender),

app/Domain/Notifications/KeyHasBeenTakenNotification.php

@@ -19,10 +19,10 @@ class KeyHasBeenTakenNotification extends Notification
 
     public function via(): array
     {
-        return ["slack"];
+        return [Channels::SLACK];
     }
 
-    public function toSlack($notifiable): string
+    public function toSlack(Notifiable $notifiable): string
     {
         return __(":recipient takes key no :key from :sender", [
             "recipient" => $this->getName($this->recipient),

app/Domain/Notifications/Notifiable.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Toby\Domain\Notifications;
+
+interface Notifiable
+{
+    public function notify($instance);
+}

app/Domain/Notifications/VacationRequestCreatedNotification.php

@@ -20,7 +20,7 @@ class VacationRequestCreatedNotification extends Notification
 
     public function via(): array
     {
-        return ["mail", "slack"];
+        return [Channels::MAIL, Channels::SLACK];
     }
 
     public function toSlack(): string

app/Domain/Notifications/VacationRequestStatusChangedNotification.php

@@ -22,7 +22,7 @@ class VacationRequestStatusChangedNotification extends Notification
 
     public function via(): array
     {
-        return ["mail", "slack"];
+        return [Channels::MAIL, Channels::SLACK];
     }
 
     public function toSlack(): string

app/Domain/Notifications/VacationRequestWaitsForApprovalNotification.php

@@ -23,7 +23,7 @@ class VacationRequestWaitsForApprovalNotification extends Notification
 
     public function via(): array
     {
-        return ["mail", "slack"];
+        return [Channels::MAIL, Channels::SLACK];
     }
 
     public function toSlack(): string