kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Ewelina Lasowy <56546832+EwelinaLasowy@users.noreply.github.com>
This commit is contained in:
Adrian Hopek 2022-04-26 14:24:29 +02:00 committed by GitHub
parent 8726b81a66
commit 83e003ddbb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Infrastructure/Slack/Controller.php
View File

@ -50,7 +50,7 @@ class Controller extends SlackController
); );
return Response::create($this->request) return Response::create($this->request)
->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawna:") ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
->withAttachments($errors->all()); ->withAttachments($errors->all());
} }
} }

4
tests/Unit/SendDailySummaryToSlackTest.php
View File

@ -38,7 +38,7 @@ class SendDailySummaryToSlackTest extends TestCase
Http::assertSentCount(1); Http::assertSentCount(1);
} }
public function testCommandDoesntSendIfWeekend(): void public function testCommandDoesntSendMessageIfWeekend(): void
{ {
$weekend = Carbon::create(2022, 4, 23); $weekend = Carbon::create(2022, 4, 23);
$this->assertTrue($weekend->isWeekend()); $this->assertTrue($weekend->isWeekend());
@ -51,7 +51,7 @@ class SendDailySummaryToSlackTest extends TestCase
Http::assertNothingSent(); Http::assertNothingSent();
} }
public function testCommandDoesntSendIfHoliday(): void public function testCommandDoesntSendMessageIfHoliday(): void
{ {
$holiday = Holiday::factory(["date" => Carbon::create(2022, 4, 22)])->create(); $holiday = Holiday::factory(["date" => Carbon::create(2022, 4, 22)])->create();