Apply suggestions from code review
Co-authored-by: Krzysztof Rewak <krzysztof.rewak@gmail.com> Co-authored-by: Ewelina Lasowy <56546832+EwelinaLasowy@users.noreply.github.com>
This commit is contained in:
parent
4059b101f5
commit
ab92f285ba
@ -54,14 +54,14 @@ class HandleInertiaRequests extends Middleware
|
||||
|
||||
protected function getYearsData(Request $request): Closure
|
||||
{
|
||||
return fn() => $request->user() ? $this->yearPeriodRetriever->links() : [];
|
||||
return fn(): array => $request->user() ? $this->yearPeriodRetriever->links() : [];
|
||||
}
|
||||
|
||||
protected function getVacationRequestsCount(Request $request): Closure
|
||||
{
|
||||
$user = $request->user();
|
||||
|
||||
return fn() => $user && $user->can("listAll", VacationRequest::class)
|
||||
return fn(): ?int => $user && $user->can("listAll", VacationRequest::class)
|
||||
? VacationRequest::query()
|
||||
->whereBelongsTo($this->yearPeriodRetriever->selected())
|
||||
->states(
|
||||
|
@ -53,7 +53,7 @@ export default {
|
||||
replace: props.replace,
|
||||
preserveScroll: props.preserveScroll,
|
||||
preserveState: props.preserveState ?? (method !== 'get'),
|
||||
onBefore: () => ! processing.value,
|
||||
onBefore: () => !processing.value,
|
||||
onStart: () => processing.value = true,
|
||||
onFinish: () => processing.value = false,
|
||||
})
|
||||
|
Loading…
x
Reference in New Issue
Block a user