#36 - validate vacation request (#47)

* #36 - wip

* #36 - wip

* #36 - wip

* #36 - added some translations

* #36 - fix

* #36 - fix

Co-authored-by: EwelinaLasowy <ewelina.lasowy@blumilk.pl>

app/Domain/VacationDaysCalculator.php

@@ -0,0 +1,42 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Toby\Domain;
+
+use Carbon\CarbonInterface;
+use Carbon\CarbonPeriod;
+use Illuminate\Support\Collection;
+use Toby\Eloquent\Models\YearPeriod;
+
+class VacationDaysCalculator
+{
+    public function calculateDays(YearPeriod $yearPeriod, CarbonInterface $from, CarbonInterface $to): Collection
+    {
+        $period = CarbonPeriod::create($from, $to);
+        $holidays = $yearPeriod->holidays()->pluck("date");
+
+        $validDays = collect();
+
+        foreach ($period as $day) {
+            if ($this->passes($day, $holidays)) {
+                $validDays->add($day);
+            }
+        }
+
+        return $validDays;
+    }
+
+    protected function passes(CarbonInterface $day, Collection $holidays): bool
+    {
+        if ($day->isWeekend()) {
+            return false;
+        }
+
+        if ($holidays->contains($day)) {
+            return false;
+        }
+
+        return true;
+    }
+}

app/Domain/Validation/Rules/ApprovedVacationDaysInSameRange.php

@@ -1,16 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Toby\Domain\Validation\Rules;
-
-use Closure;
-use Toby\Eloquent\Models\VacationRequest;
-
-class ApprovedVacationDaysInSameRange implements VacationRequestRule
-{
-    public function check(VacationRequest $vacationRequest, Closure $next)
-    {
-        return $next($vacationRequest);
-    }
-}

app/Domain/Validation/Rules/DoesNotExceedLimitRule.php

@@ -4,13 +4,23 @@ declare(strict_types=1);
 
 namespace Toby\Domain\Validation\Rules;
 
-use Closure;
+use Toby\Domain\VacationTypeConfigRetriever;
 use Toby\Eloquent\Models\VacationRequest;
 
 class DoesNotExceedLimitRule implements VacationRequestRule
 {
-    public function check(VacationRequest $vacationRequest, Closure $next)
+    public function __construct(
+        protected VacationTypeConfigRetriever $configRetriever,
+    ) {
+    }
+
+    public function check(VacationRequest $vacationRequest): bool
     {
-        return $next($vacationRequest);
+        return true;
+    }
+
+    public function errorMessage(): string
+    {
+        return __("You have exceeded your vacation limit.");
     }
 }

app/Domain/Validation/Rules/MinimumOneVacationDayRule.php

@@ -4,13 +4,25 @@ declare(strict_types=1);
 
 namespace Toby\Domain\Validation\Rules;
 
-use Closure;
+use Toby\Domain\VacationDaysCalculator;
 use Toby\Eloquent\Models\VacationRequest;
 
 class MinimumOneVacationDayRule implements VacationRequestRule
 {
-    public function check(VacationRequest $vacationRequest, Closure $next)
+    public function __construct(
+        protected VacationDaysCalculator $vacationDaysCalculator,
+    ) {
+    }
+
+    public function check(VacationRequest $vacationRequest): bool
     {
-        return $next($vacationRequest);
+        return $this->vacationDaysCalculator
+            ->calculateDays($vacationRequest->yearPeriod, $vacationRequest->from, $vacationRequest->to)
+            ->isNotEmpty();
+    }
+
+    public function errorMessage(): string
+    {
+        return __("Vacation needs minimum one day.");
     }
 }

app/Domain/Validation/Rules/NoApprovedVacationRequestsInRange.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Toby\Domain\Validation\Rules;
+
+use Toby\Domain\Enums\VacationRequestState;
+use Toby\Eloquent\Models\VacationRequest;
+
+class NoApprovedVacationRequestsInRange implements VacationRequestRule
+{
+    public function check(VacationRequest $vacationRequest): bool
+    {
+        return !$vacationRequest
+            ->user
+            ->vacationRequests()
+            ->overlapsWith($vacationRequest)
+            ->states(VacationRequestState::successStates())
+            ->exists();
+    }
+
+    public function errorMessage(): string
+    {
+        return __("You have approved vacation request in this range.");
+    }
+}

app/Domain/Validation/Rules/NoPendingVacationRequestInRange.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Toby\Domain\Validation\Rules;
+
+use Toby\Domain\Enums\VacationRequestState;
+use Toby\Eloquent\Models\VacationRequest;
+
+class NoPendingVacationRequestInRange implements VacationRequestRule
+{
+    public function check(VacationRequest $vacationRequest): bool
+    {
+        return !$vacationRequest
+            ->user
+            ->vacationRequests()
+            ->overlapsWith($vacationRequest)
+            ->states(VacationRequestState::pendingStates())
+            ->exists();
+    }
+
+    public function errorMessage(): string
+    {
+        return __("You have pending vacation request in this range.");
+    }
+}

app/Domain/Validation/Rules/PendingVacationRequestInSameRange.php

@@ -1,16 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Toby\Domain\Validation\Rules;
-
-use Closure;
-use Toby\Eloquent\Models\VacationRequest;
-
-class PendingVacationRequestInSameRange implements VacationRequestRule
-{
-    public function check(VacationRequest $vacationRequest, Closure $next)
-    {
-        return $next($vacationRequest);
-    }
-}

app/Domain/Validation/Rules/UsedVacationDaysInSameRange.php

@@ -1,16 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Toby\Domain\Validation\Rules;
-
-use Closure;
-use Toby\Eloquent\Models\VacationRequest;
-
-class UsedVacationDaysInSameRange
-{
-    public function check(VacationRequest $vacationRequest, Closure $next)
-    {
-        return $next($vacationRequest);
-    }
-}

app/Domain/Validation/Rules/VacationRangeIsInTheSameYearRule.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Toby\Domain\Validation\Rules;
+
+use Toby\Eloquent\Models\VacationRequest;
+
+class VacationRangeIsInTheSameYearRule implements VacationRequestRule
+{
+    public function check(VacationRequest $vacationRequest): bool
+    {
+        return $vacationRequest->from->isSameYear($vacationRequest->to);
+    }
+
+    public function errorMessage(): string
+    {
+        return __("The vacation request cannot be created at the turn of the year.");
+    }
+}

app/Domain/Validation/Rules/VacationRequestRule.php

@@ -4,10 +4,10 @@ declare(strict_types=1);
 
 namespace Toby\Domain\Validation\Rules;
 
-use Closure;
 use Toby\Eloquent\Models\VacationRequest;
 
 interface VacationRequestRule
 {
-    public function check(VacationRequest $vacationRequest, Closure $next);
+    public function check(VacationRequest $vacationRequest): bool;
+    public function errorMessage(): string;
 }

app/Domain/Validation/VacationRequestValidator.php

@@ -4,32 +4,49 @@ declare(strict_types=1);
 
 namespace Toby\Domain\Validation;
 
-use Illuminate\Pipeline\Pipeline;
-use Toby\Domain\Validation\Rules\ApprovedVacationDaysInSameRange;
+use Illuminate\Contracts\Container\Container;
+use Illuminate\Validation\ValidationException;
 use Toby\Domain\Validation\Rules\DoesNotExceedLimitRule;
 use Toby\Domain\Validation\Rules\MinimumOneVacationDayRule;
-use Toby\Domain\Validation\Rules\PendingVacationRequestInSameRange;
+use Toby\Domain\Validation\Rules\NoApprovedVacationRequestsInRange;
+use Toby\Domain\Validation\Rules\NoPendingVacationRequestInRange;
+use Toby\Domain\Validation\Rules\VacationRangeIsInTheSameYearRule;
+use Toby\Domain\Validation\Rules\VacationRequestRule;
 use Toby\Eloquent\Models\VacationRequest;
 
 class VacationRequestValidator
 {
     protected array $rules = [
+        VacationRangeIsInTheSameYearRule::class,
         MinimumOneVacationDayRule::class,
         DoesNotExceedLimitRule::class,
-        PendingVacationRequestInSameRange::class,
-        ApprovedVacationDaysInSameRange::class,
+        NoPendingVacationRequestInRange::class,
+        NoApprovedVacationRequestsInRange::class,
     ];
 
     public function __construct(
-        protected Pipeline $pipeline,
+        protected Container $container,
     ) {
     }
 
+    /**
+     * @throws ValidationException
+     */
     public function validate(VacationRequest $vacationRequest): void
     {
-        $this->pipeline
-            ->send($vacationRequest)
-            ->through($this->rules)
-            ->via("check");
+        foreach ($this->rules as $rule) {
+            $rule = $this->makeRule($rule);
+
+            if (!$rule->check($vacationRequest)) {
+                throw ValidationException::withMessages([
+                    "vacationRequest" => $rule->errorMessage(),
+                ]);
+            }
+        }
+    }
+
+    protected function makeRule(string $class): VacationRequestRule
+    {
+        return $this->container->make($class);
     }
 }