kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#120 - wip

Browse Source
This commit is contained in:
Adrian Hopek
2022-04-20 12:20:56 +02:00
parent 05002dbc33
commit db70c3885f
6 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/Domain/Actions/VacationRequest/CreateAction.php
View File

@@ -32,7 +32,10 @@ class CreateAction
{
$vacationRequest = $this->createVacationRequest($data, $creator);
$this->handleCreatedVacationRequest($vacationRequest);
$this->notify($vacationRequest);
if ($this->configRetriever->isVacation($vacationRequest->type)) {
$this->notify($vacationRequest);
}
return $vacationRequest;
}

6
app/Domain/Actions/VacationRequest/WaitForAdminApprovalAction.php
View File

@@ -23,10 +23,12 @@ class WaitForAdminApprovalAction
{
$this->stateManager->waitForAdministrative($vacationRequest);
$this->waitForAdminApprovers($vacationRequest);
if ($this->configRetriever->isVacation($vacationRequest->type)) {
$this->notifyAdminApprovers($vacationRequest);
}
}
protected function waitForAdminApprovers(VacationRequest $vacationRequest): void
protected function notifyAdminApprovers(VacationRequest $vacationRequest): void
{
$users = User::query()
->whereIn("role", [Role::AdministrativeApprover, Role::Administrator])

4
app/Domain/Actions/VacationRequest/WaitForTechApprovalAction.php
View File

@@ -23,7 +23,9 @@ class WaitForTechApprovalAction
{
$this->stateManager->waitForTechnical($vacationRequest);
$this->notifyTechApprovers($vacationRequest);
if ($this->configRetriever->isVacation($vacationRequest->type)) {
$this->notifyTechApprovers($vacationRequest);
}
}
protected function notifyTechApprovers(VacationRequest $vacationRequest): void

1
app/Domain/UserVacationStatsRetriever.php
View File

@@ -116,5 +116,4 @@ class UserVacationStatsRetriever
return $types->filter(fn(VacationType $type) => !$this->configRetriever->hasLimit($type));
}
}