#173 - button behaviour in creating request (#174)

#173 - improved button behaviour

app/Eloquent/Models/Resume.php

@@ -31,6 +31,7 @@ class Resume extends Model
         "technologies" => AsCollection::class,
         "projects" => AsCollection::class,
     ];
+    protected $perPage = 50;
 
     public function user(): BelongsTo
     {

app/Eloquent/Models/User.php

@@ -46,6 +46,7 @@ class User extends Authenticatable implements NotifiableInterface
     protected $with = [
         "profile",
     ];
+    protected $perPage = 50;
 
     public function profile(): HasOne
     {

app/Eloquent/Models/VacationRequest.php

@@ -49,6 +49,7 @@ class VacationRequest extends Model
         "to" => "date",
         "event_ids" => AsCollection::class,
     ];
+    protected $perPage = 50;
 
     public function user(): BelongsTo
     {

app/Infrastructure/Http/Controllers/DashboardController.php

@@ -12,11 +12,8 @@ use Toby\Domain\UserVacationStatsRetriever;
 use Toby\Domain\VacationRequestStatesRetriever;
 use Toby\Domain\VacationTypeConfigRetriever;
 use Toby\Eloquent\Helpers\YearPeriodRetriever;
-use Toby\Eloquent\Models\Holiday;
-use Toby\Eloquent\Models\Vacation;
 use Toby\Eloquent\Models\VacationRequest;
 use Toby\Infrastructure\Http\Resources\HolidayResource;
-use Toby\Infrastructure\Http\Resources\SimpleVacationRequestResource;
 use Toby\Infrastructure\Http\Resources\VacationRequestResource;
 use Toby\Infrastructure\Http\Resources\VacationResource;
 
@@ -57,22 +54,6 @@ class DashboardController extends Controller
             ->limit(3)
             ->get();
 
-        $allHolidays = $yearPeriod->holidays;
-
-        $approvedVacations = $request->user()
-            ->vacations()
-            ->with("vacationRequest.vacations")
-            ->whereBelongsTo($yearPeriod)
-            ->approved()
-            ->get();
-
-        $pendingVacations = $request->user()
-            ->vacations()
-            ->with("vacationRequest.vacations")
-            ->whereBelongsTo($yearPeriod)
-            ->pending()
-            ->get();
-
         $limit = $vacationStatsRetriever->getVacationDaysLimit($user, $yearPeriod);
         $used = $vacationStatsRetriever->getUsedVacationDays($user, $yearPeriod);
         $pending = $vacationStatsRetriever->getPendingVacationDays($user, $yearPeriod);
@@ -85,19 +66,6 @@ class DashboardController extends Controller
             "remoteDays" => VacationResource::collection($remoteDays),
             "vacationRequests" => VacationRequestResource::collection($vacationRequests),
             "holidays" => HolidayResource::collection($holidays),
-            "allHolidays" => $allHolidays->mapWithKeys(
-                fn(Holiday $holiday): array => [$holiday->date->toDateString() => $holiday->name],
-            ),
-            "approvedVacations" => $approvedVacations->mapWithKeys(
-                fn(Vacation $vacation): array => [
-                    $vacation->date->toDateString() => new SimpleVacationRequestResource($vacation->vacationRequest),
-                ],
-            ),
-            "pendingVacations" => $pendingVacations->mapWithKeys(
-                fn(Vacation $vacation): array => [
-                    $vacation->date->toDateString() => new SimpleVacationRequestResource($vacation->vacationRequest),
-                ],
-            ),
             "stats" => [
                 "limit" => $limit,
                 "remaining" => $remaining,

resources/js/Pages/Dashboard.vue

@@ -3,11 +3,6 @@
   <div class="grid grid-cols-1 gap-4 items-start xl:grid-cols-3 xl:gap-8">
     <div class="grid grid-cols-1 gap-4 xl:col-span-2">
       <Welcome :user="auth.user" />
-      <VacationCalendar
-        :holidays="allHolidays"
-        :approved-vacations="approvedVacations"
-        :pending-vacations="pendingVacations"
-      />
       <VacationStats :stats="stats" />
     </div>
     <div class="grid grid-cols-1 gap-4">
@@ -43,7 +38,6 @@ import HomeOfficeList from '@/Shared/Widgets/HomeOfficeList'
 import UpcomingHolidays from '@/Shared/Widgets/UpcomingHolidays'
 import UserVacationRequests from '@/Shared/Widgets/UserVacationRequests'
 import PendingVacationRequests from '@/Shared/Widgets/PendingVacationRequests'
-import VacationCalendar from '@/Shared/Widgets/VacationCalendar'
 
 defineProps({
   auth: Object,
@@ -54,8 +48,5 @@ defineProps({
   can: Object,
   stats: Object,
   years: Object,
-  allHolidays: Object,
-  approvedVacations: Object,
-  pendingVacations: Object,
 })
 </script>

resources/js/Pages/VacationRequest/Create.vue

@@ -297,8 +297,8 @@
               <button
                 type="submit"
                 class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
-                :class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
+                :class="[form.processing || !isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
-                :disabled="form.processing || !form.isDirty"
+                :disabled="form.processing || !isDirty"
               >
                 Zapisz
               </button>
@@ -359,6 +359,13 @@ const form = useForm({
   flowSkipped: false,
 })
 
+let isDirty = ref(false)
+
+watch(form, formData => {
+  const { from, to } = formData.data()
+  isDirty.value = formData.isDirty || from !== null || to !== null
+}, { immediate: true, deep: true })
+
 refreshEstimatedDays(form.from, form.to)
 
 const estimatedDays = ref([])

resources/js/Shared/Widgets/Calendar/DayComponent.vue

@@ -1,104 +0,0 @@
-<template>
-  <div
-    :class="[ (day.isVacation || day.isPendingVacation) && `border-b-2 border-dashed ${getVacationBorder(day)}` ]"
-  >
-    <Popper
-      v-if="day.isHoliday"
-      as="div"
-      open-delay="200"
-      hover
-      offset-distance="0"
-      @mouseover.passive="onMouseover"
-      @mouseleave="onMouseleave"
-    >
-      <time
-        :datetime="day.date"
-        :class="[ day.isToday && 'flex h-6 w-6 items-center justify-center rounded-full bg-blumilk-500 font-semibold text-white', 'text-red-600' ]"
-      >
-        {{ day.dayNumber }}
-      </time>
-      <template #content>
-        <div class="py-2 px-6 text-sm font-semibold text-left text-gray-700 bg-white rounded-lg border border-gray-400">
-          {{ getHolidayDescription(day) }}
-        </div>
-      </template>
-    </Popper>
-    <Popper
-      v-else-if="day.isPendingVacation"
-      as="div"
-      open-delay="200"
-      hover
-      offset-distance="0"
-      @mouseover.passive="onMouseover"
-      @mouseleave="onMouseleave"
-    >
-      <time
-        :datetime="day.date"
-        :class="[ day.isToday && 'flex h-6 w-6 items-center justify-center rounded-full bg-blumilk-500 font-semibold text-white' ]"
-      >
-        {{ day.dayNumber }}
-      </time>
-      <template #content>
-        <VacationPopup :vacation="getVacationInfo(day)" />
-      </template>
-    </Popper>
-    <div
-      v-else-if="day.isWeekend"
-    >
-      <time
-        :datetime="day.date"
-        :class="{ 'flex h-6 w-6 items-center justify-center rounded-full bg-blumilk-500 font-semibold text-white': day.isToday }"
-      >
-        {{ day.dayNumber }}
-      </time>
-    </div>
-    <InertiaLink
-      v-else
-      href="/vacation/requests/create"
-      :data="{ 'from_date': day.date }"
-      @mouseover.passive="onMouseover"
-      @mouseleave="onMouseleave"
-    >
-      <time
-        :datetime="day.date"
-        :class="{ 'flex h-6 w-6 items-center justify-center rounded-full bg-blumilk-500 font-semibold text-white': day.isToday }"
-      >
-        {{ day.dayNumber }}
-      </time>
-    </InertiaLink>
-  </div>
-</template>
-
-<script setup>
-import Popper from 'vue3-popper'
-import { defineProps, ref } from 'vue'
-import VacationPopup from '@/Shared/VacationPopup'
-
-defineProps({
-  day: {
-    type: Object,
-    required: true,
-  },
-  getHolidayDescription: {
-    type: Function,
-  },
-  getVacationBorder: {
-    type: Function,
-  },
-  getVacationInfo: {
-    type: Function,
-  },
-})
-
-const isActive = ref(false)
-
-function onMouseover() {
-  if (!isActive.value)
-    isActive.value = true
-}
-
-function onMouseleave() {
-  if (isActive.value)
-    isActive.value = false
-}
-</script>

resources/js/Shared/Widgets/Calendar/ViewModeOptions.js

@@ -1,12 +0,0 @@
-function isViewModeKey(key) {
-  return this.key === key.value
-}
-
-export const viewModes = [
-  { key: 'week', name: 'Widok tygodnia', shortcut: 'Tydzień', is: isViewModeKey },
-  { key: 'month', name: 'Widok miesiąca', shortcut: 'Miesiąc', is: isViewModeKey },
-]
-
-export function find(modeKey) {
-  return viewModes.find(mode => mode.key === modeKey)
-}

resources/js/Shared/Widgets/VacationCalendar.vue

@@ -1,394 +0,0 @@
-<template>
-  <section class="bg-white shadow-md">
-    <div class="grid grid-cols-3 grid-rows-1 items-center justify-center p-4 sm:px-6">
-      <h2 class="text-lg font-medium leading-6 text-gray-900">
-        {{ calendarState.monthName }} {{ !calendarState.isActualYear ? calendar.currents.year : undefined }}
-      </h2>
-      <div class="flex justify-center">
-        <div class="flex items-center rounded-md shadow-sm md:items-stretch">
-          <button
-            v-if="calendarState.isPrevious"
-            type="button"
-            class="flex items-center justify-center rounded-l-md border border-r-0 border-gray-300 bg-white py-2 pl-3 pr-4 text-gray-400 hover:text-gray-500 focus:relative md:w-9 md:px-2 md:hover:bg-gray-50"
-            @click="toLast"
-          >
-            <span class="sr-only">Poprzedni {{ calendarState.viewMode.details.shortcut }}</span>
-            <ChevronLeftIcon
-              class="h-5 w-5"
-              aria-hidden="true"
-            />
-          </button>
-          <button
-            type="button"
-            class="hidden border-t border-b border-gray-300 bg-white px-3.5 text-sm font-medium text-gray-700 hover:bg-gray-50 hover:text-gray-900 focus:relative md:block"
-            :class="{ 'rounded-l-md border border-r-0': !calendarState.isPrevious, 'rounded-r-md border border-l-0': !calendarState.isNext }"
-            @click="goToToday"
-          >
-            Dziś
-          </button>
-          <span class="relative -mx-px h-5 w-px bg-gray-300 md:hidden" />
-          <button
-            v-if="calendarState.isNext"
-            type="button"
-            class="flex items-center justify-center rounded-r-md border border-l-0 border-gray-300 bg-white py-2 pl-4 pr-3 text-gray-400 hover:text-gray-500 focus:relative md:w-9 md:px-2 md:hover:bg-gray-50"
-            @click="toNext"
-          >
-            <span class="sr-only">Następny {{ calendarState.viewMode.details.shortcut }}</span>
-            <ChevronRightIcon
-              class="h-5 w-5"
-              aria-hidden="true"
-            />
-          </button>
-        </div>
-      </div>
-      <Menu
-        as="div"
-        class="flex justify-end relative"
-      >
-        <MenuButton
-          type="button"
-          class="flex items-center rounded-md border border-gray-300 bg-white py-2 pl-3 pr-2 text-sm font-medium text-gray-700 shadow-sm hover:bg-gray-50"
-        >
-          {{ calendarState.viewMode.details.name }}
-          <ChevronDownIcon
-            class="ml-2 h-5 w-5 text-gray-400"
-            aria-hidden="true"
-          />
-        </MenuButton>
-
-        <transition
-          class="z-10"
-          enter-active-class="transition ease-out duration-100"
-          enter-from-class="transform opacity-0 scale-95"
-          enter-to-class="transform opacity-100 scale-100"
-          leave-active-class="transition ease-in duration-75"
-          leave-from-class="transform opacity-100 scale-100"
-          leave-to-class="transform opacity-0 scale-95"
-        >
-          <MenuItems class="absolute right-0 mt-3 w-36 origin-top-right overflow-hidden rounded-md bg-white shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none">
-            <div class="py-1">
-              <MenuItem
-                v-for="option in viewModes"
-                :key="option.key"
-                v-slot="{ active }"
-              >
-                <button
-                  :class="[active ? 'bg-gray-100 text-gray-900' : 'text-gray-700', 'flex px-4 py-2 text-sm text-left w-full']"
-                  @click="updateViewMode(option.key)"
-                >
-                  {{ option.shortcut }}
-                  <CheckIcon
-                    v-if="option.is(calendar.viewMode)"
-                    class="ml-2 w-5 h-5 text-blumilk-500"
-                  />
-                </button>
-              </MenuItem>
-            </div>
-          </MenuItems>
-        </transition>
-      </Menu>
-    </div>
-    <div class="ring-1 ring-black ring-opacity-5 lg:flex lg:flex-auto lg:flex-col">
-      <div
-        v-if="calendarState.viewMode.isMonth"
-        class="grid grid-cols-7 gap-px border-b border-gray-300 bg-gray-200 text-center text-xs font-semibold leading-6 text-gray-700 lg:flex-none"
-      >
-        <div class="bg-white py-2">
-          Pn
-        </div>
-        <div class="bg-white py-2">
-          Wt
-        </div>
-        <div class="bg-white py-2">
-          Śr
-        </div>
-        <div class="bg-white py-2">
-          Cz
-        </div>
-        <div class="bg-white py-2">
-          Pt
-        </div>
-        <div class="bg-red-100 py-2">
-          Sb
-        </div>
-        <div class="bg-red-100 py-2">
-          Nd
-        </div>
-      </div>
-      <div class="flex bg-gray-200 text-xs leading-6 text-gray-700 lg:flex-auto">
-        <div
-          class="w-full grid grid-cols-7 gap-px"
-          :class="{ 'grid-rows-1': calendarState.viewMode.isWeek }"
-        >
-          <DayComponent
-            v-for="(day, index) in days"
-            :key="index"
-            :day="day"
-            class="flex flex-col relative py-2 px-3"
-            :class="[day.isCurrentMonth ? 'bg-white' : 'bg-gray-50 text-gray-500', { 'hover:bg-blumilk-25': day.isCurrentMonth && !day.isWeekend }, { 'day': calendarState.viewMode.isWeek }, { 'bg-red-100': day.isCurrentMonth && day.isWeekend }, { 'bg-red-50': !day.isCurrentMonth && day.isWeekend }, { 'text-red-800': day.isWeekend }]"
-            :get-holiday-description="getHolidayDescription"
-            :get-vacation-border="getVacationBorder"
-            :get-vacation-info="getVacationInfo"
-          />
-        </div>
-      </div>
-    </div>
-  </section>
-</template>
-
-<script setup>
-import { CheckIcon, ChevronDownIcon, ChevronLeftIcon, ChevronRightIcon } from '@heroicons/vue/solid'
-import { Menu, MenuButton, MenuItem, MenuItems } from '@headlessui/vue'
-import { ref, watch, computed, reactive } from 'vue'
-import { DateTime } from 'luxon'
-import useVacationTypeInfo from '@/Composables/vacationTypeInfo'
-import useCurrentYearPeriodInfo from '@/Composables/yearPeriodInfo'
-import { useMonthInfo } from '@/Composables/monthInfo'
-import { viewModes, find as findViewMode } from '@/Shared/Widgets/Calendar/ViewModeOptions'
-import DayComponent from '@/Shared/Widgets/Calendar/DayComponent'
-
-const props = defineProps({
-  holidays: Object,
-  approvedVacations: Object,
-  pendingVacations: Object,
-})
-
-let days = ref([])
-
-function getCurrentDate() {
-  const { year, month, weekNumber } = DateTime.now()
-  return { year, month, week: weekNumber }
-}
-const currentDate = getCurrentDate()
-
-const months = useMonthInfo().getMonths()
-const { findType } = useVacationTypeInfo()
-const selectedYear = useCurrentYearPeriodInfo().year.value
-
-const calendar = {
-  viewMode: ref('week'),
-  currents: reactive({
-    year: selectedYear,
-    month: selectedYear === currentDate.year ? currentDate.month : 1,
-    week: selectedYear === currentDate.year ? currentDate.week : 0,
-  }),
-}
-
-const calendarState = reactive({
-  viewMode: {
-    isWeek: computed(() => calendar.viewMode.value === 'week'),
-    isMonth: computed(() => calendar.viewMode.value === 'month'),
-    details: computed(() => findViewMode(calendar.viewMode.value)),
-  },
-  monthName: computed(() => months[calendar.currents.month - 1]?.name),
-  isActualYear: computed(() => calendar.currents.year === DateTime.now().year),
-  isPrevious: computed(() => calendarState.viewMode.isMonth ? calendar.currents.month !== 1 : calendar.currents.week > 0),
-  isNext: computed(() => calendarState.viewMode.isMonth ? calendar.currents.month !== 12 : calendar.currents.week < DateTime.fromObject({ year: selectedYear, month: 12, day: 31 }).weekNumber),
-})
-
-const customCalendar = {
-  loadCalendar() {
-    const date = DateTime.fromObject({
-      year: calendar.currents.year,
-      month: calendarState.viewMode.isMonth ? calendar.currents.month : 1,
-      day: 1,
-    })
-    days.value = this.generateCalendarData(date)
-  },
-  generateCalendarData(date) {
-    const firstMonthDay = date.startOf('month')
-    const lastMonthDay = date.endOf('month')
-
-    if (calendarState.viewMode.isWeek) {
-      return this.generateWeekData(firstMonthDay.startOf('week'))
-    } else if (calendarState.viewMode.isMonth) {
-      return this.generateMonthData(firstMonthDay.startOf('week'), lastMonthDay.endOf('week'))
-    }
-    return []
-  },
-  generateWeekData(start) {
-    let days = [], startWeek
-    if (calendar.currents.month === 1 && calendar.currents.week === 0)
-      startWeek = DateTime.fromObject({ year: calendar.currents.year, month: 1, day: 1 }).startOf('week')
-    else if (calendarState.isActualYear)
-      startWeek = DateTime.fromObject({ weekNumber: calendar.currents.week })
-    else
-      startWeek = start.plus({ week: calendar.currents.week })
-    const endWeek = startWeek.endOf('week')
-    for (let day = startWeek; day < endWeek; day = day.plus({ day: 1 })) {
-      days.push(this.prepareDay(day))
-    }
-    return days
-  },
-  generateMonthData(start, end) {
-    let days = []
-    for (let day = start; day < end; day = day.plus({ day: 1 })) {
-      days.push(this.prepareDay(day))
-    }
-
-    return days
-  },
-  prepareDay(day) {
-    const isCurrentMonth = isInCurrentMonth(day)
-    return {
-      date: day.toISODate(),
-      dayNumber: day.day,
-      isCurrentMonth: isCurrentMonth,
-      isToday: isToday(day),
-      isWeekend: isWeekend(day),
-      isHoliday: isHoliday(day),
-      isVacation: isCurrentMonth && isVacation(day),
-      isPendingVacation: isCurrentMonth && isPendingVacation(day),
-    }
-  },
-}
-
-watch([calendar.viewMode, calendar.currents], () => {
-  customCalendar.loadCalendar()
-})
-
-customCalendar.loadCalendar()
-
-function toLast() {
-  if (calendar.viewMode.value === 'week')
-    minusWeek()
-  else
-    minusMonth()
-}
-
-function toNext() {
-  if (calendar.viewMode.value === 'week')
-    addWeek()
-  else
-    addMonth()
-}
-
-function resetCalendar(config = {}) {
-  const currentMonth = isUndefined(config.month) ? currentDate.month : config.month
-  const currentWeek = isUndefined(config.week) ? currentDate.week : config.week
-
-  calendar.currents.year = isUndefined(config.year) ? selectedYear : config.month
-  calendar.currents.month = calendarState.isActualYear || !isUndefined(config.year) ? currentMonth : 1
-  calendar.currents.week = calendarState.isActualYear || !isUndefined(config.week) ? currentWeek : 0
-}
-
-function isUndefined(value) {
-  return value === undefined
-}
-
-function addWeek(minus = false) {
-  const howMany = minus ? -1: 1
-  let nextMonth, date = DateTime.fromObject({
-    year: calendar.currents.year,
-    month: 1,
-    day: 1,
-  })
-
-  date = date.plus({ week: calendar.currents.week + howMany })
-
-  const startWeekDay = date.startOf('week'), endWeekDay = date.endOf('week')
-  nextMonth = howMany > 0 ? startWeekDay.month : endWeekDay.month
-  if (howMany < 0 && endWeekDay.day === endWeekDay.daysInMonth)
-    calendar.currents.week--
-  else if (howMany > 0 && startWeekDay.day === 1)
-    calendar.currents.week++
-
-  if (nextMonth !== calendar.currents.month) {
-    calendar.currents.month = calendar.currents.week > 1 ? nextMonth : 1
-    if (calendar.currents.week === 1)
-      calendar.currents.week = 0
-    return
-  }
-  calendar.currents.week += howMany
-}
-
-function minusWeek() {
-  addWeek(true)
-}
-
-function addMonth(minus = false) {
-  calendar.currents.month += minus ? -1 : 1
-}
-
-function minusMonth() {
-  addMonth(true)
-}
-
-function goToToday() {
-  resetCalendar({ year: currentDate.year, months: currentDate.month, week: currentDate.week })
-}
-
-function updateViewMode(type) {
-  if (type === 'month')
-    resetCalendar({ week: 0 })
-  else
-    resetCalendar()
-  calendar.viewMode.value = type
-}
-
-function isInCurrentMonth(date) {
-  return calendar.currents.month === date.month
-}
-
-function isWeekend(date) {
-  return date.weekday === 6 || date.weekday === 7
-}
-
-function isToday(date) {
-  return date.toISODate() === DateTime.local().toISODate()
-}
-
-function isHoliday(date) {
-  return props.holidays[date.toISODate()] !== undefined
-}
-
-function getHolidayDescription(day) {
-  return props.holidays[day.date]
-}
-
-function isVacation(date) {
-  return props.approvedVacations[date.toISODate()] !== undefined
-}
-
-function isPendingVacation(date) {
-  return props.pendingVacations[date.toISODate()] !== undefined
-}
-
-function getVacationBorder(day) {
-  return findType(getVacationInfo(day).type)?.border
-}
-
-function getVacationInfo(day) {
-  return day.isVacation ? props.approvedVacations[day.date] : props.pendingVacations[day.date]
-}
-</script>
-
-<style lang="css">
-.day:nth-of-type(7n - 6):before {
-  content: "Pn";
-}
-
-.day:nth-of-type(7n - 5):before {
-  content: "Wt";
-}
-
-.day:nth-of-type(7n - 4):before {
-  content: "Śr";
-}
-
-.day:nth-of-type(7n - 3):before {
-  content: "Cz";
-}
-
-.day:nth-of-type(7n - 2):before {
-  content: "Pt";
-}
-
-.day:nth-of-type(7n - 1):before {
-  content: "Sb";
-}
-
-.day:nth-of-type(7n):before {
-  content: "Nd";
-}
-</style>

tests/Feature/UserTest.php

@@ -73,10 +73,10 @@ class UserTest extends FeatureTestCase
 
     public function testUserListIsPaginated(): void
     {
-        User::factory()->count(15)->create();
+        User::factory()->count(50)->create();
         $admin = User::factory()->admin()->create();
 
-        $this->assertDatabaseCount("users", 16);
+        $this->assertDatabaseCount("users", 51);
 
         $this->actingAs($admin)
             ->get("/users?page=2")