From 4158e886342ee7a980210c668f73389893305e95 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 10:17:58 +0200
Subject: [PATCH 01/14] #120 - wip
---
app/Domain/Enums/VacationType.php | 1 +
app/Domain/VacationTypeConfigRetriever.php | 6 +++++
.../Http/Controllers/TimesheetController.php | 3 ++-
.../Controllers/VacationLimitController.php | 4 ++--
config/vacation_types.php | 22 +++++++++++++++++++
resources/js/Shared/VacationPopup.vue | 2 +-
resources/lang/pl.json | 1 +
7 files changed, 35 insertions(+), 4 deletions(-)
diff --git a/app/Domain/Enums/VacationType.php b/app/Domain/Enums/VacationType.php
index 71bdd41..a93ca3d 100644
--- a/app/Domain/Enums/VacationType.php
+++ b/app/Domain/Enums/VacationType.php
@@ -18,6 +18,7 @@ enum VacationType: string
case TimeInLieu = "time_in_lieu";
case Sick = "sick_vacation";
case Absence = "absence";
+ case HomeOffice = "home_office";
public function label(): string
{
diff --git a/app/Domain/VacationTypeConfigRetriever.php b/app/Domain/VacationTypeConfigRetriever.php
index 213fcc8..7865d41 100644
--- a/app/Domain/VacationTypeConfigRetriever.php
+++ b/app/Domain/VacationTypeConfigRetriever.php
@@ -15,6 +15,7 @@ class VacationTypeConfigRetriever
public const KEY_BILLABLE = "billable";
public const KEY_HAS_LIMIT = "has_limit";
public const KEY_AVAILABLE_FOR = "available_for";
+ public const KEY_IS_VACATION = "is_vacation";
public function __construct(
protected Repository $config,
@@ -40,6 +41,11 @@ class VacationTypeConfigRetriever
return $this->getConfigFor($type)[static::KEY_HAS_LIMIT];
}
+ public function isVacation(VacationType $type): bool
+ {
+ return $this->getConfigFor($type)[static::KEY_IS_VACATION];
+ }
+
public function isAvailableFor(VacationType $type, EmploymentForm $employmentForm): bool
{
return in_array($employmentForm, $this->getConfigFor($type)[static::KEY_AVAILABLE_FOR], true);
diff --git a/app/Infrastructure/Http/Controllers/TimesheetController.php b/app/Infrastructure/Http/Controllers/TimesheetController.php
index 3408bf5..16af5f6 100644
--- a/app/Infrastructure/Http/Controllers/TimesheetController.php
+++ b/app/Infrastructure/Http/Controllers/TimesheetController.php
@@ -35,7 +35,8 @@ class TimesheetController extends Controller
$types = VacationType::all()
->filter(
- fn(VacationType $type) => $configRetriever->isAvailableFor($type, EmploymentForm::EmploymentContract),
+ fn(VacationType $type) => $configRetriever->isAvailableFor($type, EmploymentForm::EmploymentContract)
+ && $configRetriever->isVacation($type),
);
$filename = "{$carbonMonth->translatedFormat("F Y")}.xlsx";
diff --git a/app/Infrastructure/Http/Controllers/VacationLimitController.php b/app/Infrastructure/Http/Controllers/VacationLimitController.php
index cb3c8ef..29c333e 100644
--- a/app/Infrastructure/Http/Controllers/VacationLimitController.php
+++ b/app/Infrastructure/Http/Controllers/VacationLimitController.php
@@ -11,7 +11,7 @@ use Toby\Eloquent\Helpers\YearPeriodRetriever;
use Toby\Eloquent\Models\VacationLimit;
use Toby\Eloquent\Models\YearPeriod;
use Toby\Infrastructure\Http\Requests\VacationLimitRequest;
-use Toby\Infrastructure\Http\Resources\SimpleUserResource;
+use Toby\Infrastructure\Http\Resources\UserResource;
class VacationLimitController extends Controller
{
@@ -32,7 +32,7 @@ class VacationLimitController extends Controller
$limitsResource = $limits->map(fn(VacationLimit $limit) => [
"id" => $limit->id,
- "user" => new SimpleUserResource($limit->user),
+ "user" => new UserResource($limit->user),
"hasVacation" => $limit->hasVacation(),
"days" => $limit->days,
"remainingLastYear" => $previousYearPeriod
diff --git a/config/vacation_types.php b/config/vacation_types.php
index e9b4402..f890546 100644
--- a/config/vacation_types.php
+++ b/config/vacation_types.php
@@ -15,6 +15,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::OnRequest->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
@@ -42,6 +43,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::Unpaid->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
@@ -51,6 +53,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::Special->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
@@ -60,6 +63,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::Childcare->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
@@ -69,6 +73,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::Training->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
@@ -79,6 +84,7 @@ return [
EmploymentForm::EmploymentContract,
],
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
VacationType::Volunteering->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
VacationTypeConfigRetriever::KEY_ADMINISTRATIVE_APPROVAL => true,
@@ -87,6 +93,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::Volunteering->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
@@ -96,6 +103,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::Absence->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => true,
@@ -107,5 +115,19 @@ return [
EmploymentForm::B2bContract,
EmploymentForm::BoardMemberContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
+ ],
+ VacationType::HomeOffice->value => [
+ VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => false,
+ VacationTypeConfigRetriever::KEY_ADMINISTRATIVE_APPROVAL => false,
+ VacationTypeConfigRetriever::KEY_BILLABLE => true,
+ VacationTypeConfigRetriever::KEY_HAS_LIMIT => false,
+ VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
+ EmploymentForm::EmploymentContract,
+ EmploymentForm::CommissionContract,
+ EmploymentForm::B2bContract,
+ EmploymentForm::BoardMemberContract,
+ ],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => false,
],
];
diff --git a/resources/js/Shared/VacationPopup.vue b/resources/js/Shared/VacationPopup.vue
index 79aba5a..2ace025 100644
--- a/resources/js/Shared/VacationPopup.vue
+++ b/resources/js/Shared/VacationPopup.vue
@@ -16,7 +16,7 @@
- Rodzaj urlopu
+ Rodzaj wniosku
diff --git a/resources/lang/pl.json b/resources/lang/pl.json
index 9cc41ae..5df56a5 100644
--- a/resources/lang/pl.json
+++ b/resources/lang/pl.json
@@ -15,6 +15,7 @@
"time_in_lieu": "Odbiór za święto",
"sick_vacation": "Zwolnienie lekarskie",
"absence": "Nieobecność",
+ "home_office": "Biuro w domu",
"employee": "Pracownik",
"administrator": "Administrator",
"technical_approver": "Techniczny akceptujący",
--
2.52.0
From 889af3aaa27574c4d14732d8eea6a7442f868ccb Mon Sep 17 00:00:00 2001
From: EwelinaLasowy
Date: Wed, 20 Apr 2022 10:38:17 +0200
Subject: [PATCH 02/14] #120 - add icon to home office
---
resources/js/Composables/vacationTypeInfo.js | 8 ++++++++
resources/lang/pl.json | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/resources/js/Composables/vacationTypeInfo.js b/resources/js/Composables/vacationTypeInfo.js
index 4f154cb..ff6ee92 100644
--- a/resources/js/Composables/vacationTypeInfo.js
+++ b/resources/js/Composables/vacationTypeInfo.js
@@ -8,6 +8,7 @@ import HandHeartOutlineIcon from 'vue-material-design-icons/HandHeartOutline.vue
import CalendarCheckIcon from 'vue-material-design-icons/CalendarCheck.vue'
import MedicalBagIcon from 'vue-material-design-icons/MedicalBag.vue'
import CalendarRemoveIcon from 'vue-material-design-icons/CalendarRemove.vue'
+import LaptopIcon from 'vue-material-design-icons/Laptop.vue';
const types = [
{
@@ -80,6 +81,13 @@ const types = [
color: 'text-cyan-500',
border: 'border-cyan-500',
},
+ {
+ text: 'Praca zdalna',
+ value: 'home_office',
+ icon: LaptopIcon,
+ color: 'text-fuchsia-500',
+ border: 'border-fuchsia-500',
+ },
]
export default function useVacationTypeInfo() {
diff --git a/resources/lang/pl.json b/resources/lang/pl.json
index 5df56a5..c288aba 100644
--- a/resources/lang/pl.json
+++ b/resources/lang/pl.json
@@ -15,7 +15,7 @@
"time_in_lieu": "Odbiór za święto",
"sick_vacation": "Zwolnienie lekarskie",
"absence": "Nieobecność",
- "home_office": "Biuro w domu",
+ "home_office": "Praca zdalna",
"employee": "Pracownik",
"administrator": "Administrator",
"technical_approver": "Techniczny akceptujący",
--
2.52.0
From a149f05b9b6a37ab1ac01674629ba6df909dcbd1 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 10:48:09 +0200
Subject: [PATCH 03/14] #120 - wip
---
app/Domain/UserVacationStatsRetriever.php | 13 ++++++++++++-
.../Http/Controllers/DashboardController.php | 2 ++
config/vacation_types.php | 3 +++
resources/js/Shared/Widgets/VacationStats.vue | 13 ++++++++++++-
4 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/app/Domain/UserVacationStatsRetriever.php b/app/Domain/UserVacationStatsRetriever.php
index 21967cb..e0d7c93 100644
--- a/app/Domain/UserVacationStatsRetriever.php
+++ b/app/Domain/UserVacationStatsRetriever.php
@@ -34,10 +34,10 @@ class UserVacationStatsRetriever
public function getUsedVacationDaysByMonth(User $user, YearPeriod $yearPeriod): Collection
{
return $user->vacations()
+ ->whereBelongsTo($yearPeriod)
->whereRelation(
"vacationRequest",
fn(Builder $query): Builder => $query
- ->whereBelongsTo($yearPeriod)
->whereIn("type", $this->getLimitableVacationTypes())
->states(VacationRequestStatesRetriever::successStates()),
)
@@ -69,11 +69,21 @@ class UserVacationStatsRetriever
"vacationRequest",
fn(Builder $query): Builder => $query
->whereIn("type", $this->getNotLimitableVacationTypes())
+ ->whereNot("type", VacationType::HomeOffice)
->states(VacationRequestStatesRetriever::successStates()),
)
->count();
}
+ public function getHomeOfficeDays(User $user, YearPeriod $yearPeriod): int
+ {
+ return $user
+ ->vacations()
+ ->whereBelongsTo($yearPeriod)
+ ->whereRelation("vacationRequest", "type", VacationType::HomeOffice)
+ ->count();
+ }
+
public function getRemainingVacationDays(User $user, YearPeriod $yearPeriod): int
{
$limit = $this->getVacationDaysLimit($user, $yearPeriod);
@@ -106,4 +116,5 @@ class UserVacationStatsRetriever
return $types->filter(fn(VacationType $type) => !$this->configRetriever->hasLimit($type));
}
+
}
diff --git a/app/Infrastructure/Http/Controllers/DashboardController.php b/app/Infrastructure/Http/Controllers/DashboardController.php
index a0fb994..8be109b 100644
--- a/app/Infrastructure/Http/Controllers/DashboardController.php
+++ b/app/Infrastructure/Http/Controllers/DashboardController.php
@@ -57,6 +57,7 @@ class DashboardController extends Controller
$limit = $vacationStatsRetriever->getVacationDaysLimit($user, $yearPeriod);
$used = $vacationStatsRetriever->getUsedVacationDays($user, $yearPeriod);
$pending = $vacationStatsRetriever->getPendingVacationDays($user, $yearPeriod);
+ $homeOffice = $vacationStatsRetriever->getHomeOfficeDays($user, $yearPeriod);
$other = $vacationStatsRetriever->getOtherApprovedVacationDays($user, $yearPeriod);
$remaining = $limit - $used - $pending;
@@ -69,6 +70,7 @@ class DashboardController extends Controller
"remaining" => $remaining,
"used" => $used,
"pending" => $pending,
+ "homeOffice" => $homeOffice,
"other" => $other,
],
"can" => [
diff --git a/config/vacation_types.php b/config/vacation_types.php
index f890546..806cbbc 100644
--- a/config/vacation_types.php
+++ b/config/vacation_types.php
@@ -25,6 +25,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::TimeInLieu->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => false,
@@ -34,6 +35,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationType::Sick->value => [
VacationTypeConfigRetriever::KEY_TECHNICAL_APPROVAL => false,
@@ -83,6 +85,7 @@ return [
VacationTypeConfigRetriever::KEY_AVAILABLE_FOR => [
EmploymentForm::EmploymentContract,
],
+ VacationTypeConfigRetriever::KEY_IS_VACATION => true,
],
VacationTypeConfigRetriever::KEY_IS_VACATION => true,
VacationType::Volunteering->value => [
diff --git a/resources/js/Shared/Widgets/VacationStats.vue b/resources/js/Shared/Widgets/VacationStats.vue
index a2af181..9365173 100644
--- a/resources/js/Shared/Widgets/VacationStats.vue
+++ b/resources/js/Shared/Widgets/VacationStats.vue
@@ -49,7 +49,7 @@
Twój roczny limit urlopu wypoczynkowego.
-
+
{{ stats.other }}
@@ -60,6 +60,17 @@
Urlopy bezpłatne, okolicznościowe, zwolnienia lekarskie, itd., które zostały już zatwierdzone.
+
+
+ {{ stats.homeOffice }}
+
+
+ Biuro w domu
+
+
+ Biuro w domku
+
+
--
2.52.0
From 4c5627c06735188596e706095c0e5abe634e4416 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 10:51:44 +0200
Subject: [PATCH 04/14] #120 - wip
---
resources/js/Pages/VacationRequest/Create.vue | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/resources/js/Pages/VacationRequest/Create.vue b/resources/js/Pages/VacationRequest/Create.vue
index 212ab31..7489fcf 100644
--- a/resources/js/Pages/VacationRequest/Create.vue
+++ b/resources/js/Pages/VacationRequest/Create.vue
@@ -142,7 +142,9 @@
:class="{ 'border-red-300 text-red-900 focus:ring-red-500 focus:border-red-500': form.errors.type, 'focus:ring-blumilk-500 focus:border-blumilk-500 sm:text-sm border-gray-300': !form.errors.type }"
>
- {{ form.vacationType.label }}
+
+
+
@@ -166,7 +168,7 @@
>
- {{ vacationType.label }}
+
Date: Wed, 20 Apr 2022 11:17:21 +0200
Subject: [PATCH 05/14] #120 - wip
---
app/Domain/Actions/VacationRequest/ApproveAction.php | 8 ++++++--
resources/js/Pages/Users/Create.vue | 4 ++--
resources/js/Pages/VacationRequest/Create.vue | 4 ++--
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/app/Domain/Actions/VacationRequest/ApproveAction.php b/app/Domain/Actions/VacationRequest/ApproveAction.php
index 3d55542..a6d5896 100644
--- a/app/Domain/Actions/VacationRequest/ApproveAction.php
+++ b/app/Domain/Actions/VacationRequest/ApproveAction.php
@@ -7,6 +7,7 @@ namespace Toby\Domain\Actions\VacationRequest;
use Toby\Domain\Enums\Role;
use Toby\Domain\Notifications\VacationRequestStatusChangedNotification;
use Toby\Domain\VacationRequestStateManager;
+use Toby\Domain\VacationTypeConfigRetriever;
use Toby\Eloquent\Models\User;
use Toby\Eloquent\Models\VacationRequest;
use Toby\Infrastructure\Jobs\SendVacationRequestDaysToGoogleCalendar;
@@ -15,15 +16,18 @@ class ApproveAction
{
public function __construct(
protected VacationRequestStateManager $stateManager,
+ protected VacationTypeConfigRetriever $configRetriever,
) {}
public function execute(VacationRequest $vacationRequest, ?User $user = null): void
{
$this->stateManager->approve($vacationRequest, $user);
- SendVacationRequestDaysToGoogleCalendar::dispatch($vacationRequest);
+ if ($this->configRetriever->isVacation($vacationRequest->type)) {
+ SendVacationRequestDaysToGoogleCalendar::dispatch($vacationRequest);
- $this->notify($vacationRequest);
+ $this->notify($vacationRequest);
+ }
}
protected function notify(VacationRequest $vacationRequest): void
diff --git a/resources/js/Pages/Users/Create.vue b/resources/js/Pages/Users/Create.vue
index d56ca33..8962bda 100644
--- a/resources/js/Pages/Users/Create.vue
+++ b/resources/js/Pages/Users/Create.vue
@@ -133,7 +133,7 @@
as="template"
:value="role"
>
-
+
{{ role.label }}
@@ -188,7 +188,7 @@
as="template"
:value="employmentForm"
>
-
+
{{ employmentForm.label }}
diff --git a/resources/js/Pages/VacationRequest/Create.vue b/resources/js/Pages/VacationRequest/Create.vue
index 7489fcf..fa6f8fa 100644
--- a/resources/js/Pages/VacationRequest/Create.vue
+++ b/resources/js/Pages/VacationRequest/Create.vue
@@ -72,7 +72,7 @@
as="template"
:value="user"
>
-
+
![]()
-
+
--
2.52.0
From 05002dbc33ce96e5d0584330f003ca4fbe644ba6 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 11:57:19 +0200
Subject: [PATCH 06/14] #120 - wip
---
.../Http/Controllers/VacationRequestController.php | 12 ++++++++++--
.../Http/Resources/VacationRequestResource.php | 10 ++++++++++
resources/js/Pages/VacationRequest/Show.vue | 5 ++++-
3 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/app/Infrastructure/Http/Controllers/VacationRequestController.php b/app/Infrastructure/Http/Controllers/VacationRequestController.php
index 64dfc56..665b4e3 100644
--- a/app/Infrastructure/Http/Controllers/VacationRequestController.php
+++ b/app/Infrastructure/Http/Controllers/VacationRequestController.php
@@ -12,6 +12,7 @@ use Illuminate\Http\Request;
use Illuminate\Http\Response as LaravelResponse;
use Illuminate\Validation\ValidationException;
use Inertia\Response;
+use Symfony\Component\HttpFoundation\Response as SymfonyResponse;
use Toby\Domain\Actions\VacationRequest\AcceptAsAdministrativeAction;
use Toby\Domain\Actions\VacationRequest\AcceptAsTechnicalAction;
use Toby\Domain\Actions\VacationRequest\CancelAction;
@@ -23,6 +24,7 @@ use Toby\Domain\States\VacationRequest\AcceptedByTechnical;
use Toby\Domain\States\VacationRequest\Cancelled;
use Toby\Domain\States\VacationRequest\Rejected;
use Toby\Domain\VacationRequestStatesRetriever;
+use Toby\Domain\VacationTypeConfigRetriever;
use Toby\Eloquent\Helpers\YearPeriodRetriever;
use Toby\Eloquent\Models\User;
use Toby\Eloquent\Models\VacationRequest;
@@ -148,8 +150,14 @@ class VacationRequestController extends Controller
/**
* @throws AuthorizationException
*/
- public function download(VacationRequest $vacationRequest): LaravelResponse
- {
+ public function download(
+ VacationRequest $vacationRequest,
+ VacationTypeConfigRetriever $configRetriever
+ ): LaravelResponse {
+ if (!$configRetriever->isVacation($vacationRequest->type)) {
+ return abort(SymfonyResponse::HTTP_NOT_FOUND);
+ }
+
$this->authorize("show", $vacationRequest);
$pdf = PDF::loadView("pdf.vacation-request", [
diff --git a/app/Infrastructure/Http/Resources/VacationRequestResource.php b/app/Infrastructure/Http/Resources/VacationRequestResource.php
index ddd6f4b..ddcafe7 100644
--- a/app/Infrastructure/Http/Resources/VacationRequestResource.php
+++ b/app/Infrastructure/Http/Resources/VacationRequestResource.php
@@ -5,10 +5,19 @@ declare(strict_types=1);
namespace Toby\Infrastructure\Http\Resources;
use Illuminate\Http\Resources\Json\JsonResource;
+use Toby\Domain\VacationTypeConfigRetriever;
class VacationRequestResource extends JsonResource
{
public static $wrap = null;
+ protected VacationTypeConfigRetriever $configRetriever;
+
+ public function __construct($resource)
+ {
+ parent::__construct($resource);
+
+ $this->configRetriever = app(VacationTypeConfigRetriever::class);
+ }
public function toArray($request): array
{
@@ -17,6 +26,7 @@ class VacationRequestResource extends JsonResource
"name" => $this->name,
"user" => new SimpleUserResource($this->user),
"type" => $this->type,
+ "isVacation" => $this->configRetriever->isVacation($this->type),
"state" => $this->state,
"from" => $this->from->toDisplayString(),
"to" => $this->to->toDisplayString(),
diff --git a/resources/js/Pages/VacationRequest/Show.vue b/resources/js/Pages/VacationRequest/Show.vue
index 36ccb91..ad58a1e 100644
--- a/resources/js/Pages/VacationRequest/Show.vue
+++ b/resources/js/Pages/VacationRequest/Show.vue
@@ -88,7 +88,10 @@
-
-
+
Załączniki
--
2.52.0
From db70c3885f66fa4ec83772ba8faeb228c668cce1 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 12:20:56 +0200
Subject: [PATCH 07/14] #120 - wip
---
app/Domain/Actions/VacationRequest/CreateAction.php | 5 ++++-
.../Actions/VacationRequest/WaitForAdminApprovalAction.php | 6 ++++--
.../Actions/VacationRequest/WaitForTechApprovalAction.php | 4 +++-
app/Domain/UserVacationStatsRetriever.php | 1 -
.../Http/Controllers/VacationRequestController.php | 2 +-
resources/js/Composables/vacationTypeInfo.js | 2 +-
6 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/app/Domain/Actions/VacationRequest/CreateAction.php b/app/Domain/Actions/VacationRequest/CreateAction.php
index 3915d6e..8a823e3 100644
--- a/app/Domain/Actions/VacationRequest/CreateAction.php
+++ b/app/Domain/Actions/VacationRequest/CreateAction.php
@@ -32,7 +32,10 @@ class CreateAction
{
$vacationRequest = $this->createVacationRequest($data, $creator);
$this->handleCreatedVacationRequest($vacationRequest);
- $this->notify($vacationRequest);
+
+ if ($this->configRetriever->isVacation($vacationRequest->type)) {
+ $this->notify($vacationRequest);
+ }
return $vacationRequest;
}
diff --git a/app/Domain/Actions/VacationRequest/WaitForAdminApprovalAction.php b/app/Domain/Actions/VacationRequest/WaitForAdminApprovalAction.php
index 833b470..f36449e 100644
--- a/app/Domain/Actions/VacationRequest/WaitForAdminApprovalAction.php
+++ b/app/Domain/Actions/VacationRequest/WaitForAdminApprovalAction.php
@@ -23,10 +23,12 @@ class WaitForAdminApprovalAction
{
$this->stateManager->waitForAdministrative($vacationRequest);
- $this->waitForAdminApprovers($vacationRequest);
+ if ($this->configRetriever->isVacation($vacationRequest->type)) {
+ $this->notifyAdminApprovers($vacationRequest);
+ }
}
- protected function waitForAdminApprovers(VacationRequest $vacationRequest): void
+ protected function notifyAdminApprovers(VacationRequest $vacationRequest): void
{
$users = User::query()
->whereIn("role", [Role::AdministrativeApprover, Role::Administrator])
diff --git a/app/Domain/Actions/VacationRequest/WaitForTechApprovalAction.php b/app/Domain/Actions/VacationRequest/WaitForTechApprovalAction.php
index 1686698..8035acd 100644
--- a/app/Domain/Actions/VacationRequest/WaitForTechApprovalAction.php
+++ b/app/Domain/Actions/VacationRequest/WaitForTechApprovalAction.php
@@ -23,7 +23,9 @@ class WaitForTechApprovalAction
{
$this->stateManager->waitForTechnical($vacationRequest);
- $this->notifyTechApprovers($vacationRequest);
+ if ($this->configRetriever->isVacation($vacationRequest->type)) {
+ $this->notifyTechApprovers($vacationRequest);
+ }
}
protected function notifyTechApprovers(VacationRequest $vacationRequest): void
diff --git a/app/Domain/UserVacationStatsRetriever.php b/app/Domain/UserVacationStatsRetriever.php
index e0d7c93..7c11a29 100644
--- a/app/Domain/UserVacationStatsRetriever.php
+++ b/app/Domain/UserVacationStatsRetriever.php
@@ -116,5 +116,4 @@ class UserVacationStatsRetriever
return $types->filter(fn(VacationType $type) => !$this->configRetriever->hasLimit($type));
}
-
}
diff --git a/app/Infrastructure/Http/Controllers/VacationRequestController.php b/app/Infrastructure/Http/Controllers/VacationRequestController.php
index 665b4e3..3ae5187 100644
--- a/app/Infrastructure/Http/Controllers/VacationRequestController.php
+++ b/app/Infrastructure/Http/Controllers/VacationRequestController.php
@@ -152,7 +152,7 @@ class VacationRequestController extends Controller
*/
public function download(
VacationRequest $vacationRequest,
- VacationTypeConfigRetriever $configRetriever
+ VacationTypeConfigRetriever $configRetriever,
): LaravelResponse {
if (!$configRetriever->isVacation($vacationRequest->type)) {
return abort(SymfonyResponse::HTTP_NOT_FOUND);
diff --git a/resources/js/Composables/vacationTypeInfo.js b/resources/js/Composables/vacationTypeInfo.js
index ff6ee92..3ed7591 100644
--- a/resources/js/Composables/vacationTypeInfo.js
+++ b/resources/js/Composables/vacationTypeInfo.js
@@ -8,7 +8,7 @@ import HandHeartOutlineIcon from 'vue-material-design-icons/HandHeartOutline.vue
import CalendarCheckIcon from 'vue-material-design-icons/CalendarCheck.vue'
import MedicalBagIcon from 'vue-material-design-icons/MedicalBag.vue'
import CalendarRemoveIcon from 'vue-material-design-icons/CalendarRemove.vue'
-import LaptopIcon from 'vue-material-design-icons/Laptop.vue';
+import LaptopIcon from 'vue-material-design-icons/Laptop.vue'
const types = [
{
--
2.52.0
From 199a562c07e140c2bbfd67272c3b9b321728de04 Mon Sep 17 00:00:00 2001
From: EwelinaLasowy
Date: Wed, 20 Apr 2022 12:52:43 +0200
Subject: [PATCH 08/14] #120 - ui fixes
---
resources/js/Shared/Widgets/VacationStats.vue | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/resources/js/Shared/Widgets/VacationStats.vue b/resources/js/Shared/Widgets/VacationStats.vue
index 9365173..1dc2e5d 100644
--- a/resources/js/Shared/Widgets/VacationStats.vue
+++ b/resources/js/Shared/Widgets/VacationStats.vue
@@ -39,7 +39,7 @@
-
+
{{ stats.limit }}
@@ -50,7 +50,7 @@
-
+
{{ stats.other }}
@@ -61,14 +61,14 @@
-
+
{{ stats.homeOffice }}
- Biuro w domu
+ Praca zdalna
- Biuro w domku
+ Dni przepracowane poza biurem.
--
2.52.0
From d6e29affddcb0b4c1cdfd297fae7739e71ee79e7 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 13:04:00 +0200
Subject: [PATCH 09/14] #120 - fix
---
resources/js/Pages/Users/Edit.vue | 4 ++--
resources/js/Pages/VacationRequest/Index.vue | 2 +-
resources/js/Pages/VacationRequest/IndexForApprovers.vue | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/resources/js/Pages/Users/Edit.vue b/resources/js/Pages/Users/Edit.vue
index 05505d2..09f82e1 100644
--- a/resources/js/Pages/Users/Edit.vue
+++ b/resources/js/Pages/Users/Edit.vue
@@ -136,7 +136,7 @@
:value="role"
>
{{ role.label }}
@@ -194,7 +194,7 @@
:value="employmentForm"
>
{{ employmentForm.label }}
diff --git a/resources/js/Pages/VacationRequest/Index.vue b/resources/js/Pages/VacationRequest/Index.vue
index 465d070..0526dd5 100644
--- a/resources/js/Pages/VacationRequest/Index.vue
+++ b/resources/js/Pages/VacationRequest/Index.vue
@@ -70,7 +70,7 @@
:value="status"
>
{{ status.name }}
diff --git a/resources/js/Pages/VacationRequest/IndexForApprovers.vue b/resources/js/Pages/VacationRequest/IndexForApprovers.vue
index e20ab1c..75acd64 100644
--- a/resources/js/Pages/VacationRequest/IndexForApprovers.vue
+++ b/resources/js/Pages/VacationRequest/IndexForApprovers.vue
@@ -61,7 +61,7 @@
:value="null"
>
Wszyscy
@@ -83,7 +83,7 @@
:value="user"
>
{{ status.name }}
--
2.52.0
From eed6e3a5e873bd52a9ab3b2bd4e378548165e498 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 13:24:56 +0200
Subject: [PATCH 10/14] #120 - fix
---
resources/js/Pages/Users/Create.vue | 4 ++--
resources/js/Pages/Users/Edit.vue | 4 ++--
resources/js/Pages/VacationRequest/Create.vue | 4 ++--
resources/js/Pages/VacationRequest/Index.vue | 2 +-
resources/js/Pages/VacationRequest/IndexForApprovers.vue | 6 +++---
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/resources/js/Pages/Users/Create.vue b/resources/js/Pages/Users/Create.vue
index 8962bda..4959b47 100644
--- a/resources/js/Pages/Users/Create.vue
+++ b/resources/js/Pages/Users/Create.vue
@@ -140,7 +140,7 @@
@@ -195,7 +195,7 @@
diff --git a/resources/js/Pages/Users/Edit.vue b/resources/js/Pages/Users/Edit.vue
index 09f82e1..3ede6b9 100644
--- a/resources/js/Pages/Users/Edit.vue
+++ b/resources/js/Pages/Users/Edit.vue
@@ -144,7 +144,7 @@
@@ -202,7 +202,7 @@
diff --git a/resources/js/Pages/VacationRequest/Create.vue b/resources/js/Pages/VacationRequest/Create.vue
index fa6f8fa..fe39c11 100644
--- a/resources/js/Pages/VacationRequest/Create.vue
+++ b/resources/js/Pages/VacationRequest/Create.vue
@@ -86,7 +86,7 @@
@@ -173,7 +173,7 @@
diff --git a/resources/js/Pages/VacationRequest/Index.vue b/resources/js/Pages/VacationRequest/Index.vue
index 0526dd5..38427ff 100644
--- a/resources/js/Pages/VacationRequest/Index.vue
+++ b/resources/js/Pages/VacationRequest/Index.vue
@@ -76,7 +76,7 @@
diff --git a/resources/js/Pages/VacationRequest/IndexForApprovers.vue b/resources/js/Pages/VacationRequest/IndexForApprovers.vue
index 75acd64..d055c3f 100644
--- a/resources/js/Pages/VacationRequest/IndexForApprovers.vue
+++ b/resources/js/Pages/VacationRequest/IndexForApprovers.vue
@@ -69,7 +69,7 @@
@@ -98,7 +98,7 @@
@@ -149,7 +149,7 @@
--
2.52.0
From 847d929c77ec82a65be66444cd26922fc4de5cc2 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 13:24:56 +0200
Subject: [PATCH 11/14] #120 - fix
---
.../Rules/VacationTypeCanBeSelected.php | 31 ++++++++++++++++
.../Validation/VacationRequestValidator.php | 2 +
app/Eloquent/Models/Vacation.php | 9 +++++
.../Http/Controllers/DashboardController.php | 16 +++++++-
.../Http/Resources/AbsenceResource.php | 21 -----------
.../Http/Resources/VacationResource.php | 1 +
resources/js/Pages/Dashboard.vue | 8 +++-
resources/js/Pages/Users/Create.vue | 4 +-
resources/js/Pages/Users/Edit.vue | 4 +-
resources/js/Pages/VacationRequest/Create.vue | 4 +-
resources/js/Pages/VacationRequest/Index.vue | 2 +-
.../VacationRequest/IndexForApprovers.vue | 6 +--
resources/js/Shared/Widgets/AbsenceList.vue | 5 ---
.../js/Shared/Widgets/HomeOfficeList.vue | 37 +++++++++++++++++++
tests/Feature/VacationRequestTest.php | 27 +++++++++++---
15 files changed, 132 insertions(+), 45 deletions(-)
create mode 100644 app/Domain/Validation/Rules/VacationTypeCanBeSelected.php
delete mode 100644 app/Infrastructure/Http/Resources/AbsenceResource.php
create mode 100644 resources/js/Shared/Widgets/HomeOfficeList.vue
diff --git a/app/Domain/Validation/Rules/VacationTypeCanBeSelected.php b/app/Domain/Validation/Rules/VacationTypeCanBeSelected.php
new file mode 100644
index 0000000..2a7050f
--- /dev/null
+++ b/app/Domain/Validation/Rules/VacationTypeCanBeSelected.php
@@ -0,0 +1,31 @@
+user->profile->employment_form;
+
+ $availableTypes = VacationType::all()
+ ->filter(fn(VacationType $type) => $this->configRetriever->isAvailableFor($type, $employmentForm));
+
+ return $availableTypes->contains($vacationRequest->type);
+ }
+
+ public function errorMessage(): string
+ {
+ return __("You cannot create vacation request of this type.");
+ }
+}
diff --git a/app/Domain/Validation/VacationRequestValidator.php b/app/Domain/Validation/VacationRequestValidator.php
index 57f8fa8..de87941 100644
--- a/app/Domain/Validation/VacationRequestValidator.php
+++ b/app/Domain/Validation/VacationRequestValidator.php
@@ -12,6 +12,7 @@ use Toby\Domain\Validation\Rules\NoApprovedVacationRequestsInRange;
use Toby\Domain\Validation\Rules\NoPendingVacationRequestInRange;
use Toby\Domain\Validation\Rules\VacationRangeIsInTheSameYearRule;
use Toby\Domain\Validation\Rules\VacationRequestRule;
+use Toby\Domain\Validation\Rules\VacationTypeCanBeSelected;
use Toby\Eloquent\Models\VacationRequest;
class VacationRequestValidator
@@ -19,6 +20,7 @@ class VacationRequestValidator
protected array $rules = [
VacationRangeIsInTheSameYearRule::class,
MinimumOneVacationDayRule::class,
+ VacationTypeCanBeSelected::class,
DoesNotExceedLimitRule::class,
NoPendingVacationRequestInRange::class,
NoApprovedVacationRequestsInRange::class,
diff --git a/app/Eloquent/Models/Vacation.php b/app/Eloquent/Models/Vacation.php
index a602042..9410764 100644
--- a/app/Eloquent/Models/Vacation.php
+++ b/app/Eloquent/Models/Vacation.php
@@ -9,6 +9,7 @@ use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Support\Carbon;
+use Illuminate\Support\Collection;
use Toby\Domain\VacationRequestStatesRetriever;
/**
@@ -58,4 +59,12 @@ class Vacation extends Model
fn(Builder $query): Builder => $query->states(VacationRequestStatesRetriever::pendingStates()),
);
}
+
+ public function scopeWhereTypes(Builder $query, Collection $types): Builder
+ {
+ return $query->whereRelation(
+ "vacationRequest",
+ fn(Builder $query): Builder => $query->whereIn("type", $types),
+ );
+ }
}
diff --git a/app/Infrastructure/Http/Controllers/DashboardController.php b/app/Infrastructure/Http/Controllers/DashboardController.php
index 8be109b..33bf1aa 100644
--- a/app/Infrastructure/Http/Controllers/DashboardController.php
+++ b/app/Infrastructure/Http/Controllers/DashboardController.php
@@ -7,14 +7,16 @@ namespace Toby\Infrastructure\Http\Controllers;
use Illuminate\Http\Request;
use Illuminate\Support\Carbon;
use Inertia\Response;
+use Toby\Domain\Enums\VacationType;
use Toby\Domain\UserVacationStatsRetriever;
use Toby\Domain\VacationRequestStatesRetriever;
+use Toby\Domain\VacationTypeConfigRetriever;
use Toby\Eloquent\Helpers\YearPeriodRetriever;
use Toby\Eloquent\Models\Vacation;
use Toby\Eloquent\Models\VacationRequest;
-use Toby\Infrastructure\Http\Resources\AbsenceResource;
use Toby\Infrastructure\Http\Resources\HolidayResource;
use Toby\Infrastructure\Http\Resources\VacationRequestResource;
+use Toby\Infrastructure\Http\Resources\VacationResource;
class DashboardController extends Controller
{
@@ -22,6 +24,7 @@ class DashboardController extends Controller
Request $request,
YearPeriodRetriever $yearPeriodRetriever,
UserVacationStatsRetriever $vacationStatsRetriever,
+ VacationTypeConfigRetriever $configRetriever,
): Response {
$user = $request->user();
$now = Carbon::now();
@@ -31,6 +34,14 @@ class DashboardController extends Controller
->with(["user", "vacationRequest"])
->whereDate("date", $now)
->approved()
+ ->whereTypes(VacationType::all()->filter(fn(VacationType $type) => $configRetriever->isVacation($type)))
+ ->get();
+
+ $remoteDays = Vacation::query()
+ ->with(["user", "vacationRequest"])
+ ->whereDate("date", $now)
+ ->approved()
+ ->whereTypes(VacationType::all()->filter(fn(VacationType $type) => !$configRetriever->isVacation($type)))
->get();
if ($user->can("listAll", VacationRequest::class)) {
@@ -62,7 +73,8 @@ class DashboardController extends Controller
$remaining = $limit - $used - $pending;
return inertia("Dashboard", [
- "absences" => AbsenceResource::collection($absences),
+ "absences" => VacationResource::collection($absences),
+ "remoteDays" => VacationResource::collection($remoteDays),
"vacationRequests" => VacationRequestResource::collection($vacationRequests),
"holidays" => HolidayResource::collection($holidays),
"stats" => [
diff --git a/app/Infrastructure/Http/Resources/AbsenceResource.php b/app/Infrastructure/Http/Resources/AbsenceResource.php
deleted file mode 100644
index e15d2fc..0000000
--- a/app/Infrastructure/Http/Resources/AbsenceResource.php
+++ /dev/null
@@ -1,21 +0,0 @@
- $this->id,
- "user" => new SimpleUserResource($this->user),
- "date" => $this->date->toDisplayString(),
- ];
- }
-}
diff --git a/app/Infrastructure/Http/Resources/VacationResource.php b/app/Infrastructure/Http/Resources/VacationResource.php
index e9590e3..fed9e76 100644
--- a/app/Infrastructure/Http/Resources/VacationResource.php
+++ b/app/Infrastructure/Http/Resources/VacationResource.php
@@ -14,6 +14,7 @@ class VacationResource extends JsonResource
{
return [
"id" => $this->id,
+ "user" => new SimpleUserResource($this->user),
"displayDate" => $this->date->toDisplayString(),
"date" => $this->date->toDateString(),
];
diff --git a/resources/js/Pages/Dashboard.vue b/resources/js/Pages/Dashboard.vue
index ae4a270..c048343 100644
--- a/resources/js/Pages/Dashboard.vue
+++ b/resources/js/Pages/Dashboard.vue
@@ -15,9 +15,13 @@
:requests="vacationRequests.data"
/>
+
@@ -195,7 +195,7 @@
diff --git a/resources/js/Pages/Users/Edit.vue b/resources/js/Pages/Users/Edit.vue
index 09f82e1..3ede6b9 100644
--- a/resources/js/Pages/Users/Edit.vue
+++ b/resources/js/Pages/Users/Edit.vue
@@ -144,7 +144,7 @@
@@ -202,7 +202,7 @@
diff --git a/resources/js/Pages/VacationRequest/Create.vue b/resources/js/Pages/VacationRequest/Create.vue
index fa6f8fa..fe39c11 100644
--- a/resources/js/Pages/VacationRequest/Create.vue
+++ b/resources/js/Pages/VacationRequest/Create.vue
@@ -86,7 +86,7 @@
@@ -173,7 +173,7 @@
diff --git a/resources/js/Pages/VacationRequest/Index.vue b/resources/js/Pages/VacationRequest/Index.vue
index 0526dd5..38427ff 100644
--- a/resources/js/Pages/VacationRequest/Index.vue
+++ b/resources/js/Pages/VacationRequest/Index.vue
@@ -76,7 +76,7 @@
diff --git a/resources/js/Pages/VacationRequest/IndexForApprovers.vue b/resources/js/Pages/VacationRequest/IndexForApprovers.vue
index 75acd64..d055c3f 100644
--- a/resources/js/Pages/VacationRequest/IndexForApprovers.vue
+++ b/resources/js/Pages/VacationRequest/IndexForApprovers.vue
@@ -69,7 +69,7 @@
@@ -98,7 +98,7 @@
@@ -149,7 +149,7 @@
diff --git a/resources/js/Shared/Widgets/AbsenceList.vue b/resources/js/Shared/Widgets/AbsenceList.vue
index 266955e..65f1b26 100644
--- a/resources/js/Shared/Widgets/AbsenceList.vue
+++ b/resources/js/Shared/Widgets/AbsenceList.vue
@@ -25,11 +25,6 @@
-
-
- Brak danych
-
-
diff --git a/resources/js/Shared/Widgets/HomeOfficeList.vue b/resources/js/Shared/Widgets/HomeOfficeList.vue
new file mode 100644
index 0000000..689487d
--- /dev/null
+++ b/resources/js/Shared/Widgets/HomeOfficeList.vue
@@ -0,0 +1,37 @@
+
+
+
+
+ Dzisiejsza praca zdalna
+
+
+
+
+ -
+
+
+
+ {{ day.user.name }}
+
+
+ {{ day.user.email }}
+
+
+
+
+
+
+
+
+
diff --git a/tests/Feature/VacationRequestTest.php b/tests/Feature/VacationRequestTest.php
index 2d0514f..f8890a2 100644
--- a/tests/Feature/VacationRequestTest.php
+++ b/tests/Feature/VacationRequestTest.php
@@ -10,6 +10,7 @@ use Illuminate\Support\Facades\Bus;
use Illuminate\Support\Facades\Notification;
use Inertia\Testing\AssertableInertia as Assert;
use Tests\FeatureTestCase;
+use Toby\Domain\Enums\EmploymentForm;
use Toby\Domain\Enums\VacationType;
use Toby\Domain\PolishHolidaysRetriever;
use Toby\Domain\States\VacationRequest\Approved;
@@ -17,6 +18,7 @@ use Toby\Domain\States\VacationRequest\Cancelled;
use Toby\Domain\States\VacationRequest\Rejected;
use Toby\Domain\States\VacationRequest\WaitingForAdministrative;
use Toby\Domain\States\VacationRequest\WaitingForTechnical;
+use Toby\Eloquent\Models\Profile;
use Toby\Eloquent\Models\User;
use Toby\Eloquent\Models\VacationLimit;
use Toby\Eloquent\Models\VacationRequest;
@@ -61,7 +63,9 @@ class VacationRequestTest extends FeatureTestCase
public function testUserCanCreateVacationRequest(): void
{
- $user = User::factory()->create();
+ $user = User::factory()
+ ->has(Profile::factory(["employment_form" => EmploymentForm::EmploymentContract]))
+ ->create();
$currentYearPeriod = YearPeriod::current();
@@ -80,6 +84,7 @@ class VacationRequestTest extends FeatureTestCase
"to" => Carbon::create($currentYearPeriod->year, 2, 11)->toDateString(),
"comment" => "Comment for the vacation request.",
])
+ ->assertSessionHasNoErrors()
->assertRedirect();
$this->assertDatabaseHas("vacation_requests", [
@@ -96,7 +101,9 @@ class VacationRequestTest extends FeatureTestCase
public function testUserCanCreateVacationRequestOnEmployeeBehalf(): void
{
$creator = User::factory()->admin()->create();
- $user = User::factory()->create();
+ $user = User::factory()
+ ->has(Profile::factory(["employment_form" => EmploymentForm::EmploymentContract]))
+ ->create();
$currentYearPeriod = YearPeriod::current();
@@ -132,7 +139,9 @@ class VacationRequestTest extends FeatureTestCase
public function testUserCanCreateVacationRequestOnEmployeeBehalfAndSkipAcceptanceFlow(): void
{
$creator = User::factory()->admin()->create();
- $user = User::factory()->create();
+ $user = User::factory()
+ ->has(Profile::factory(["employment_form" => EmploymentForm::EmploymentContract]))
+ ->create();
$currentYearPeriod = YearPeriod::current();
@@ -245,7 +254,9 @@ class VacationRequestTest extends FeatureTestCase
public function testUserCannotCreateVacationRequestIfHeExceedsHisVacationLimit(): void
{
- $user = User::factory()->create();
+ $user = User::factory()
+ ->has(Profile::factory(["employment_form" => EmploymentForm::EmploymentContract]))
+ ->create();
$currentYearPeriod = YearPeriod::current();
VacationLimit::factory([
@@ -327,7 +338,9 @@ class VacationRequestTest extends FeatureTestCase
public function testUserCannotCreateVacationRequestIfHeHasPendingVacationRequestInThisRange(): void
{
- $user = User::factory()->create();
+ $user = User::factory()
+ ->has(Profile::factory(["employment_form" => EmploymentForm::EmploymentContract]))
+ ->create();
$currentYearPeriod = YearPeriod::current();
VacationLimit::factory([
@@ -363,7 +376,9 @@ class VacationRequestTest extends FeatureTestCase
public function testUserCannotCreateVacationRequestIfHeHasApprovedVacationRequestInThisRange(): void
{
- $user = User::factory()->create();
+ $user = User::factory()
+ ->has(Profile::factory(["employment_form" => EmploymentForm::EmploymentContract]))
+ ->create();
$currentYearPeriod = YearPeriod::current();
VacationLimit::factory([
--
2.52.0
From b72258e16b7171255541b92287d67e039df25276 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 14:15:09 +0200
Subject: [PATCH 12/14] #120 - fix
---
resources/js/Shared/VacationBar.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/resources/js/Shared/VacationBar.vue b/resources/js/Shared/VacationBar.vue
index bce16f0..fe8e603 100644
--- a/resources/js/Shared/VacationBar.vue
+++ b/resources/js/Shared/VacationBar.vue
@@ -27,7 +27,7 @@
-
+
Date: Wed, 20 Apr 2022 14:19:12 +0200
Subject: [PATCH 13/14] #120 - translation fix
---
resources/lang/pl.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/resources/lang/pl.json b/resources/lang/pl.json
index c288aba..955ae7f 100644
--- a/resources/lang/pl.json
+++ b/resources/lang/pl.json
@@ -64,7 +64,7 @@
"Vacation request :title is waiting for your administrative approval": "Wniosek urlopowy :title czeka na akceptację administracyjną",
"The vacation request :title from user :requester is waiting for your technical approval.": "Wniosek urlopowy :title użytkownika :requester czeka na Twoją akceptację techniczną.",
"The vacation request :title from user :requester is waiting for your administrative approval.": "Wniosek urlopowy :title użytkownika :requester czeka na Twoją akceptację administracyjną.",
- "Vacation request :title has been :status": "Wniosek urlopowy :title został :status",
+ "Vacation request :title has been :status": "Wniosek :title został :status",
"The vacation request :title from user :requester has been :status.": "Wniosek urlopowy :title użytkownika :requester został :status.",
"Vacation request :title has been created on your behalf": "Wniosek urlopowy :title został utworzony w Twoim imieniu",
"The vacation request :title has been created correctly by user :creator on your behalf in the :appName.": "W systemie :appName został poprawnie utworzony wniosek urlopowy :title w Twoim imieniu przez użytkownika :creator."
--
2.52.0
From 39a35ba595c7641321254e0d217ac9bac4e6a629 Mon Sep 17 00:00:00 2001
From: Adrian Hopek
Date: Wed, 20 Apr 2022 14:22:10 +0200
Subject: [PATCH 14/14] #120 - fix
---
app/Domain/Actions/VacationRequest/CancelAction.php | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/app/Domain/Actions/VacationRequest/CancelAction.php b/app/Domain/Actions/VacationRequest/CancelAction.php
index 508f5b0..d608844 100644
--- a/app/Domain/Actions/VacationRequest/CancelAction.php
+++ b/app/Domain/Actions/VacationRequest/CancelAction.php
@@ -7,6 +7,7 @@ namespace Toby\Domain\Actions\VacationRequest;
use Toby\Domain\Enums\Role;
use Toby\Domain\Notifications\VacationRequestStatusChangedNotification;
use Toby\Domain\VacationRequestStateManager;
+use Toby\Domain\VacationTypeConfigRetriever;
use Toby\Eloquent\Models\User;
use Toby\Eloquent\Models\VacationRequest;
use Toby\Infrastructure\Jobs\ClearVacationRequestDaysInGoogleCalendar;
@@ -15,6 +16,7 @@ class CancelAction
{
public function __construct(
protected VacationRequestStateManager $stateManager,
+ protected VacationTypeConfigRetriever $configRetriever,
) {}
public function execute(VacationRequest $vacationRequest, User $user): void
@@ -23,7 +25,9 @@ class CancelAction
ClearVacationRequestDaysInGoogleCalendar::dispatch($vacationRequest);
- $this->notify($vacationRequest);
+ if ($this->configRetriever->isVacation($vacationRequest->type)) {
+ $this->notify($vacationRequest);
+ }
}
protected function notify(VacationRequest $vacationRequest): void
--
2.52.0