kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#116 - integration with slack #129

Merged
Baakoma merged 19 commits from #116-integration-with-slack into main 2022-04-27 09:57:13 +02:00
Conversation 7 Commits 19 Files Changed 78 +10 -16
12 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 54faa3460c - Show all commits

2
app/Architecture/Providers/AppServiceProvider.php
View File

@@ -9,7 +9,7 @@ use Illuminate\Notifications\ChannelManager;
use Illuminate\Support\Carbon; use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Notification; use Illuminate\Support\Facades\Notification;
use Illuminate\Support\ServiceProvider; use Illuminate\Support\ServiceProvider;
use Toby\Domain\Slack\SlackApiChannel; use Toby\Domain\Slack\Channels\SlackApiChannel;
class AppServiceProvider extends ServiceProvider class AppServiceProvider extends ServiceProvider
{ {

2
app/Domain/Slack/SlackApiChannel.php → app/Domain/Slack/Channels/SlackApiChannel.php
View File

@@ -2,7 +2,7 @@
krzysztofrewak commented 2022-04-26 10:09:19 +02:00 (Migrated from github.com)
Review
Copy Link

Can you type $notifiable?

Can you type `$notifiable`?
krzysztofrewak commented 2022-04-26 10:09:19 +02:00 (Migrated from github.com)
Review
Copy Link

Can you type $notifiable?

Can you type `$notifiable`?
krzysztofrewak commented 2022-04-26 10:09:51 +02:00 (Migrated from github.com)
Review
Copy Link

Hm, I don't if I wouldn't put his to Infrastucture directory.

Hm, I don't if I wouldn't put his to Infrastucture directory.
krzysztofrewak commented 2022-04-26 10:09:51 +02:00 (Migrated from github.com)
Review
Copy Link

Hm, I don't if I wouldn't put his to Infrastucture directory.

Hm, I don't if I wouldn't put his to Infrastucture directory.
krzysztofrewak commented 2022-04-26 10:11:01 +02:00 (Migrated from github.com)
Review
Copy Link

Could you extract this config to separate method? It would make further testing easier, I think.

Could you extract this config to separate method? It would make further testing easier, I think.
krzysztofrewak commented 2022-04-26 10:11:01 +02:00 (Migrated from github.com)
Review
Copy Link

Could you extract this config to separate method? It would make further testing easier, I think.

Could you extract this config to separate method? It would make further testing easier, I think.
Baakoma commented 2022-04-26 11:00:45 +02:00 (Migrated from github.com)
Review
Copy Link

In general, it can be anything that uses trait Notifiable

In general, it can be anything that uses trait `Notifiable`
Baakoma commented 2022-04-26 11:00:45 +02:00 (Migrated from github.com)
Review
Copy Link

In general, it can be anything that uses trait Notifiable

In general, it can be anything that uses trait `Notifiable`
krzysztofrewak commented 2022-04-26 11:17:21 +02:00 (Migrated from github.com)
Review
Copy Link

Oh no, maybe you could add some interface fot that?

Oh no, maybe you could add some interface fot that?
krzysztofrewak commented 2022-04-26 11:17:21 +02:00 (Migrated from github.com)
Review
Copy Link

Oh no, maybe you could add some interface fot that?

Oh no, maybe you could add some interface fot that?
declare(strict_types=1); declare(strict_types=1);
namespace Toby\Domain\Slack; namespace Toby\Domain\Slack\Channels;
krzysztofrewak commented 2022-04-26 10:09:19 +02:00 (Migrated from github.com)
Review
Copy Link

Can you type $notifiable?

Can you type `$notifiable`?
krzysztofrewak commented 2022-04-26 10:09:51 +02:00 (Migrated from github.com)
Review
Copy Link

Hm, I don't if I wouldn't put his to Infrastucture directory.

Hm, I don't if I wouldn't put his to Infrastucture directory.
krzysztofrewak commented 2022-04-26 10:11:01 +02:00 (Migrated from github.com)
Review
Copy Link

Could you extract this config to separate method? It would make further testing easier, I think.

Could you extract this config to separate method? It would make further testing easier, I think.
Baakoma commented 2022-04-26 11:00:45 +02:00 (Migrated from github.com)
Review
Copy Link

In general, it can be anything that uses trait Notifiable

In general, it can be anything that uses trait `Notifiable`
krzysztofrewak commented 2022-04-26 11:17:21 +02:00 (Migrated from github.com)
Review
Copy Link

Oh no, maybe you could add some interface fot that?

Oh no, maybe you could add some interface fot that?
krzysztofrewak commented 2022-04-26 10:09:19 +02:00 (Migrated from github.com)
Review
Copy Link

Can you type $notifiable?

Can you type `$notifiable`?
krzysztofrewak commented 2022-04-26 10:09:51 +02:00 (Migrated from github.com)
Review
Copy Link

Hm, I don't if I wouldn't put his to Infrastucture directory.

Hm, I don't if I wouldn't put his to Infrastucture directory.
krzysztofrewak commented 2022-04-26 10:11:01 +02:00 (Migrated from github.com)
Review
Copy Link

Could you extract this config to separate method? It would make further testing easier, I think.

Could you extract this config to separate method? It would make further testing easier, I think.
Baakoma commented 2022-04-26 11:00:45 +02:00 (Migrated from github.com)
Review
Copy Link

In general, it can be anything that uses trait Notifiable

In general, it can be anything that uses trait `Notifiable`
krzysztofrewak commented 2022-04-26 11:17:21 +02:00 (Migrated from github.com)
Review
Copy Link

Oh no, maybe you could add some interface fot that?

Oh no, maybe you could add some interface fot that?
use Illuminate\Http\Client\Response; use Illuminate\Http\Client\Response;
use Illuminate\Notifications\Notification; use Illuminate\Notifications\Notification;

2
app/Domain/Slack/UserNotFoundException.php → app/Domain/Slack/Exceptions/UserNotFoundException.php
View File

@@ -2,7 +2,7 @@
declare(strict_types=1); declare(strict_types=1);
namespace Toby\Domain\Slack; namespace Toby\Domain\Slack\Exceptions;
use Spatie\SlashCommand\Exceptions\SlackSlashCommandException; use Spatie\SlashCommand\Exceptions\SlackSlashCommandException;

1
app/Domain/Slack/Handlers/DailySummary.php
View File

@@ -9,7 +9,6 @@ use Spatie\SlashCommand\Attachment;
krzysztofrewak commented 2022-04-26 10:13:22 +02:00 (Migrated from github.com)
Review
Copy Link
        $absences = $dailySummaryRetriever->getAbsences($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $remoteDays = $dailySummaryRetriever->getRemoteDays($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $birthdays = $dailySummaryRetriever->getBirthdays($now)
            ->map(fn(User $user): string => $user->profile->full_name);
```suggestion $absences = $dailySummaryRetriever->getAbsences($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $remoteDays = $dailySummaryRetriever->getRemoteDays($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $birthdays = $dailySummaryRetriever->getBirthdays($now) ->map(fn(User $user): string => $user->profile->full_name); ```
krzysztofrewak commented 2022-04-26 10:13:22 +02:00 (Migrated from github.com)
Review
Copy Link
        $absences = $dailySummaryRetriever->getAbsences($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $remoteDays = $dailySummaryRetriever->getRemoteDays($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $birthdays = $dailySummaryRetriever->getBirthdays($now)
            ->map(fn(User $user): string => $user->profile->full_name);
```suggestion $absences = $dailySummaryRetriever->getAbsences($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $remoteDays = $dailySummaryRetriever->getRemoteDays($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $birthdays = $dailySummaryRetriever->getBirthdays($now) ->map(fn(User $user): string => $user->profile->full_name); ```
krzysztofrewak commented 2022-04-26 10:14:04 +02:00 (Migrated from github.com)
Review
Copy Link

What if we would have five more activities? Maybe this could be encapsulated somehow?

What if we would have five more activities? Maybe this could be encapsulated somehow?
krzysztofrewak commented 2022-04-26 10:14:04 +02:00 (Migrated from github.com)
Review
Copy Link

What if we would have five more activities? Maybe this could be encapsulated somehow?

What if we would have five more activities? Maybe this could be encapsulated somehow?
use Spatie\SlashCommand\Request; use Spatie\SlashCommand\Request;
use Spatie\SlashCommand\Response; use Spatie\SlashCommand\Response;
use Toby\Domain\DailySummaryRetriever; use Toby\Domain\DailySummaryRetriever;
use Toby\Domain\Slack\SignatureHandler;
krzysztofrewak commented 2022-04-26 10:13:22 +02:00 (Migrated from github.com)
Review
Copy Link
        $absences = $dailySummaryRetriever->getAbsences($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $remoteDays = $dailySummaryRetriever->getRemoteDays($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $birthdays = $dailySummaryRetriever->getBirthdays($now)
            ->map(fn(User $user): string => $user->profile->full_name);
```suggestion $absences = $dailySummaryRetriever->getAbsences($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $remoteDays = $dailySummaryRetriever->getRemoteDays($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $birthdays = $dailySummaryRetriever->getBirthdays($now) ->map(fn(User $user): string => $user->profile->full_name); ```
krzysztofrewak commented 2022-04-26 10:14:04 +02:00 (Migrated from github.com)
Review
Copy Link

What if we would have five more activities? Maybe this could be encapsulated somehow?

What if we would have five more activities? Maybe this could be encapsulated somehow?
use Toby\Eloquent\Models\User; use Toby\Eloquent\Models\User;
use Toby\Eloquent\Models\Vacation; use Toby\Eloquent\Models\Vacation;
krzysztofrewak commented 2022-04-26 10:13:22 +02:00 (Migrated from github.com)
Review
Copy Link
        $absences = $dailySummaryRetriever->getAbsences($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $remoteDays = $dailySummaryRetriever->getRemoteDays($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $birthdays = $dailySummaryRetriever->getBirthdays($now)
            ->map(fn(User $user): string => $user->profile->full_name);
```suggestion $absences = $dailySummaryRetriever->getAbsences($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $remoteDays = $dailySummaryRetriever->getRemoteDays($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $birthdays = $dailySummaryRetriever->getBirthdays($now) ->map(fn(User $user): string => $user->profile->full_name); ```
krzysztofrewak commented 2022-04-26 10:13:22 +02:00 (Migrated from github.com)
Review
Copy Link
        $absences = $dailySummaryRetriever->getAbsences($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $remoteDays = $dailySummaryRetriever->getRemoteDays($now)
            ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name);

        $birthdays = $dailySummaryRetriever->getBirthdays($now)
            ->map(fn(User $user): string => $user->profile->full_name);
```suggestion $absences = $dailySummaryRetriever->getAbsences($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $remoteDays = $dailySummaryRetriever->getRemoteDays($now) ->map(fn(Vacation $vacation): string => $vacation->user->profile->full_name); $birthdays = $dailySummaryRetriever->getBirthdays($now) ->map(fn(User $user): string => $user->profile->full_name); ```
krzysztofrewak commented 2022-04-26 10:14:04 +02:00 (Migrated from github.com)
Review
Copy Link

What if we would have five more activities? Maybe this could be encapsulated somehow?

What if we would have five more activities? Maybe this could be encapsulated somehow?
krzysztofrewak commented 2022-04-26 10:14:04 +02:00 (Migrated from github.com)
Review
Copy Link

What if we would have five more activities? Maybe this could be encapsulated somehow?

What if we would have five more activities? Maybe this could be encapsulated somehow?

5
app/Domain/Slack/Handlers/GiveKeysTo.php
View File

@@ -8,10 +8,9 @@ use Illuminate\Validation\ValidationException;
use Spatie\SlashCommand\Request; use Spatie\SlashCommand\Request;
use Spatie\SlashCommand\Response; use Spatie\SlashCommand\Response;
use Toby\Domain\Notifications\KeyHasBeenGivenNotification; use Toby\Domain\Notifications\KeyHasBeenGivenNotification;
use Toby\Domain\Slack\SignatureHandler; use Toby\Domain\Slack\Exceptions\UserNotFoundException;
use Toby\Domain\Slack\SlackUserExistsRule; use Toby\Domain\Slack\Rules\SlackUserExistsRule;
use Toby\Domain\Slack\Traits\FindsUserBySlackId; use Toby\Domain\Slack\Traits\FindsUserBySlackId;
use Toby\Domain\Slack\UserNotFoundException;
use Toby\Eloquent\Models\Key; use Toby\Eloquent\Models\Key;
class GiveKeysTo extends SignatureHandler class GiveKeysTo extends SignatureHandler

1
app/Domain/Slack/Handlers/Help.php
View File

@@ -7,7 +7,6 @@ namespace Toby\Domain\Slack\Handlers;
use Spatie\SlashCommand\Attachment; use Spatie\SlashCommand\Attachment;
use Spatie\SlashCommand\Request; use Spatie\SlashCommand\Request;
use Spatie\SlashCommand\Response; use Spatie\SlashCommand\Response;
use Toby\Domain\Slack\SignatureHandler;
use Toby\Domain\Slack\Traits\ListsHandlers; use Toby\Domain\Slack\Traits\ListsHandlers;
class Help extends SignatureHandler class Help extends SignatureHandler

1
app/Domain/Slack/Handlers/HomeOffice.php
View File

@@ -9,7 +9,6 @@ use Spatie\SlashCommand\Request;
use Spatie\SlashCommand\Response; use Spatie\SlashCommand\Response;
use Toby\Domain\Actions\VacationRequest\CreateAction; use Toby\Domain\Actions\VacationRequest\CreateAction;
use Toby\Domain\Enums\VacationType; use Toby\Domain\Enums\VacationType;
use Toby\Domain\Slack\SignatureHandler;
use Toby\Domain\Slack\Traits\FindsUserBySlackId; use Toby\Domain\Slack\Traits\FindsUserBySlackId;
use Toby\Eloquent\Models\User; use Toby\Eloquent\Models\User;
use Toby\Eloquent\Models\YearPeriod; use Toby\Eloquent\Models\YearPeriod;

1
app/Domain/Slack/Handlers/KeyList.php
View File

@@ -7,7 +7,6 @@ namespace Toby\Domain\Slack\Handlers;
use Spatie\SlashCommand\Attachment; use Spatie\SlashCommand\Attachment;
use Spatie\SlashCommand\Request; use Spatie\SlashCommand\Request;
use Spatie\SlashCommand\Response; use Spatie\SlashCommand\Response;
use Toby\Domain\Slack\SignatureHandler;
use Toby\Eloquent\Models\Key; use Toby\Eloquent\Models\Key;
class KeyList extends SignatureHandler class KeyList extends SignatureHandler

2
app/Domain/Slack/SignatureHandler.php → app/Domain/Slack/Handlers/SignatureHandler.php
View File

@@ -2,7 +2,7 @@
declare(strict_types=1); declare(strict_types=1);
namespace Toby\Domain\Slack; namespace Toby\Domain\Slack\Handlers;
use Illuminate\Support\Facades\Validator; use Illuminate\Support\Facades\Validator;
use Spatie\SlashCommand\Handlers\SignatureHandler as BaseSignatureHandler; use Spatie\SlashCommand\Handlers\SignatureHandler as BaseSignatureHandler;

5
app/Domain/Slack/Handlers/TakeKeysFrom.php
View File

@@ -8,10 +8,9 @@ use Illuminate\Validation\ValidationException;
use Spatie\SlashCommand\Request; use Spatie\SlashCommand\Request;
use Spatie\SlashCommand\Response; use Spatie\SlashCommand\Response;
use Toby\Domain\Notifications\KeyHasBeenTakenNotification; use Toby\Domain\Notifications\KeyHasBeenTakenNotification;
use Toby\Domain\Slack\SignatureHandler; use Toby\Domain\Slack\Exceptions\UserNotFoundException;
use Toby\Domain\Slack\SlackUserExistsRule; use Toby\Domain\Slack\Rules\SlackUserExistsRule;
use Toby\Domain\Slack\Traits\FindsUserBySlackId; use Toby\Domain\Slack\Traits\FindsUserBySlackId;
use Toby\Domain\Slack\UserNotFoundException;
use Toby\Eloquent\Models\Key; use Toby\Eloquent\Models\Key;
class TakeKeysFrom extends SignatureHandler class TakeKeysFrom extends SignatureHandler

2
app/Domain/Slack/SlackUserExistsRule.php → app/Domain/Slack/Rules/SlackUserExistsRule.php
View File

@@ -2,7 +2,7 @@
declare(strict_types=1); declare(strict_types=1);
namespace Toby\Domain\Slack; namespace Toby\Domain\Slack\Rules;
use Illuminate\Contracts\Validation\Rule; use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Str; use Illuminate\Support\Str;

2
app/Domain/Slack/Traits/FindsUserBySlackId.php
View File

@@ -5,7 +5,7 @@ declare(strict_types=1);
krzysztofrewak commented 2022-04-26 10:16:44 +02:00 (Migrated from github.com)
Review
Copy Link

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387
krzysztofrewak commented 2022-04-26 10:16:44 +02:00 (Migrated from github.com)
Review
Copy Link

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387
Baakoma commented 2022-04-26 10:58:05 +02:00 (Migrated from github.com)
Review
Copy Link

Yes.
Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned

Yes. `Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned `
Baakoma commented 2022-04-26 10:58:05 +02:00 (Migrated from github.com)
Review
Copy Link

Yes.
Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned

Yes. `Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned `
namespace Toby\Domain\Slack\Traits; namespace Toby\Domain\Slack\Traits;
use Illuminate\Support\Str; use Illuminate\Support\Str;
use Toby\Domain\Slack\UserNotFoundException; use Toby\Domain\Slack\Exceptions\UserNotFoundException;
krzysztofrewak commented 2022-04-26 10:16:44 +02:00 (Migrated from github.com)
Review
Copy Link

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387
Baakoma commented 2022-04-26 10:58:05 +02:00 (Migrated from github.com)
Review
Copy Link

Yes.
Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned

Yes. `Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned `
krzysztofrewak commented 2022-04-26 10:16:44 +02:00 (Migrated from github.com)
Review
Copy Link

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387
Baakoma commented 2022-04-26 10:58:05 +02:00 (Migrated from github.com)
Review
Copy Link

Yes.
Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned

Yes. `Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned `
use Toby\Eloquent\Models\User; use Toby\Eloquent\Models\User;
trait FindsUserBySlackId trait FindsUserBySlackId
krzysztofrewak commented 2022-04-26 10:16:44 +02:00 (Migrated from github.com)
Review
Copy Link

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387
krzysztofrewak commented 2022-04-26 10:16:44 +02:00 (Migrated from github.com)
Review
Copy Link

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387

Is it required here? https://github.com/laravel/framework/blob/9.x/src/Illuminate/Collections/Collection.php#L387
Baakoma commented 2022-04-26 10:58:05 +02:00 (Migrated from github.com)
Review
Copy Link

Yes.
Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned

Yes. `Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned `
Baakoma commented 2022-04-26 10:58:05 +02:00 (Migrated from github.com)
Review
Copy Link

Yes.
Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned

Yes. `Return value is expected to be 'null|\Toby\Eloquent\Models\User', '\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|object' returned `