kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#116 - integration with slack #129

Merged
Baakoma merged 19 commits from #116-integration-with-slack into main 2022-04-27 09:57:13 +02:00
Conversation 7 Commits 19 Files Changed 78 +3 -3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 83e003ddbb - Show all commits

2
app/Infrastructure/Slack/Controller.php
View File

@@ -50,7 +50,7 @@ class Controller extends SlackController
EwelinaLasowy commented 2022-04-26 14:21:14 +02:00 (Migrated from github.com)
Review
Copy Link
            ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
```suggestion ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:") ```
EwelinaLasowy commented 2022-04-26 14:21:14 +02:00 (Migrated from github.com)
Review
Copy Link
            ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
```suggestion ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:") ```
); );
return Response::create($this->request) return Response::create($this->request)
->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawna:") ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
EwelinaLasowy commented 2022-04-26 14:21:14 +02:00 (Migrated from github.com)
Review
Copy Link
            ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
```suggestion ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:") ```
EwelinaLasowy commented 2022-04-26 14:21:14 +02:00 (Migrated from github.com)
Review
Copy Link
            ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
```suggestion ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:") ```
->withAttachments($errors->all()); ->withAttachments($errors->all());
} }
} }
EwelinaLasowy commented 2022-04-26 14:21:14 +02:00 (Migrated from github.com)
Review
Copy Link
            ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
```suggestion ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:") ```
EwelinaLasowy commented 2022-04-26 14:21:14 +02:00 (Migrated from github.com)
Review
Copy Link
            ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:")
```suggestion ->withText(":x: Polecenie `/{$this->request->command} {$this->request->text}` jest niepoprawne:") ```

4
tests/Unit/SendDailySummaryToSlackTest.php
View File

@@ -38,7 +38,7 @@ class SendDailySummaryToSlackTest extends TestCase
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
Http::assertSentCount(1); Http::assertSentCount(1);
} }
public function testCommandDoesntSendIfWeekend(): void public function testCommandDoesntSendMessageIfWeekend(): void
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
{ {
$weekend = Carbon::create(2022, 4, 23); $weekend = Carbon::create(2022, 4, 23);
$this->assertTrue($weekend->isWeekend()); $this->assertTrue($weekend->isWeekend());
@@ -51,7 +51,7 @@ class SendDailySummaryToSlackTest extends TestCase
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
Http::assertNothingSent(); Http::assertNothingSent();
} }
public function testCommandDoesntSendIfHoliday(): void public function testCommandDoesntSendMessageIfHoliday(): void
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
{ {
$holiday = Holiday::factory(["date" => Carbon::create(2022, 4, 22)])->create(); $holiday = Holiday::factory(["date" => Carbon::create(2022, 4, 22)])->create();
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:22:36 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfWeekend(): void
```suggestion public function testCommandDoesntSendMessageIfWeekend(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```
EwelinaLasowy commented 2022-04-26 14:23:25 +02:00 (Migrated from github.com)
Review
Copy Link
    public function testCommandDoesntSendMessageIfHoliday(): void
```suggestion public function testCommandDoesntSendMessageIfHoliday(): void ```