#43 - vacation summary for employee #66

Merged
Baakoma merged 19 commits from #43-vacation-summary-for-employee into main 2022-03-03 09:03:17 +01:00
Showing only changes of commit afe5834af6 - Show all commits

View File

@@ -26,10 +26,11 @@ class CalculateUserVacationStatsController extends Controller
kamilpiech97 commented 2022-03-01 14:55:59 +01:00 (Migrated from github.com)
Review

Maybe move that calculations above.

Maybe move that calculations above.
kamilpiech97 commented 2022-03-01 14:55:59 +01:00 (Migrated from github.com)
Review

Maybe move that calculations above.

Maybe move that calculations above.
$used = $vacationStatsRetriever->getUsedVacationDays($user, $yearPeriod);
$pending = $vacationStatsRetriever->getPendingVacationDays($user, $yearPeriod);
$other = $vacationStatsRetriever->getOtherApprovedVacationDays($user, $yearPeriod);
$remaining = $limit - $used - $pending;
kamilpiech97 commented 2022-03-01 14:55:59 +01:00 (Migrated from github.com)
Review

Maybe move that calculations above.

Maybe move that calculations above.
return new JsonResponse([
"limit" => $limit,
"remaining" => $limit - $used - $pending,
kamilpiech97 commented 2022-03-01 14:55:59 +01:00 (Migrated from github.com)
Review

Maybe move that calculations above.

Maybe move that calculations above.
"remaining" => $remaining,
kamilpiech97 commented 2022-03-01 14:55:59 +01:00 (Migrated from github.com)
Review

Maybe move that calculations above.

Maybe move that calculations above.
"used" => $used,
"pending" => $pending,
"other" => $other,
kamilpiech97 commented 2022-03-01 14:55:59 +01:00 (Migrated from github.com)
Review

Maybe move that calculations above.

Maybe move that calculations above.
kamilpiech97 commented 2022-03-01 14:55:59 +01:00 (Migrated from github.com)
Review

Maybe move that calculations above.

Maybe move that calculations above.