kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#84 - fix remembering user #89

Merged
Baakoma merged 10 commits from #84-fix-remembering-user into main 2022-03-21 14:36:18 +01:00
Conversation 5 Commits 10 Files Changed 2 +1 -2
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2ba066e91b - Show all commits

3
app/Infrastructure/Http/Controllers/GoogleController.php
View File

@@ -5,7 +5,6 @@ declare(strict_types=1);
namespace Toby\Infrastructure\Http\Controllers;
use Illuminate\Contracts\Auth\Factory as AuthFactory;
use Illuminate\Contracts\Hashing\Hasher;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Laravel\Socialite\SocialiteManager;
use Symfony\Component\HttpFoundation\RedirectResponse;
@@ -18,7 +17,7 @@ class GoogleController extends Controller
return $socialiteManager->driver("google")->redirect();
krzysztofrewak commented 2022-03-21 14:27:22 +01:00 (Migrated from github.com)
Review
Copy Link

You've added hasher here, but it's not used.

You've added hasher here, but it's not used.
krzysztofrewak commented 2022-03-21 14:27:56 +01:00 (Migrated from github.com)
Review
Copy Link
    public function callback(AuthFactory $auth, SocialiteManager $socialiteManager): RedirectResponse
```suggestion public function callback(AuthFactory $auth, SocialiteManager $socialiteManager): RedirectResponse ```
}
public function callback(AuthFactory $auth, SocialiteManager $socialiteManager, Hasher $hash): RedirectResponse
public function callback(AuthFactory $auth, SocialiteManager $socialiteManager): RedirectResponse
{
$socialUser = $socialiteManager->driver("google")->user();