#22 - vacation calendar (#51)

* change layout

* change layout

* #22 - wip

* wip

* wip

* #22 - wip

* #22 - wip

* #22 - wip

* #22 - wip

* #22 - fix

* #22 - wip

* #22 - added some tests

* #22 - wip

* #22 - wip

* #22 - fix

* #22 - wip

* #22 - wip

* #22 - wip

* #22 - fix

* #22 - fix

* #22 - fix

* #22 - fix

* #22 - fix

* #22 - fix

* #22 - cr fixes

* #22 - cr fix

Co-authored-by: EwelinaLasowy <ewelina.lasowy@blumilk.pl>

tests/Feature/UserTest.php

@@ -88,10 +88,10 @@ class UserTest extends FeatureTestCase
             ->post("/users", [
                 "firstName" => "John",
                 "lastName" => "Doe",
-                "role" => Role::EMPLOYEE->value,
+                "role" => Role::Employee->value,
                 "position" => "Test position",
                 "email" => "john.doe@example.com",
-                "employmentForm" => EmploymentForm::B2B_CONTRACT->value,
+                "employmentForm" => EmploymentForm::B2bContract->value,
                 "employmentDate" => Carbon::now()->toDateString(),
             ])
             ->assertSessionHasNoErrors();
@@ -100,9 +100,9 @@ class UserTest extends FeatureTestCase
             "first_name" => "John",
             "last_name" => "Doe",
             "email" => "john.doe@example.com",
-            "role" => Role::EMPLOYEE->value,
+            "role" => Role::Employee->value,
             "position" => "Test position",
-            "employment_form" => EmploymentForm::B2B_CONTRACT->value,
+            "employment_form" => EmploymentForm::B2bContract->value,
             "employment_date" => Carbon::now()->toDateString(),
         ]);
     }
@@ -127,9 +127,9 @@ class UserTest extends FeatureTestCase
                 "firstName" => "John",
                 "lastName" => "Doe",
                 "email" => "john.doe@example.com",
-                "role" => Role::EMPLOYEE->value,
+                "role" => Role::Employee->value,
                 "position" => "Test position",
-                "employmentForm" => EmploymentForm::B2B_CONTRACT->value,
+                "employmentForm" => EmploymentForm::B2bContract->value,
                 "employmentDate" => Carbon::now()->toDateString(),
             ])
             ->assertSessionHasNoErrors();
@@ -138,9 +138,9 @@ class UserTest extends FeatureTestCase
             "first_name" => "John",
             "last_name" => "Doe",
             "email" => "john.doe@example.com",
-            "role" => Role::EMPLOYEE->value,
+            "role" => Role::Employee->value,
             "position" => "Test position",
-            "employment_form" => EmploymentForm::B2B_CONTRACT->value,
+            "employment_form" => EmploymentForm::B2bContract->value,
             "employment_date" => Carbon::now()->toDateString(),
         ]);
     }

tests/Feature/VacationRequestTest.php

@@ -0,0 +1,345 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature;
+
+use Illuminate\Foundation\Testing\DatabaseMigrations;
+use Illuminate\Support\Carbon;
+use Inertia\Testing\AssertableInertia as Assert;
+use Tests\FeatureTestCase;
+use Toby\Domain\Enums\VacationRequestState;
+use Toby\Domain\Enums\VacationType;
+use Toby\Domain\PolishHolidaysRetriever;
+use Toby\Eloquent\Models\User;
+use Toby\Eloquent\Models\VacationLimit;
+use Toby\Eloquent\Models\VacationRequest;
+use Toby\Eloquent\Models\YearPeriod;
+
+class VacationRequestTest extends FeatureTestCase
+{
+    use DatabaseMigrations;
+
+    protected PolishHolidaysRetriever $polishHolidaysRetriever;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->polishHolidaysRetriever = $this->app->make(PolishHolidaysRetriever::class);
+    }
+
+    public function testUserCanSeeVacationRequestsList(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        VacationRequest::factory()
+            ->count(10)
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($user)
+            ->get("/vacation-requests")
+            ->assertOk()
+            ->assertInertia(
+                fn(Assert $page) => $page
+                    ->component("VacationRequest/Index")
+                    ->has("requests.data", 10),
+            );
+    }
+
+    public function testUserCanCreateVacationRequest(): void
+    {
+        $user = User::factory()->createQuietly();
+
+        $currentYearPeriod = YearPeriod::current();
+
+        VacationLimit::factory([
+            "days" => 20,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 2, 7)->toDateString(),
+                "to" => Carbon::create($currentYearPeriod->year, 2, 11)->toDateString(),
+                "comment" => "Comment for the vacation request.",
+            ])
+            ->assertSessionHasNoErrors();
+
+        $this->assertDatabaseHas("vacation_requests", [
+            "user_id" => $user->id,
+            "year_period_id" => $currentYearPeriod->id,
+            "name" => "1/" . $currentYearPeriod->year,
+            "type" => VacationType::Vacation->value,
+            "state" => VacationRequestState::WaitingForTechnical,
+            "from" => Carbon::create($currentYearPeriod->year, 2, 7)->toDateString(),
+            "to" => Carbon::create($currentYearPeriod->year, 2, 11)->toDateString(),
+            "comment" => "Comment for the vacation request.",
+        ]);
+    }
+
+    public function testTechnicalApproverCanApproveVacationRequest(): void
+    {
+        $user = User::factory()->createQuietly();
+        $technicalApprover = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        $vacationRequest = VacationRequest::factory([
+            "state" => VacationRequestState::WaitingForTechnical,
+            "type" => VacationType::Vacation,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($technicalApprover)
+            ->post("/vacation-requests/{$vacationRequest->id}/accept-as-technical")
+            ->assertSessionHasNoErrors();
+
+        $this->assertDatabaseHas("vacation_requests", [
+            "state" => VacationRequestState::WaitingForAdministrative,
+        ]);
+    }
+
+    public function testAdministrativeApproverCanApproveVacationRequest(): void
+    {
+        $user = User::factory()->createQuietly();
+        $administrativeApprover = User::factory()->createQuietly();
+
+        $currentYearPeriod = YearPeriod::current();
+
+        $vacationRequest = VacationRequest::factory([
+            "state" => VacationRequestState::WaitingForAdministrative,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($administrativeApprover)
+            ->post("/vacation-requests/{$vacationRequest->id}/accept-as-administrative")
+            ->assertSessionHasNoErrors();
+
+        $this->assertDatabaseHas("vacation_requests", [
+            "state" => VacationRequestState::Approved,
+        ]);
+    }
+
+    public function testTechnicalApproverCanRejectVacationRequest(): void
+    {
+        $user = User::factory()->createQuietly();
+        $technicalApprover = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        $vacationLimit = VacationLimit::factory([
+            "days" => 20,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $vacationRequest = VacationRequest::factory([
+            "state" => VacationRequestState::WaitingForTechnical,
+            "type" => VacationType::Vacation,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($technicalApprover)
+            ->post("/vacation-requests/{$vacationRequest->id}/reject")
+            ->assertSessionHasNoErrors();
+
+        $this->assertDatabaseHas("vacation_requests", [
+            "state" => VacationRequestState::Rejected,
+        ]);
+    }
+
+    public function testUserCannotCreateVacationRequestIfHeExceedsHisVacationLimit(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        VacationLimit::factory([
+            "days" => 3,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 2, 7)->toDateString(),
+                "to" => Carbon::create($currentYearPeriod->year, 2, 11)->toDateString(),
+                "comment" => "Comment for the vacation request.",
+            ])
+            ->assertSessionHasErrors([
+                "vacationRequest" => __("Vacation limit has been exceeded."),
+            ]);
+    }
+
+    public function testUserCannotCreateVacationRequestAtWeekend(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        VacationLimit::factory([
+            "days" => 20,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 2, 5)->toDateString(),
+                "to" => Carbon::create($currentYearPeriod->year, 2, 6)->toDateString(),
+                "comment" => "Vacation at weekend.",
+            ])
+            ->assertSessionHasErrors([
+                "vacationRequest" => __("Vacation needs minimum one day."),
+            ]);
+    }
+
+    public function testUserCannotCreateVacationRequestAtHoliday(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        VacationLimit::factory([
+            "days" => 20,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        foreach ($this->polishHolidaysRetriever->getForYearPeriod($currentYearPeriod) as $holiday) {
+            $currentYearPeriod->holidays()->create([
+                "name" => $holiday["name"],
+                "date" => $holiday["date"],
+            ]);
+        }
+
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 4, 18)->toDateString(),
+                "to" => Carbon::create($currentYearPeriod->year, 4, 18)->toDateString(),
+                "comment" => "Vacation at holiday.",
+            ])
+            ->assertSessionHasErrors([
+                "vacationRequest" => __("Vacation needs minimum one day."),
+            ]);
+    }
+
+    public function testUserCannotCreateVacationRequestIfHeHasPendingVacationRequestInThisRange(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        VacationLimit::factory([
+            "days" => 20,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        VacationRequest::factory([
+            "type" => VacationType::Vacation->value,
+            "state" => VacationRequestState::WaitingForTechnical,
+            "from" => Carbon::create($currentYearPeriod->year, 2, 1)->toDateString(),
+            "to" => Carbon::create($currentYearPeriod->year, 2, 4)->toDateString(),
+            "comment" => "Comment for the vacation request.",
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 2, 1)->toDateString(),
+                "to" => Carbon::create($currentYearPeriod->year, 2, 4)->toDateString(),
+                "comment" => "Another comment for the another vacation request.",
+            ])
+            ->assertSessionHasErrors([
+                "vacationRequest" => __("You have pending vacation request in this range."),
+            ])
+        ;
+    }
+
+    public function testUserCannotCreateVacationRequestIfHeHasApprovedVacationRequestInThisRange(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+
+        $vacationLimit = VacationLimit::factory([
+            "days" => 20,
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        VacationRequest::factory([
+            "type" => VacationType::Vacation->value,
+            "state" => VacationRequestState::Approved,
+            "from" => Carbon::create($currentYearPeriod->year, 2, 2)->toDateString(),
+            "to" => Carbon::create($currentYearPeriod->year, 2, 4)->toDateString(),
+            "comment" => "Comment for the vacation request.",
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 2, 1)->toDateString(),
+                "to" => Carbon::create($currentYearPeriod->year, 2, 4)->toDateString(),
+                "comment" => "Another comment for the another vacation request.",
+            ])
+            ->assertSessionHasErrors([
+                "vacationRequest" => __("You have approved vacation request in this range."),
+            ]);
+    }
+
+    public function testUserCannotCreateVacationRequestWithEndDatePriorToTheStartDate(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 2, 7)->toDateString(),
+                "to" => Carbon::create($currentYearPeriod->year, 2, 6)->toDateString(),
+                "comment" => "Comment for the vacation request.",
+            ])
+            ->assertSessionHasErrors([
+                "vacationRequest" => __("Vacation needs minimum one day."),
+            ]);
+    }
+
+    public function testUserCannotCreateVacationRequestAtTheTurnOfTheYear(): void
+    {
+        $user = User::factory()->createQuietly();
+        $currentYearPeriod = YearPeriod::current();
+        $nextYearPeriod = $this->createYearPeriod(Carbon::now()->year + 1);
+        $this->actingAs($user)
+            ->post("/vacation-requests", [
+                "type" => VacationType::Vacation->value,
+                "from" => Carbon::create($currentYearPeriod->year, 12, 27)->toDateString(),
+                "to" => Carbon::create($nextYearPeriod->year, 1, 2)->toDateString(),
+                "comment" => "Comment for the vacation request.",
+            ])
+            ->assertSessionHasErrors([
+                "vacationRequest" => __("The vacation request cannot be created at the turn of the year."),
+            ]);
+    }
+}

tests/FeatureTestCase.php

@@ -17,7 +17,7 @@ abstract class FeatureTestCase extends BaseTestCase
     {
         parent::setUp();
 
-        Carbon::setTestNow(Carbon::now());
+        Carbon::setTestNow(Carbon::createFromDate(2022, 1, 1));
         $this->createCurrentYearPeriod();
     }
 }

tests/Unit/VacationRequestStatesTest.php

@@ -0,0 +1,100 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit;
+
+use Illuminate\Foundation\Testing\DatabaseMigrations;
+use Illuminate\Support\Carbon;
+use Tests\TestCase;
+use Tests\Traits\InteractsWithYearPeriods;
+use Toby\Domain\Enums\VacationRequestState;
+use Toby\Domain\Enums\VacationType;
+use Toby\Domain\VacationRequestStateManager;
+use Toby\Eloquent\Models\User;
+use Toby\Eloquent\Models\VacationRequest;
+use Toby\Eloquent\Models\YearPeriod;
+
+class VacationRequestStatesTest extends TestCase
+{
+    use DatabaseMigrations;
+    use InteractsWithYearPeriods;
+
+    protected VacationRequestStateManager $stateManager;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->stateManager = $this->app->make(VacationRequestStateManager::class);
+
+        $this->createCurrentYearPeriod();
+    }
+
+    public function testAfterCreatingVacationRequestOfTypeVacationItTransitsToProperState(): void
+    {
+        $user = User::factory()->createQuietly();
+
+        $currentYearPeriod = YearPeriod::current();
+
+        /** @var VacationRequest $vacationRequest */
+        $vacationRequest = VacationRequest::factory([
+            "type" => VacationType::Vacation->value,
+            "state" => VacationRequestState::Created,
+            "from" => Carbon::create($currentYearPeriod->year, 2, 1)->toDateString(),
+            "to" => Carbon::create($currentYearPeriod->year, 2, 4)->toDateString(),
+            "comment" => "Comment for the vacation request.",
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->stateManager->waitForTechnical($vacationRequest);
+
+        $this->assertEquals(VacationRequestState::WaitingForTechnical, $vacationRequest->state);
+    }
+
+    public function testAfterCreatingVacationRequestOfTypeSickVacationItTransitsToProperState(): void
+    {
+        $user = User::factory()->createQuietly();
+
+        $currentYearPeriod = YearPeriod::current();
+
+        /** @var VacationRequest $vacationRequest */
+        $vacationRequest = VacationRequest::factory([
+            "type" => VacationType::Sick->value,
+            "state" => VacationRequestState::Created,
+            "from" => Carbon::create($currentYearPeriod->year, 2, 1)->toDateString(),
+            "to" => Carbon::create($currentYearPeriod->year, 2, 4)->toDateString(),
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->stateManager->approve($vacationRequest);
+
+        $this->assertEquals(VacationRequestState::Approved, $vacationRequest->state);
+    }
+
+    public function testAfterCreatingVacationRequestOfTypeTimeInLieuItTransitsToProperState(): void
+    {
+        $user = User::factory()->createQuietly();
+
+        $currentYearPeriod = YearPeriod::current();
+
+        /** @var VacationRequest $vacationRequest */
+        $vacationRequest = VacationRequest::factory([
+            "type" => VacationType::TimeInLieu->value,
+            "state" => VacationRequestState::Created,
+            "from" => Carbon::create($currentYearPeriod->year, 2, 2)->toDateString(),
+            "to" => Carbon::create($currentYearPeriod->year, 2, 2)->toDateString(),
+        ])
+            ->for($user)
+            ->for($currentYearPeriod)
+            ->create();
+
+        $this->stateManager->approve($vacationRequest);
+
+        $this->assertEquals(VacationRequestState::Approved, $vacationRequest->state);
+    }
+}