#22 - vacation calendar #51

Merged
Baakoma merged 31 commits from #22-vacation-calendar into main 2022-02-15 15:08:26 +01:00
Baakoma commented 2022-02-14 14:58:10 +01:00 (Migrated from github.com)

It should close #22

image

It should close #22 ![image](https://user-images.githubusercontent.com/16743001/153877648-652533c1-a041-4ff5-b23d-d3ea894f2c24.png)
krzysztofrewak (Migrated from github.com) requested changes 2022-02-15 12:45:18 +01:00
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:40:44 +01:00

In PHP docs all enums are written in PascalCase: https://www.php.net/manual/en/language.types.enumerations.php

            ->whereRelation("vacationRequest", "state", VacationRequestState::Approved->value)
In PHP docs all enums are written in PascalCase: https://www.php.net/manual/en/language.types.enumerations.php ```suggestion ->whereRelation("vacationRequest", "state", VacationRequestState::Approved->value) ```
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:41:08 +01:00

But of course we could discuss it. Maybe on slack in #php channel?

But of course we could discuss it. Maybe on slack in #php channel?
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:43:03 +01:00
    text: 'Czeka na akceptację od przełożonego technicznego',
```suggestion text: 'Czeka na akceptację od przełożonego technicznego', ```
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:44:36 +01:00

Maybe you could move to another file?

Maybe you could move to another file?
krzysztofrewak (Migrated from github.com) reviewed 2022-02-15 14:23:06 +01:00
krzysztofrewak (Migrated from github.com) commented 2022-02-15 14:23:06 +01:00

@Baakoma, lines 73 and 86 are still with old form.

@Baakoma, lines 73 and 86 are still with old form.
krzysztofrewak (Migrated from github.com) approved these changes 2022-02-15 15:07:26 +01:00
Sign in to join this conversation.