kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#22 - vacation calendar #51

Merged
Baakoma merged 31 commits from #22-vacation-calendar into main 2022-02-15 15:08:26 +01:00
Conversation 3 Commits 31 Files Changed 50 +1682 -397
Baakoma commented 2022-02-14 14:58:10 +01:00 (Migrated from github.com)
Copy Link

It should close #22

image

It should close #22 ![image](https://user-images.githubusercontent.com/16743001/153877648-652533c1-a041-4ff5-b23d-d3ea894f2c24.png)
krzysztofrewak (Migrated from github.com) requested changes 2022-02-15 12:45:18 +01:00
app/Domain/CalendarGenerator.php
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:40:44 +01:00
Copy Link

In PHP docs all enums are written in PascalCase: https://www.php.net/manual/en/language.types.enumerations.php

            ->whereRelation("vacationRequest", "state", VacationRequestState::Approved->value)
In PHP docs all enums are written in PascalCase: https://www.php.net/manual/en/language.types.enumerations.php ```suggestion ->whereRelation("vacationRequest", "state", VacationRequestState::Approved->value) ```
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:41:08 +01:00
Copy Link

But of course we could discuss it. Maybe on slack in #php channel?

But of course we could discuss it. Maybe on slack in #php channel?
resources/js/Composables/statusInfo.js
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:43:03 +01:00
Copy Link
    text: 'Czeka na akceptację od przełożonego technicznego',
```suggestion text: 'Czeka na akceptację od przełożonego technicznego', ```
resources/js/Pages/Calendar.vue
krzysztofrewak (Migrated from github.com) commented 2022-02-15 12:44:36 +01:00
Copy Link

Maybe you could move to another file?

Maybe you could move to another file?
krzysztofrewak (Migrated from github.com) reviewed 2022-02-15 14:23:06 +01:00
resources/js/Composables/statusInfo.js
krzysztofrewak (Migrated from github.com) commented 2022-02-15 14:23:06 +01:00
Copy Link

@Baakoma, lines 73 and 86 are still with old form.

@Baakoma, lines 73 and 86 are still with old form.
krzysztofrewak (Migrated from github.com) approved these changes 2022-02-15 15:07:26 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
krzysztofrewak
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#51
Delete Branch "#22-vacation-calendar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?