kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#71 - annual summary #113

Merged
Baakoma merged 16 commits from #71-annual-summary into main 2022-04-07 14:33:15 +02:00
Conversation 4 Commits 16 Files Changed 20 +1073 -1206
Baakoma commented 2022-04-07 12:59:55 +02:00 (Migrated from github.com)
Copy Link

Me and @EwelinaLasowy created a brand new summary page for employees. On this page, employees can see their vacations (approved and pending) and holidays with additional information by hovering over them.
image

It should close #71 and should close #82

Me and @EwelinaLasowy created a brand new summary page for employees. On this page, employees can see their vacations (approved and pending) and holidays with additional information by hovering over them. ![image](https://user-images.githubusercontent.com/16743001/162184781-5585aa8b-bea4-4bbc-8392-bfa24dd7fc30.png) It should close #71 and should close #82
mtracz (Migrated from github.com) requested changes 2022-04-07 13:39:37 +02:00
app/Domain/Validation/Rules/DoesNotExceedLimitRule.php
mtracz (Migrated from github.com) commented 2022-04-07 13:32:38 +02:00
Copy Link

I think ? (null safe operator) is missing
?->days ?? 0
Cause first() method may return null, then you will receive something like "call property on null"

I think `?` (null safe operator) is missing ```?->days ?? 0``` Cause `first()` method may return null, then you will receive something like "call property on null"
app/Eloquent/Models/Vacation.php
@@ -47,7 +47,15 @@ class Vacation extends Model
{
return $query->whereRelation(
"vacationRequest",
mtracz (Migrated from github.com) commented 2022-04-07 13:33:18 +02:00
Copy Link

Could you add return type of arrow function?

Could you add return type of arrow function?
app/Infrastructure/Http/Controllers/AnnualSummaryController.php
mtracz (Migrated from github.com) commented 2022-04-07 13:35:08 +02:00
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?
mtracz commented 2022-04-07 13:41:35 +02:00 (Migrated from github.com)
Copy Link

What will happen with /holidays route / page?

What will happen with `/holidays` route / page?
Baakoma commented 2022-04-07 13:59:04 +02:00 (Migrated from github.com)
Copy Link

What will happen with /holidays route / page?

I think /holidays will be still available

> What will happen with `/holidays` route / page? I think `/holidays` will be still available
mtracz (Migrated from github.com) approved these changes 2022-04-07 14:18:37 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mtracz
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#113
Delete Branch "#71-annual-summary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?