kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#71 - annual summary #113

Merged
Baakoma merged 16 commits from #71-annual-summary into main 2022-04-07 14:33:15 +02:00
Conversation 4 Commits 16 Files Changed 20 +3 -2
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0d8dccea22 - Show all commits

3
app/Infrastructure/Http/Controllers/AnnualSummaryController.php
View File

@@ -14,7 +14,8 @@ use Toby\Infrastructure\Http\Resources\SimpleVacationRequestResource;
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?
class AnnualSummaryController extends Controller
{
public function __invoke(Request $request, YearPeriodRetriever $yearPeriodRetriever): Response {
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?
public function __invoke(Request $request, YearPeriodRetriever $yearPeriodRetriever): Response
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?
{
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?
$yearPeriod = $yearPeriodRetriever->selected();
$startDate = Carbon::createFromDate($yearPeriod->year)->startOfYear()->startOfWeek();
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review
Copy Link

Could you add return types for arrow functions?

Could you add return types for arrow functions?

2
resources/css/app.css
View File

@@ -76,7 +76,7 @@
}
.v-popper--theme-tooltip .v-popper__arrow-outer {
border-color: #527ABA;
border-color: #000;
}
.v-popper--theme-tooltip:focus-visible {