#71 - annual summary #113

Merged
Baakoma merged 16 commits from #71-annual-summary into main 2022-04-07 14:33:15 +02:00
2 changed files with 3 additions and 10 deletions
Showing only changes of commit d24517271d - Show all commits

View File

@@ -5,7 +5,6 @@ declare(strict_types=1);
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
namespace Toby\Infrastructure\Http\Controllers;
use Illuminate\Http\Request;
use Illuminate\Support\Carbon;
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
use Inertia\Response;
use Toby\Eloquent\Helpers\YearPeriodRetriever;
use Toby\Eloquent\Models\Holiday;
@@ -18,24 +17,20 @@ class AnnualSummaryController extends Controller
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
{
$yearPeriod = $yearPeriodRetriever->selected();
$startDate = Carbon::createFromDate($yearPeriod->year)->startOfYear()->startOfWeek();
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
$endDate = Carbon::createFromDate($yearPeriod->year)->endOfYear()->endOfWeek();
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
$holidays = $yearPeriod->holidays()
->whereBetween("date", [$startDate, $endDate])
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
->get();
$vacations = $request->user()
->vacations()
->with("vacationRequest.vacations")
->whereBetween("date", [$startDate, $endDate])
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
->whereBelongsTo($yearPeriod)
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
->approved()
->get();
$pendingVacations = $request->user()
->vacations()
->with("vacationRequest.vacations")
->whereBetween("date", [$startDate, $endDate])
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
->whereBelongsTo($yearPeriod)
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
->pending()
->get();
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?
mtracz commented 2022-04-07 13:35:08 +02:00 (Migrated from github.com)
Review

Could you add return types for arrow functions?

Could you add return types for arrow functions?

View File

@@ -35,7 +35,6 @@
<Popper
v-if="day.isVacation || day.isPendingVacation"
open-delay="200"
arrow
hover
offset-distance="0"
>
@@ -56,7 +55,6 @@
<Popper
v-else-if="day.isHoliday"
open-delay="200"
arrow
hover
offset-distance="0"
>
@@ -68,7 +66,7 @@
{{ day.date.day }}
</time>
</button>
<template #popper>
<template #content>
<div class="py-2 px-6 text-sm font-semibold text-left text-gray-700 bg-white rounded-lg border border-gray-400">
{{ holidays[day.date.toISODate()] }}
</div>