#90 - user profile #125

2022-04-14T10:49:41+02:00

Baakoma commented

2022-04-14 10:49:41 +02:00

(Migrated from github.com)

It should close #90 and fixes #124

Also, there are many ui fixes.

It should close #90 and fixes #124 Also, there are many ui fixes.

krzysztofrewak (Migrated from github.com) requested changes 2022-04-14 11:21:23 +02:00

app/Architecture/ExceptionHandler.php

						
				@@ -17,11 +17,29 @@ class ExceptionHandler extends Handler

				        "password_confirmation",

				    ];

				    protected array $handleByInertia = [

krzysztofrewak (Migrated from github.com) commented

2022-04-14 11:15:20 +02:00

Could you use Response::METHOD_NOT_ALLOWED and other consts instead of magic numbers?

Could you use `Response::METHOD_NOT_ALLOWED` and other consts instead of magic numbers?

app/Domain/Notifications/VacationRequestWaitsForApprovalNotification.php

						
				@@ -45,3 +45,3 @@

				    {

				        $user = $this->user->first_name;

				        $user = $this->user->profile->first_name;

				        $type = $this->vacationRequest->type->label();

krzysztofrewak (Migrated from github.com) commented

2022-04-14 11:16:10 +02:00

Why first_name, but fullName?

Why `first_name`, but `fullName`?

app/Infrastructure/Console/Commands/MoveUserDataToProfile.php

krzysztofrewak (Migrated from github.com) commented

2022-04-14 11:19:38 +02:00

Do we need this docblock with these here https://github.com/illuminate/collections/blob/master/Collection.php#L60 ?

app/Infrastructure/Http/Middleware/HandleInertiaRequests.php

krzysztofrewak (Migrated from github.com) commented

2022-04-14 11:20:20 +02:00

        return fn(): array => $request->user() ? $this->yearPeriodRetriever->links() : [];

```suggestion return fn(): array => $request->user() ? $this->yearPeriodRetriever->links() : []; ```

krzysztofrewak (Migrated from github.com) commented

2022-04-14 11:20:45 +02:00

        return fn(): ?int => $user && $user->can("listAll", VacationRequest::class)

```suggestion return fn(): ?int => $user && $user->can("listAll", VacationRequest::class) ```

EwelinaLasowy (Migrated from github.com) reviewed 2022-04-14 11:21:52 +02:00

resources/js/app.js

EwelinaLasowy (Migrated from github.com) commented

2022-04-14 11:20:47 +02:00

Settings.defaultLocale = 'pl'

```suggestion Settings.defaultLocale = 'pl' ```

krzysztofrewak (Migrated from github.com) requested changes 2022-04-14 11:25:05 +02:00

resources/js/Shared/InertiaLink.js

krzysztofrewak (Migrated from github.com) commented

2022-04-14 11:24:08 +02:00

              onBefore: () => !processing.value,

👀

```suggestion onBefore: () => !processing.value, ``` :eyes:

krzysztofrewak (Migrated from github.com) approved these changes 2022-04-14 11:57:04 +02:00

EwelinaLasowy (Migrated from github.com) approved these changes 2022-04-14 11:58:02 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#125