#134 - fill users data for resume #144

2022-05-11T09:02:07+02:00

Baakoma commented

(Migrated from github.com)

It should close #134 and close #135

krzysztofrewak (Migrated from github.com) requested changes 2022-05-17 15:13:45 +02:00

.eslintrc.js

krzysztofrewak (Migrated from github.com) commented

Why did you removed these?

krzysztofrewak (Migrated from github.com) commented

            "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,

```suggestion "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null, ```

Baakoma (Migrated from github.com) reviewed 2022-05-17 15:19:20 +02:00

.eslintrc.js

Baakoma (Migrated from github.com) commented

These rules were too heavy and were slowing down the linter a lot.

krzysztofrewak (Migrated from github.com) approved these changes 2022-05-18 08:29:44 +02:00

krzysztofrewak (Migrated from github.com) left a comment

This is a big pull request. Maybe it would be good to wait for a second approve?

EwelinaLasowy (Migrated from github.com) approved these changes 2022-05-18 08:48:19 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#144