kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#134 - fill users data for resume #144

Merged
Baakoma merged 34 commits from #134-fill-users-data-for-resume into main 2022-05-18 08:50:41 +02:00
Conversation 4 Commits 34 Files Changed 42 +4 -1
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit cda691ea2b - Show all commits

2
database/factories/ResumeFactory.php
View File

@@ -17,7 +17,7 @@ class ResumeFactory extends Factory
krzysztofrewak commented 2022-05-17 15:12:52 +02:00 (Migrated from github.com)
Review
Copy Link
            "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,
```suggestion "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null, ```
krzysztofrewak commented 2022-05-17 15:12:52 +02:00 (Migrated from github.com)
Review
Copy Link
            "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,
```suggestion "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null, ```
public function definition(): array
{
return [
"name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,
krzysztofrewak commented 2022-05-17 15:12:52 +02:00 (Migrated from github.com)
Review
Copy Link
            "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,
```suggestion "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null, ```
"name" => fn(array $attributes): ?string => empty($attributes["user_id"]) ? $this->faker->name : null,
krzysztofrewak commented 2022-05-17 15:12:52 +02:00 (Migrated from github.com)
Review
Copy Link
            "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,
```suggestion "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null, ```
"education" => $this->generateEducation(),
"languages" => $this->generateLanguages(),
"technologies" => $this->generateTechnologies(),
krzysztofrewak commented 2022-05-17 15:12:52 +02:00 (Migrated from github.com)
Review
Copy Link
            "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,
```suggestion "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null, ```
krzysztofrewak commented 2022-05-17 15:12:52 +02:00 (Migrated from github.com)
Review
Copy Link
            "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null,
```suggestion "name" => fn(array $attributes): bool => empty($attributes["user_id"]) ? $this->faker->name : null, ```

3
tests/Feature/ResumeTest.php
View File

@@ -6,6 +6,7 @@ namespace Tests\Feature;
use Illuminate\Foundation\Testing\DatabaseMigrations;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Storage;
use Inertia\Testing\AssertableInertia as Assert;
use Tests\FeatureTestCase;
use Toby\Domain\Enums\EmploymentForm;
@@ -21,6 +22,8 @@ class ResumeTest extends FeatureTestCase
{
parent::setUp();
Storage::fake();
Technology::factory()->createMany([
["name" => "Laravel"],
["name" => "Symfony"],