kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#2 - authentication via google #16

Merged
Baakoma merged 10 commits from #2-auth-via-google into main 2022-01-13 14:19:11 +01:00
Conversation 5 Commits 10 Files Changed 31 +534 -122
Baakoma commented 2022-01-13 09:25:49 +01:00 (Migrated from github.com)
Copy Link

It should close #2

image

It should close #2 ![image](https://user-images.githubusercontent.com/16743001/149325628-97525359-a5f4-4eba-8e86-49070c6cadf0.png)
krzysztofrewak (Migrated from github.com) requested changes 2022-01-13 13:42:19 +01:00
app/Http/Controllers/GoogleController.php
@@ -0,0 +26,4 @@
$user = User::query()
->where("email", $socialUser->getEmail())
->firstOrFail();
} catch (ModelNotFoundException) {
krzysztofrewak (Migrated from github.com) commented 2022-01-13 13:38:29 +01:00
Copy Link

Is this try-catch really refers to entire block of code? And maybe this failed redirect could be move to the exception?

Is this try-catch really refers to entire block of code? And maybe this failed redirect could be move to the exception?
app/Http/Controllers/LogoutController.php
@@ -0,0 +12,4 @@
{
public function __invoke(Request $request): RedirectResponse
{
Auth::logout();
krzysztofrewak (Migrated from github.com) commented 2022-01-13 13:40:44 +01:00
Copy Link
        $request->user()?->logout();
```suggestion $request->user()?->logout(); ```
app/Http/Middleware/Authenticate.php
krzysztofrewak (Migrated from github.com) commented 2022-01-13 13:41:15 +01:00
Copy Link

Could it be null with route()?

Could it be null with `route()`?
resources/js/Shared/Layout/GuestLayout.vue
krzysztofrewak (Migrated from github.com) commented 2022-01-13 13:41:57 +01:00
Copy Link
</script>
```suggestion </script> ```
resources/lang/pl.json
krzysztofrewak (Migrated from github.com) commented 2022-01-13 13:42:07 +01:00
Copy Link
}
```suggestion } ```
Baakoma (Migrated from github.com) reviewed 2022-01-13 13:55:27 +01:00
app/Http/Controllers/LogoutController.php
Baakoma (Migrated from github.com) commented 2022-01-13 13:55:27 +01:00
Copy Link

It doesn't work.

It doesn't work.
Baakoma (Migrated from github.com) reviewed 2022-01-13 14:01:50 +01:00
app/Http/Controllers/GoogleController.php
@@ -0,0 +26,4 @@
$user = User::query()
->where("email", $socialUser->getEmail())
->firstOrFail();
} catch (ModelNotFoundException) {
Baakoma (Migrated from github.com) commented 2022-01-13 14:01:50 +01:00
Copy Link

I would like to keep it simple for now. I'll refactor it when error handling and notifications/alerts will work.

I would like to keep it simple for now. I'll refactor it when error handling and notifications/alerts will work.
krzysztofrewak (Migrated from github.com) approved these changes 2022-01-13 14:15:59 +01:00
EwelinaLasowy (Migrated from github.com) approved these changes 2022-01-13 14:19:04 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Baakoma
krzysztofrewak
EwelinaLasowy
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#16
Delete Branch "#2-auth-via-google"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?