kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#17 - set up Laravel Dusk #18

Merged
EwelinaLasowy merged 7 commits from #17-set-up-laravel-dusk into main 2022-01-18 12:22:02 +01:00
Conversation 4 Commits 7 Files Changed 16 +397 -27
EwelinaLasowy commented 2022-01-14 13:46:11 +01:00 (Migrated from github.com)
Copy Link
No description provided.
krzysztofrewak commented 2022-01-14 13:51:34 +01:00 (Migrated from github.com)
Copy Link

In memoriam https://github.com/blumilksoftware/eupms/pull/201 (2021-22) 🕯️

In memoriam https://github.com/blumilksoftware/eupms/pull/201 (2021-22) :candle:
krzysztofrewak (Migrated from github.com) requested changes 2022-01-18 10:35:12 +01:00
.env.dusk.local
krzysztofrewak (Migrated from github.com) commented 2022-01-18 10:30:19 +01:00
Copy Link
APP_DEBUG=false
APP_URL=http://toby-web

I would stay with order proposed in .env.example.

```suggestion APP_DEBUG=false APP_URL=http://toby-web ``` I would stay with order proposed in `.env.example`.
phpunit.xml
@@ -31,0 +28,4 @@
<env name="DB_USERNAME" value="toby"/>
<env name="DB_PASSWORD" value="password"/>
<env name="MAIL_MAILER" value="array"/>
<env name="QUEUE_CONNECTION" value="sync"/>
krzysztofrewak (Migrated from github.com) commented 2022-01-18 10:31:29 +01:00
Copy Link

Do we need these with provided .env.* files?

Do we need these with provided `.env.*` files?
EwelinaLasowy (Migrated from github.com) reviewed 2022-01-18 11:53:24 +01:00
phpunit.xml
@@ -31,0 +28,4 @@
<env name="DB_USERNAME" value="toby"/>
<env name="DB_PASSWORD" value="password"/>
<env name="MAIL_MAILER" value="array"/>
<env name="QUEUE_CONNECTION" value="sync"/>
EwelinaLasowy (Migrated from github.com) commented 2022-01-18 11:53:23 +01:00
Copy Link

I think that we need, because each .env.* file is used for different cases:
.env - local development
.env.ci -tests run in CI
.env.dusk.local - Laravel Dusk tests
and phpunit.xml - local tests

I think that we need, because each `.env.*` file is used for different cases: `.env` - local development `.env.ci` -tests run in CI `.env.dusk.local `- Laravel Dusk tests and `phpunit.xml` - local tests
krzysztofrewak (Migrated from github.com) approved these changes 2022-01-18 12:21:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
EwelinaLasowy
krzysztofrewak
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#18
Delete Branch "#17-set-up-laravel-dusk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?