kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#4 - users CRUD #24

Merged
Baakoma merged 24 commits from #4-users-crud into main 2022-01-19 10:55:10 +01:00
Conversation 6 Commits 24 Files Changed 41 +1977 -63
Baakoma commented 2022-01-18 10:09:33 +01:00 (Migrated from github.com)
Copy Link

It should close #4

imageimage
image

It should close #4 ![image](https://user-images.githubusercontent.com/16743001/149906604-9d04cbf0-60ca-4b95-a7f7-95c0543ab58e.png)![image](https://user-images.githubusercontent.com/16743001/149906463-0d8ee29f-48ee-4339-8390-4f1a2955baf5.png) ![image](https://user-images.githubusercontent.com/16743001/149906389-8ffd7740-b136-41a0-83f0-c10ab127bc67.png)
krzysztofrewak (Migrated from github.com) requested changes 2022-01-18 13:29:11 +01:00
app/Enums/FormOfEmployment.php
krzysztofrewak (Migrated from github.com) commented 2022-01-18 13:26:55 +01:00
Copy Link

Wouldn't EmploymenyForm a better name?

Wouldn't `EmploymenyForm` a better name?
krzysztofrewak (Migrated from github.com) commented 2022-01-18 13:27:29 +01:00
Copy Link

I would create some "business" namespace for that and all other legal/corporate stuff.

I would create some "business" namespace for that and all other legal/corporate stuff.
krzysztofrewak (Migrated from github.com) requested changes 2022-01-18 14:06:43 +01:00
.env.example
krzysztofrewak (Migrated from github.com) commented 2022-01-18 13:57:12 +01:00
Copy Link

Maybe add more descriptive key?

Maybe add more descriptive key?
app/Helpers/UserAvatarGenerator.php
krzysztofrewak (Migrated from github.com) commented 2022-01-18 14:02:44 +01:00
Copy Link
    protected function getRandomColor(string $name): string
    {
        $colors = config("colors");

        return $colors[strlen($name) % count($colors)];
    }
```suggestion protected function getRandomColor(string $name): string { $colors = config("colors"); return $colors[strlen($name) % count($colors)]; } ```
app/Helpers/UserAvatarGenerator.php
@@ -0,0 +31,4 @@
return $this->generator->rounded()
->background($this->getColor($user->name))
->color("#F4F8FD")
->smooth()
krzysztofrewak (Migrated from github.com) commented 2022-01-18 13:58:31 +01:00
Copy Link

Maybe this would be better?

            ->smooth()
            ->fontSize(0.33)
Maybe this would be better? ```suggestion ->smooth() ->fontSize(0.33) ```
app/Helpers/UserAvatarGenerator.php
@@ -0,0 +33,4 @@
->color("#F4F8FD")
->smooth()
->fontSize(0.33)
->generateSvg($user->name);
krzysztofrewak (Migrated from github.com) commented 2022-01-18 13:59:14 +01:00
Copy Link

Have you checked if that works with Polish signs? Is Łukasz Żbik a valid name for this package?

Have you checked if that works with Polish signs? Is `Łukasz Żbik` a valid name for this package?
app/Http/Resources/UserResource.php
@@ -11,2 +11,4 @@
public static $wrap = false;
public function toArray($request): array
{
krzysztofrewak (Migrated from github.com) commented 2022-01-18 14:04:10 +01:00
Copy Link

I wouldn't use trashed word anywhere outside Laravel. It has bad connotations. ;)

I wouldn't use `trashed` word anywhere outside Laravel. It has bad connotations. ;)
resources/js/Shared/MainMenu.vue
krzysztofrewak (Migrated from github.com) commented 2022-01-18 14:05:39 +01:00
Copy Link
            {name: 'Użytkownicy', href: '/uzytkownicy', current: false},

I would use Polish routes for frontend. Backend can be in English.

```suggestion {name: 'Użytkownicy', href: '/uzytkownicy', current: false}, ``` I would use Polish routes for frontend. Backend can be in English.
resources/js/app.js
krzysztofrewak (Migrated from github.com) commented 2022-01-18 14:06:01 +01:00
Copy Link

Could you enforce trailing commas in eslint?

Could you enforce trailing commas in eslint?
EwelinaLasowy (Migrated from github.com) reviewed 2022-01-18 14:21:33 +01:00
app/Helpers/UserAvatarGenerator.php
@@ -0,0 +33,4 @@
->color("#F4F8FD")
->smooth()
->fontSize(0.33)
->generateSvg($user->name);
EwelinaLasowy (Migrated from github.com) commented 2022-01-18 14:21:33 +01:00
Copy Link

It works.
image

It works. ![image](https://user-images.githubusercontent.com/56546832/149945138-577727a8-0b69-4640-af2b-156505fc593c.png)
Baakoma (Migrated from github.com) reviewed 2022-01-18 14:49:44 +01:00
resources/js/Shared/MainMenu.vue
Baakoma (Migrated from github.com) commented 2022-01-18 14:49:43 +01:00
Copy Link

You mean all GET routes in polish and POST/PUT/DELETE in english?

You mean all GET routes in polish and POST/PUT/DELETE in english?
EwelinaLasowy (Migrated from github.com) approved these changes 2022-01-19 09:31:01 +01:00
krzysztofrewak (Migrated from github.com) approved these changes 2022-01-19 10:53:32 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Baakoma
EwelinaLasowy
krzysztofrewak
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#24
Delete Branch "#4-users-crud"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?