kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#23 - collective editing vacation days #26

Merged
Baakoma merged 11 commits from #23-collective-editing-vacation-days into main 2022-01-24 11:28:00 +01:00
Conversation 4 Commits 11 Files Changed 35 +1000 -41
Baakoma commented 2022-01-24 10:31:28 +01:00 (Migrated from github.com)
Copy Link

It should close #23
Also I created something like global "year period scope". You can select specific year period if you want to see data for 2021, 2022, etc. The choice is stored in the session.

image

It should close #23 Also I created something like global "year period scope". You can select specific year period if you want to see data for 2021, 2022, etc. The choice is stored in the session. ![image](https://user-images.githubusercontent.com/16743001/150755886-1154ab2d-223e-497e-bc7d-60e29792aa70.png)
krzysztofrewak (Migrated from github.com) requested changes 2022-01-24 10:49:42 +01:00
app/Helpers/YearPeriodRetriever.php
krzysztofrewak (Migrated from github.com) commented 2022-01-24 10:46:45 +01:00
Copy Link

Could you inject session via DI?

Could you inject session via DI?
app/Providers/AppServiceProvider.php
@@ -6,15 +6,15 @@ namespace Toby\Providers;
krzysztofrewak (Migrated from github.com) commented 2022-01-24 10:49:23 +01:00
Copy Link

TBH I would move these to some separate ObserverServiceProvider.

TBH I would move these to some separate `ObserverServiceProvider`.
database/migrations/2022_01_19_140630_create_vacation_limits_table.php
krzysztofrewak (Migrated from github.com) commented 2022-01-24 10:48:45 +01:00
Copy Link

Do we need that field? Nullable days indicate the same, I think.

Do we need that field? Nullable `days` indicate the same, I think.
resources/js/Pages/VacationLimits.vue
@@ -0,0 +163,4 @@
items: data.items.map(item => ({
id: item.id,
days: item.hasVacation ? item.days : null,
})),
krzysztofrewak (Migrated from github.com) commented 2022-01-24 10:46:20 +01:00
Copy Link
                    })).sort((a, b) => a.name.toLowerCase().localeCompare(b.name.toLowerCase())),
```suggestion })).sort((a, b) => a.name.toLowerCase().localeCompare(b.name.toLowerCase())), ```
krzysztofrewak (Migrated from github.com) commented 2022-01-24 10:47:43 +01:00
Copy Link

Or maybe just soirt it on backend?

Or maybe just soirt it on backend?
EwelinaLasowy (Migrated from github.com) reviewed 2022-01-24 11:09:59 +01:00
resources/js/Pages/VacationLimits.vue
@@ -0,0 +163,4 @@
items: data.items.map(item => ({
id: item.id,
days: item.hasVacation ? item.days : null,
})),
EwelinaLasowy (Migrated from github.com) commented 2022-01-24 11:09:59 +01:00
Copy Link

I've created issue for that - link.

I've created issue for that - [link]( https://github.com/blumilksoftware/toby/issues/27).
krzysztofrewak (Migrated from github.com) approved these changes 2022-01-24 11:25:30 +01:00
EwelinaLasowy (Migrated from github.com) approved these changes 2022-01-24 11:27:40 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
krzysztofrewak
EwelinaLasowy
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#26
Delete Branch "#23-collective-editing-vacation-days"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?