#27 - separate fields for name and surname #29

2022-01-24T12:15:06+01:00

Baakoma commented

2022-01-24 12:15:06 +01:00

(Migrated from github.com)

It should close #27

EwelinaLasowy (Migrated from github.com) reviewed 2022-01-24 12:22:54 +01:00

app/Http/Requests/UserRequest.php

EwelinaLasowy (Migrated from github.com) commented

2022-01-24 12:21:42 +01:00

            "firstName" => ["required", "min:3", "max:80"],

```suggestion "firstName" => ["required", "min:3", "max:80"], ```

EwelinaLasowy (Migrated from github.com) commented

2022-01-24 12:21:54 +01:00

            "lastName" => ["required", "min:3", "max:80"],

```suggestion "lastName" => ["required", "min:3", "max:80"], ```

krzysztofrewak (Migrated from github.com) requested changes 2022-01-24 12:23:09 +01:00

app/Http/Controllers/UserController.php

						
				@@ -22,2 +22,3 @@

				            ->search($request->query("search"))

				            ->latest()

				            ->orderBy("last_name")

				            ->orderBy("first_name")

krzysztofrewak (Migrated from github.com) commented

2022-01-24 12:22:01 +01:00

            ->orderBy("last_name")
            ->orderBy("first_name")

Please remember about nepotism. ;)

```suggestion ->orderBy("last_name") ->orderBy("first_name") ``` Please remember about nepotism. ;)

app/Http/Requests/UserRequest.php

krzysztofrewak (Migrated from github.com) commented

2022-01-24 12:22:35 +01:00

            "firstName" => ["required", "min:3", "max:80"],
            "lastName" => ["required", "min:3", "max:80"],

```suggestion "firstName" => ["required", "min:3", "max:80"], "lastName" => ["required", "min:3", "max:80"], ```

krzysztofrewak (Migrated from github.com) approved these changes 2022-01-24 12:38:28 +01:00

EwelinaLasowy (Migrated from github.com) approved these changes 2022-01-24 12:40:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#29