kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#41 - email notifications #54

Merged
EwelinaLasowy merged 44 commits from #41-email-notifications into main 2022-02-21 13:19:59 +01:00
Conversation 2 Commits 44 Files Changed 28 +1116 -27
EwelinaLasowy commented 2022-02-17 12:26:26 +01:00 (Migrated from github.com)
Copy Link

This should close #41.
Notification are sent depending on the state of the vacation request:

  • when vacation request is created, user that created the vacation request receive e-mail
    image
  • when vacation request is waiting for technical/administrative approval, all technical/administrative approvers receive e-mail
    image
  • when vacation request is cancelled/rejected/approved, user that created the vacation request, all technical/administrative approvers receive e-mail
    image
This should close #41. Notification are sent depending on the state of the vacation request: - when vacation request is created, user that created the vacation request receive e-mail ![image](https://user-images.githubusercontent.com/56546832/154673396-748dbf54-f4a8-4754-9906-3681cefc059e.png) - when vacation request is waiting for technical/administrative approval, all technical/administrative approvers receive e-mail ![image](https://user-images.githubusercontent.com/56546832/154673439-b32a11a3-5eb4-41b6-b568-076f36a25271.png) - when vacation request is cancelled/rejected/approved, user that created the vacation request, all technical/administrative approvers receive e-mail ![image](https://user-images.githubusercontent.com/56546832/154677552-9f683695-edf2-4206-b9e5-a5cf0d4e7f02.png)
jsawo (Migrated from github.com) requested changes 2022-02-21 12:40:13 +01:00
app/Domain/Events/VacationRequestWaitedForAdministrative.php
jsawo (Migrated from github.com) commented 2022-02-21 12:31:09 +01:00
Copy Link
class VacationRequestWaitsForAdminApproval
```suggestion class VacationRequestWaitsForAdminApproval ```
app/Domain/Events/VacationRequestWaitedForTechnical.php
jsawo (Migrated from github.com) commented 2022-02-21 12:31:57 +01:00
Copy Link
class VacationRequestWaitsForTechApproval
```suggestion class VacationRequestWaitsForTechApproval ```
app/Domain/Notifications/VacationRequestApprovedNotification.php
jsawo (Migrated from github.com) commented 2022-02-21 12:35:33 +01:00
Copy Link

"d.m.Y" is repeated more than 10 times in this PR alone - it is safe to assume there will be more
maybe we should consider using a const here?
This would prevent potential bugs and make it easier to change the format if needed.

`"d.m.Y"` is repeated more than 10 times in this PR alone - it is safe to assume there will be more maybe we should consider using a const here? This would prevent potential bugs and make it easier to change the format if needed.
jsawo (Migrated from github.com) approved these changes 2022-02-21 13:06:53 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
jsawo
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#54
Delete Branch "#41-email-notifications"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?