kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#41 - email notifications #54

Merged
EwelinaLasowy merged 44 commits from #41-email-notifications into main 2022-02-21 13:19:59 +01:00
Conversation 2 Commits 44 Files Changed 28 +4 -4
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9426861522 - Show all commits

2
app/Domain/Notifications/VacationRequestApprovedNotification.php
View File

@@ -43,7 +43,7 @@ class VacationRequestApprovedNotification extends Notification
jsawo commented 2022-02-21 12:35:33 +01:00 (Migrated from github.com)
Review
Copy Link

"d.m.Y" is repeated more than 10 times in this PR alone - it is safe to assume there will be more
maybe we should consider using a const here?
This would prevent potential bugs and make it easier to change the format if needed.

`"d.m.Y"` is repeated more than 10 times in this PR alone - it is safe to assume there will be more maybe we should consider using a const here? This would prevent potential bugs and make it easier to change the format if needed.
jsawo commented 2022-02-21 12:35:33 +01:00 (Migrated from github.com)
Review
Copy Link

"d.m.Y" is repeated more than 10 times in this PR alone - it is safe to assume there will be more
maybe we should consider using a const here?
This would prevent potential bugs and make it easier to change the format if needed.

`"d.m.Y"` is repeated more than 10 times in this PR alone - it is safe to assume there will be more maybe we should consider using a const here? This would prevent potential bugs and make it easier to change the format if needed.
protected function buildMailMessage(string $url): MailMessage
{
$user = $this->vacationRequest->user->first_name;
jsawo commented 2022-02-21 12:35:33 +01:00 (Migrated from github.com)
Review
Copy Link

"d.m.Y" is repeated more than 10 times in this PR alone - it is safe to assume there will be more
maybe we should consider using a const here?
This would prevent potential bugs and make it easier to change the format if needed.

`"d.m.Y"` is repeated more than 10 times in this PR alone - it is safe to assume there will be more maybe we should consider using a const here? This would prevent potential bugs and make it easier to change the format if needed.
$user = $this->user->first_name;
jsawo commented 2022-02-21 12:35:33 +01:00 (Migrated from github.com)
Review
Copy Link

"d.m.Y" is repeated more than 10 times in this PR alone - it is safe to assume there will be more
maybe we should consider using a const here?
This would prevent potential bugs and make it easier to change the format if needed.

`"d.m.Y"` is repeated more than 10 times in this PR alone - it is safe to assume there will be more maybe we should consider using a const here? This would prevent potential bugs and make it easier to change the format if needed.
$title = $this->vacationRequest->name;
$type = $this->vacationRequest->type->label();
$from = $this->vacationRequest->from->format("d.m.Y");
jsawo commented 2022-02-21 12:35:33 +01:00 (Migrated from github.com)
Review
Copy Link

"d.m.Y" is repeated more than 10 times in this PR alone - it is safe to assume there will be more
maybe we should consider using a const here?
This would prevent potential bugs and make it easier to change the format if needed.

`"d.m.Y"` is repeated more than 10 times in this PR alone - it is safe to assume there will be more maybe we should consider using a const here? This would prevent potential bugs and make it easier to change the format if needed.
jsawo commented 2022-02-21 12:35:33 +01:00 (Migrated from github.com)
Review
Copy Link

"d.m.Y" is repeated more than 10 times in this PR alone - it is safe to assume there will be more
maybe we should consider using a const here?
This would prevent potential bugs and make it easier to change the format if needed.

`"d.m.Y"` is repeated more than 10 times in this PR alone - it is safe to assume there will be more maybe we should consider using a const here? This would prevent potential bugs and make it easier to change the format if needed.

2
app/Domain/Notifications/VacationRequestCancelledNotification.php
View File

@@ -43,7 +43,7 @@ class VacationRequestCancelledNotification extends Notification
protected function buildMailMessage(string $url): MailMessage
{
$user = $this->vacationRequest->user->first_name;
$user = $this->user->first_name;
$title = $this->vacationRequest->name;
$type = $this->vacationRequest->type->label();
$from = $this->vacationRequest->from->format("d.m.Y");

2
app/Domain/Notifications/VacationRequestRejectedNotification.php
View File

@@ -43,7 +43,7 @@ class VacationRequestRejectedNotification extends Notification
protected function buildMailMessage(string $url): MailMessage
{
$user = $this->vacationRequest->user->first_name;
$user = $this->user->first_name;
$title = $this->vacationRequest->name;
$type = $this->vacationRequest->type->label();
$from = $this->vacationRequest->from->format("d.m.Y");

2
resources/lang/pl.json
View File

@@ -61,7 +61,7 @@
"The vacation request :title from user: :requester is waiting for your approval.": "Wniosek urlopowy :title od użytkownika :requester czeka na Twoją akceptację.",
"Vacation request :title has been approved": "Wniosek urlopowy :title został zatwierdzony",
"The vacation request :title for user :requester has been approved.": "Wniosek urlopowy :title od użytkownika :requester został zatwierdzony.",
"Vacation request :title has been cancelled": "WNiosek urlopowy :title został anulowany",
"Vacation request :title has been cancelled": "Wniosek urlopowy :title został anulowany",
"The vacation request :title for user :requester has been cancelled.": "Wniosek urlopowy :title od użytkownika :requester został anulowany.",
"Vacation request :title has been rejected": "Wniosek urlopowy :title został odrzucony",
"The vacation request :title for user :requester has been rejected.": "Wniosek urlopowy :title od użytkownika :requester został odrzucony."