kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#39 - generate timesheet #56

Merged
Baakoma merged 9 commits from #39-generate-timesheet into main 2022-02-21 16:09:45 +01:00
Conversation 5 Commits 9 Files Changed 12 +1085 -143
Baakoma commented 2022-02-21 15:01:50 +01:00 (Migrated from github.com)
Copy Link

It should close #39
image

It should close #39 ![image](https://user-images.githubusercontent.com/16743001/154969666-0f0838a4-2bbd-4f32-b8a2-2ed968cb3552.png)
krzysztofrewak (Migrated from github.com) requested changes 2022-02-21 15:35:16 +01:00
app/Domain/Enums/Month.php
@@ -0,0 +37,4 @@
self::September => CarbonInterface::SEPTEMBER,
self::October => CarbonInterface::OCTOBER,
self::November => CarbonInterface::NOVEMBER,
self::December => CarbonInterface::DECEMBER,
krzysztofrewak (Migrated from github.com) commented 2022-02-21 15:32:49 +01:00
Copy Link
            static::January => CarbonInterface::JANUARY,
            static::February => CarbonInterface::FEBRUARY,
            static::March => CarbonInterface::MARCH,
            static::April => CarbonInterface::APRIL,
            static::May => CarbonInterface::MAY,
            static::June => CarbonInterface::JUNE,
            static::July => CarbonInterface::JULY,
            static::August => CarbonInterface::AUGUST,
            static::September => CarbonInterface::SEPTEMBER,
            static::October => CarbonInterface::OCTOBER,
            static::November => CarbonInterface::NOVEMBER,
            static::December => CarbonInterface::DECEMBER,
```suggestion static::January => CarbonInterface::JANUARY, static::February => CarbonInterface::FEBRUARY, static::March => CarbonInterface::MARCH, static::April => CarbonInterface::APRIL, static::May => CarbonInterface::MAY, static::June => CarbonInterface::JUNE, static::July => CarbonInterface::JULY, static::August => CarbonInterface::AUGUST, static::September => CarbonInterface::SEPTEMBER, static::October => CarbonInterface::OCTOBER, static::November => CarbonInterface::NOVEMBER, static::December => CarbonInterface::DECEMBER, ```
krzysztofrewak (Migrated from github.com) commented 2022-02-21 15:33:17 +01:00
Copy Link

Plus maybe some exception could be thrown on unknow value/default?

Plus maybe some exception could be thrown on unknow value/default?
app/Domain/TimesheetExport.php
krzysztofrewak (Migrated from github.com) commented 2022-02-21 15:33:37 +01:00
Copy Link

Why not to use map()?

Why not to use `map()`?
config/excel.php
krzysztofrewak (Migrated from github.com) commented 2022-02-21 15:34:57 +01:00
Copy Link

I would import that too.

I would import that too.
mtracz (Migrated from github.com) requested changes 2022-02-21 15:41:55 +01:00
app/Domain/Enums/Month.php
mtracz (Migrated from github.com) commented 2022-02-21 15:39:05 +01:00
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
app/Domain/TimesheetPerUserSheet.php
mtracz (Migrated from github.com) commented 2022-02-21 15:40:19 +01:00
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
Baakoma (Migrated from github.com) reviewed 2022-02-21 15:48:14 +01:00
app/Domain/Enums/Month.php
@@ -0,0 +37,4 @@
self::September => CarbonInterface::SEPTEMBER,
self::October => CarbonInterface::OCTOBER,
self::November => CarbonInterface::NOVEMBER,
self::December => CarbonInterface::DECEMBER,
Baakoma (Migrated from github.com) commented 2022-02-21 15:48:14 +01:00
Copy Link

image

![image](https://user-images.githubusercontent.com/16743001/154977581-bb213207-098b-4e9d-8feb-7d1b5c69e4e5.png)
mtracz (Migrated from github.com) approved these changes 2022-02-21 16:00:44 +01:00
krzysztofrewak (Migrated from github.com) approved these changes 2022-02-21 16:06:28 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Baakoma
mtracz
krzysztofrewak
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#56
Delete Branch "#39-generate-timesheet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?