kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#39 - generate timesheet #56

Merged
Baakoma merged 9 commits from #39-generate-timesheet into main 2022-02-21 16:09:45 +01:00
Conversation 5 Commits 9 Files Changed 12 +1 -7
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 96192c0f2c - Show all commits

8
app/Domain/Enums/Month.php
View File

@@ -48,12 +48,6 @@ enum Month: string
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
public static function fromNameOrCurrent(string $name): Month
{
$month = Month::tryFrom($name);
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
if ($month === null) {
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
return Month::current();
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
}
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
return $month;
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
return Month::tryFrom($name) ?? Month::current();
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
}
}
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```
mtracz commented 2022-02-21 15:39:05 +01:00 (Migrated from github.com)
Review
Copy Link

I think we can simplify it:

        return Month::tryFrom($name) ?? Month::current();
I think we can simplify it: ```suggestion return Month::tryFrom($name) ?? Month::current(); ```