kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#39 - generate timesheet #56

Merged
Baakoma merged 9 commits from #39-generate-timesheet into main 2022-02-21 16:09:45 +01:00
Conversation 5 Commits 9 Files Changed 12 +7 -2
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d6afa561a7 - Show all commits

9
app/Domain/TimesheetPerUserSheet.php
View File

@@ -21,6 +21,7 @@ use Maatwebsite\Excel\Events\AfterSheet;
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
use PhpOffice\PhpSpreadsheet\Shared\Date; use PhpOffice\PhpSpreadsheet\Shared\Date;
use PhpOffice\PhpSpreadsheet\Style\Alignment; use PhpOffice\PhpSpreadsheet\Style\Alignment;
use PhpOffice\PhpSpreadsheet\Style\Border; use PhpOffice\PhpSpreadsheet\Style\Border;
use PhpOffice\PhpSpreadsheet\Style\Color;
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
use PhpOffice\PhpSpreadsheet\Style\Fill; use PhpOffice\PhpSpreadsheet\Style\Fill;
use PhpOffice\PhpSpreadsheet\Style\NumberFormat; use PhpOffice\PhpSpreadsheet\Style\NumberFormat;
use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet; use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
@@ -141,7 +142,9 @@ class TimesheetPerUserSheet implements WithTitle, WithHeadings, WithEvents, With
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
$sheet->getStyle("A1:{$lastColumn}{$lastRow}") $sheet->getStyle("A1:{$lastColumn}{$lastRow}")
->getBorders() ->getBorders()
->getAllBorders() ->getAllBorders()
->setBorderStyle(Border::BORDER_THIN); ->setBorderStyle(Border::BORDER_THIN)
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
->getColor()
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
->setRGB("B7B7B7");
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
} }
public static function afterSheet(AfterSheet $event): void public static function afterSheet(AfterSheet $event): void
@@ -176,7 +179,9 @@ class TimesheetPerUserSheet implements WithTitle, WithHeadings, WithEvents, With
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
$sheet->getDelegate()->getStyle("A{$lastRow}:E{$lastRow}") $sheet->getDelegate()->getStyle("A{$lastRow}:E{$lastRow}")
->getBorders() ->getBorders()
->getAllBorders() ->getAllBorders()
->setBorderStyle(Border::BORDER_THIN); ->setBorderStyle(Border::BORDER_THIN)
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
->getColor()
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
->setRGB("B7B7B7");
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
} }
protected function getVacationsForPeriod(User $user, CarbonPeriod $period): Collection protected function getVacationsForPeriod(User $user, CarbonPeriod $period): Collection
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?
mtracz commented 2022-02-21 15:40:19 +01:00 (Migrated from github.com)
Review
Copy Link

Maybe move these hours to consts as start hour and end hour?

Maybe move these hours to consts as start hour and end hour?