kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#38 - vacation request by administrative approver #57

Merged
Baakoma merged 10 commits from #38-vacation-request-changes into main 2022-02-22 11:02:36 +01:00
Conversation 2 Commits 10 Files Changed 16 +346 -14
Baakoma commented 2022-02-22 08:30:42 +01:00 (Migrated from github.com)
Copy Link

It should close #38

It should close #38
krzysztofrewak (Migrated from github.com) requested changes 2022-02-22 10:25:37 +01:00
app/Domain/Listeners/SendCreatedVacationRequestNotification.php
@@ -19,2 +24,4 @@
$vacationRequest->user->notify(new VacationRequestCreatedOnEmployeeBehalf($vacationRequest));
}
}
}
krzysztofrewak (Migrated from github.com) commented 2022-02-22 10:22:09 +01:00
Copy Link

You're assigning event's vacation request to the variable and... you are still using event's field.

You're assigning event's vacation request to the variable and... you are still using event's field.
app/Infrastructure/Http/Requests/VacationRequestRequest.php
krzysztofrewak (Migrated from github.com) commented 2022-02-22 10:23:15 +01:00
Copy Link

skipFlow or flowSkipped?

`skipFlow` or `flowSkipped`?
database/factories/VacationRequestFactory.php
krzysztofrewak (Migrated from github.com) commented 2022-02-22 10:23:59 +01:00
Copy Link

Please type it, because I don't know if user ID is integer or string.

Please type it, because I don't know if user ID is integer or string.
resources/lang/pl.json
krzysztofrewak (Migrated from github.com) commented 2022-02-22 10:25:11 +01:00
Copy Link
  "Worked hours": "Liczba godzin",
```suggestion "Worked hours": "Liczba godzin", ```
krzysztofrewak (Migrated from github.com) approved these changes 2022-02-22 10:54:15 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
krzysztofrewak
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#57
Delete Branch "#38-vacation-request-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?