kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#63 - permissions #67

Merged
Baakoma merged 6 commits from #63-permissions into main 2022-03-02 09:52:51 +01:00
Conversation 4 Commits 6 Files Changed 47 +1027 -411
Baakoma commented 2022-03-01 15:23:36 +01:00 (Migrated from github.com)
Copy Link

It should close #63.

It should close #63.
kamilpiech97 (Migrated from github.com) reviewed 2022-03-02 09:36:23 +01:00
app/Domain/States/VacationRequest/WaitingForAdministrative.php
@@ -0,0 +6,4 @@
class WaitingForAdministrative extends VacationRequestState
{
public static string $name = "waiting_for_administrative";
kamilpiech97 (Migrated from github.com) commented 2022-03-02 09:36:18 +01:00
Copy Link

Maybe uppercased value would be better?

Maybe uppercased value would be better?
Baakoma (Migrated from github.com) reviewed 2022-03-02 09:40:29 +01:00
app/Domain/States/VacationRequest/WaitingForAdministrative.php
@@ -0,0 +6,4 @@
class WaitingForAdministrative extends VacationRequestState
{
public static string $name = "waiting_for_administrative";
Baakoma (Migrated from github.com) commented 2022-03-02 09:40:29 +01:00
Copy Link

Not sure if I want to change the rule for these states when everywhere else we use snake_case for that. (these snake_case values are stored in db, eg. Enums)

Not sure if I want to change the rule for these states when everywhere else we use snake_case for that. (these snake_case values are stored in db, eg. Enums)
kamilpiech97 (Migrated from github.com) reviewed 2022-03-02 09:48:59 +01:00
app/Domain/States/VacationRequest/WaitingForAdministrative.php
@@ -0,0 +6,4 @@
class WaitingForAdministrative extends VacationRequestState
{
public static string $name = "waiting_for_administrative";
kamilpiech97 (Migrated from github.com) commented 2022-03-02 09:48:59 +01:00
Copy Link

okey.

okey.
kamilpiech97 (Migrated from github.com) approved these changes 2022-03-02 09:49:25 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Baakoma
kamilpiech97
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#67
Delete Branch "#63-permissions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?