kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#48 - deployment #68

Merged
Baakoma merged 9 commits from #48-deployment into main 2022-03-04 14:47:45 +01:00
Conversation 5 Commits 9 Files Changed 26 +315 -329
Baakoma commented 2022-03-04 09:39:43 +01:00 (Migrated from github.com)
Copy Link
  • redis is now default session and queue driver
  • posgres instead of mysql
  • user avatars use external API (ui-avatars.com) than the local filesystem
* redis is now default session and queue driver * posgres instead of mysql * user avatars use external API (ui-avatars.com) than the local filesystem
mtracz (Migrated from github.com) requested changes 2022-03-04 09:59:02 +01:00
.env.example
mtracz (Migrated from github.com) commented 2022-03-04 09:50:19 +01:00
Copy Link
APP_NAME="Toby HR application"
```suggestion APP_NAME="Toby HR application" ```
.env.example
mtracz (Migrated from github.com) commented 2022-03-04 09:51:31 +01:00
Copy Link

Please define default port, to avoid issues during copy .env.example to .env in new project.

EXTERNAL_WEBSERVER_PORT=8080
Please define default port, to avoid issues during copy .env.example to .env in new project. ```suggestion EXTERNAL_WEBSERVER_PORT=8080 ```
.env.example
@@ -30,1 +32,3 @@
EXTERNAL_WEBSERVER_PORT=
REDIS_PORT=6379
REDIS_HOST=toby-redis
mtracz (Migrated from github.com) commented 2022-03-04 09:54:12 +01:00
Copy Link

Maybe it will be good to create separate env_file for docker-compose config?

Maybe it will be good to create separate `env_file` for docker-compose config?
Baakoma (Migrated from github.com) reviewed 2022-03-04 10:11:56 +01:00
.env.example
@@ -30,1 +32,3 @@
EXTERNAL_WEBSERVER_PORT=
REDIS_PORT=6379
REDIS_HOST=toby-redis
Baakoma (Migrated from github.com) commented 2022-03-04 10:11:56 +01:00
Copy Link

Separate env file only for docker-related config? What if we have the same variables in app and docker?

Separate `env file` only for docker-related config? What if we have the same variables in app and docker?
mtracz (Migrated from github.com) reviewed 2022-03-04 11:19:04 +01:00
.env.example
@@ -12,3 +12,3 @@
DB_PORT=3306
DB_PORT=5432
DB_DATABASE=toby
DB_USERNAME=toby
mtracz (Migrated from github.com) commented 2022-03-04 11:08:56 +01:00
Copy Link

I didn't notice that there is a default value in docker-compose.yml. So let's make them consistent, and please set 80 in .env file.

ports:
      - ${EXTERNAL_WEBSERVER_PORT:-80}:80
I didn't notice that there is a default value in docker-compose.yml. So let's make them consistent, and please set 80 in .env file. ``` ports: - ${EXTERNAL_WEBSERVER_PORT:-80}:80 ```
.env.example
@@ -30,1 +32,3 @@
EXTERNAL_WEBSERVER_PORT=
REDIS_PORT=6379
REDIS_HOST=toby-redis
mtracz (Migrated from github.com) commented 2022-03-04 11:19:04 +01:00
Copy Link

I thought about move all variables related to docker-compose substitution (docker-compose use shell variables and then variables from .env file). There cannot be multiple .env files for building docker-compose config.

We can specify env_files param in each service but then all variables from provided file will be injected into service container. That wont help us with this problem about multiple docker variables in .env file.

I thought about move all variables related to docker-compose substitution (docker-compose use shell variables and then variables from .env file). There cannot be multiple .env files for building docker-compose config. We can specify `env_files` param in each service but then all variables from provided file will be injected into service container. That wont help us with this problem about multiple docker variables in `.env` file.
kamilpiech97 (Migrated from github.com) reviewed 2022-03-04 14:26:22 +01:00
mtracz (Migrated from github.com) approved these changes 2022-03-04 14:46:49 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Baakoma
mtracz
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#68
Delete Branch "#48-deployment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?