kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#48 - heroku deployment #70

Merged
Baakoma merged 34 commits from #48-heroku-deployment into main 2022-03-15 14:46:42 +01:00
Conversation 5 Commits 34 Files Changed 18 +87 -36
Baakoma commented 2022-03-15 10:47:15 +01:00 (Migrated from github.com)
Copy Link

It should close #48

It should close #48
krzysztofrewak (Migrated from github.com) requested changes 2022-03-15 14:22:46 +01:00
composer.json
@@ -7,6 +7,7 @@
"require": {
"php": "^8.1",
"ext-pdo": "*",
"ext-redis": "*",
krzysztofrewak (Migrated from github.com) commented 2022-03-15 14:21:36 +01:00
Copy Link

So do we need ext-redis or predis?

So do we need ext-redis or predis?
config/google-calendar.php
@@ -16,4 +12,3 @@
"calendar_id" => env("GOOGLE_CALENDAR_ID"),
"user_to_impersonate" => env("GOOGLE_CALENDAR_IMPERSONATE"),
];
krzysztofrewak (Migrated from github.com) commented 2022-03-15 14:21:57 +01:00
Copy Link

I would pu it into storage directory.

I would pu it into storage directory.
environment/prod/readme.md
krzysztofrewak (Migrated from github.com) commented 2022-03-15 14:22:30 +01:00
Copy Link

Could you provide here some default values if they're not secret ones?

Could you provide here some default values if they're not secret ones?
Baakoma (Migrated from github.com) reviewed 2022-03-15 14:26:43 +01:00
config/google-calendar.php
@@ -16,4 +12,3 @@
"calendar_id" => env("GOOGLE_CALENDAR_ID"),
"user_to_impersonate" => env("GOOGLE_CALENDAR_IMPERSONATE"),
];
Baakoma (Migrated from github.com) commented 2022-03-15 14:26:43 +01:00
Copy Link

Heroku buildpack creates this file in root directory and we cannot change this location.

Heroku buildpack creates this file in root directory and we cannot change this location.
Baakoma (Migrated from github.com) reviewed 2022-03-15 14:28:47 +01:00
composer.json
@@ -7,6 +7,7 @@
"require": {
"php": "^8.1",
"ext-pdo": "*",
"ext-redis": "*",
Baakoma (Migrated from github.com) commented 2022-03-15 14:28:47 +01:00
Copy Link

ext-redis

ext-redis
krzysztofrewak (Migrated from github.com) reviewed 2022-03-15 14:29:44 +01:00
config/google-calendar.php
@@ -16,4 +12,3 @@
"calendar_id" => env("GOOGLE_CALENDAR_ID"),
"user_to_impersonate" => env("GOOGLE_CALENDAR_IMPERSONATE"),
];
krzysztofrewak (Migrated from github.com) commented 2022-03-15 14:29:43 +01:00
Copy Link

Okok.

Okok.
krzysztofrewak (Migrated from github.com) approved these changes 2022-03-15 14:44:10 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Baakoma
krzysztofrewak
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#70
Delete Branch "#48-heroku-deployment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?