- actions and notifications refactor #88

2022-03-21T10:15:58+01:00

Baakoma commented

2022-03-21 10:15:58 +01:00

(Migrated from github.com)

I changed the event-based to the action-based system for vacation request acceptation flow. I also merged some notifications into more general ones

👀 1

kamilpiech97 (Migrated from github.com) reviewed 2022-03-21 11:51:05 +01:00

app/Domain/Actions/VacationRequest/CancelAction.php

						
				@@ -0,0 +38,4 @@

				        }

				        $vacationRequest->user->notify(new VacationRequestStatusChangedNotification($vacationRequest, $vacationRequest->user));

				    }

kamilpiech97 (Migrated from github.com) commented

2022-03-21 11:48:44 +01:00

Some actions have similar notify method, maybe we can move that into service or notify action.

Baakoma (Migrated from github.com) reviewed 2022-03-21 11:55:06 +01:00

app/Domain/Actions/VacationRequest/CancelAction.php

						
				@@ -0,0 +38,4 @@

				        }

				        $vacationRequest->user->notify(new VacationRequestStatusChangedNotification($vacationRequest, $vacationRequest->user));

				    }

Baakoma (Migrated from github.com) commented

2022-03-21 11:55:06 +01:00

I'm not sure if it's a good idea for now. There are only 3 places like this and they may change in different ways in the future.

kamilpiech97 (Migrated from github.com) approved these changes 2022-03-21 12:08:47 +01:00

jsawo (Migrated from github.com) approved these changes 2022-03-21 14:47:58 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#88