kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#93 - custom error pages #94

Merged
EwelinaLasowy merged 11 commits from #93-custom-error-pages into main 2022-03-30 09:06:25 +02:00
Conversation 3 Commits 11 Files Changed 3 +105 -3
EwelinaLasowy commented 2022-03-28 10:58:20 +02:00 (Migrated from github.com)
Copy Link

This should close #93.

image

This should close #93. ![image](https://user-images.githubusercontent.com/56546832/160363590-3f056ee2-19df-4f85-9fff-392445864614.png)
krzysztofrewak (Migrated from github.com) requested changes 2022-03-28 11:26:56 +02:00
krzysztofrewak (Migrated from github.com) left a comment
Copy Link

I would prefer to have the application sidebar when I'd be signed in.

I would prefer to have the application sidebar when I'd be signed in.
app/Architecture/ExceptionHandler.php
krzysztofrewak (Migrated from github.com) commented 2022-03-28 11:25:57 +02:00
Copy Link

Why only these statuses? Plus it would be nice to move this array to some const maybe?

Why only these statuses? Plus it would be nice to move this array to some const maybe?
krzysztofrewak (Migrated from github.com) commented 2022-03-28 11:26:27 +02:00
Copy Link

And why not testing? It would be nice to have a way to test failed operations.

And why not testing? It would be nice to have a way to test failed operations.
EwelinaLasowy (Migrated from github.com) reviewed 2022-03-29 10:52:46 +02:00
app/Architecture/ExceptionHandler.php
EwelinaLasowy (Migrated from github.com) commented 2022-03-29 10:52:46 +02:00
Copy Link

These statuses are rendered by default by Laravel. The solution itself is proposed by the creator of Inertia link, so I think that will be waste of time to make something more complicated. I've changed environment to production only. Maybe we can think about the application sidebar when the user is signed in, but it will be here some technical complications and it could be confusing to users.

These statuses are rendered by default by Laravel. The solution itself is proposed by the creator of Inertia [link](https://inertiajs.com/error-handling), so I think that will be waste of time to make something more complicated. I've changed `environment` to production only. Maybe we can think about the application sidebar when the user is signed in, but it will be here some technical complications and it could be confusing to users.
krzysztofrewak (Migrated from github.com) approved these changes 2022-03-30 09:05:23 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
EwelinaLasowy
krzysztofrewak
Labels
Clear labels
backend
backend feature
 bug
obviously bugged thing - to immediately fix
 content
static content update
 dependencies
Pull requests that update a dependency file
 discussion
ideas to discuss
 documentation
improvements or additions to documentation
 environment
deployment, testing and other devops stuff
 feature
new feature to implement
 frontend
frontend feature
 investigation
things to research
 javascript
Pull requests that update Javascript code
 ongoing
ongoing tasks that should never end
 php
Pull requests that update Php code
 testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#94
Delete Branch "#93-custom-error-pages"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?