- duplication of code removed

2022-07-11 13:11:15 +02:00 · 2022-07-11 13:11:15 +02:00 · 3bea1f41b2
commit 3bea1f41b2
parent d2d753640c
1 changed files with 3 additions and 4 deletions
--- a/app/Domain/UserVacationStatsRetriever.php
+++ b/app/Domain/UserVacationStatsRetriever.php
@ -105,11 +105,10 @@ class UserVacationStatsRetriever

    public function hasVacationDaysLimit(User $user, YearPeriod $yearPeriod): bool
    {
-        $limit = $user->vacationLimits()
+        return $user->vacationLimits()
            ->whereBelongsTo($yearPeriod)
-            ->first()?->days;
-
-        return $limit !== null;
+            ->first()
+            ?->hasVacation() ?? false;
    }

    protected function getLimitableVacationTypes(): Collection