kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#153 - button behaviour in form editing #164

Merged
kamilniemczycki merged 6 commits from #153-behaviour-of-buttons into main 2022-06-10 12:44:24 +02:00
Conversation 6 Commits 6 Files Changed 9 +28 -15
kamilniemczycki commented 2022-06-07 13:39:38 +02:00 (Migrated from github.com)
Copy Link

This should close #153

Changed for:

  • Edit users
  • Edit CV
  • Edit vacation limits
  • Edit holidays

Presentation:

https://user-images.githubusercontent.com/1353655/172369461-f1bdd0db-21e7-4c09-8c0c-739e8cf637f0.mp4

This should close #153 **Changed for:** - Edit users - Edit CV - Edit vacation limits - Edit holidays **Presentation:** https://user-images.githubusercontent.com/1353655/172369461-f1bdd0db-21e7-4c09-8c0c-739e8cf637f0.mp4
EwelinaLasowy (Migrated from github.com) requested changes 2022-06-08 08:47:21 +02:00
resources/js/Pages/Holidays/Edit.vue
EwelinaLasowy (Migrated from github.com) commented 2022-06-08 08:46:17 +02:00
Copy Link

disabled:opacity-60 will be better than this gray color, because it suggest to user that the button is clickable but it doesn't. It applies to all submit buttons in editing forms.

`disabled:opacity-60` will be better than this gray color, because it suggest to user that the button is clickable but it doesn't. It applies to all submit buttons in editing forms.
EwelinaLasowy (Migrated from github.com) reviewed 2022-06-08 09:07:58 +02:00
EwelinaLasowy (Migrated from github.com) left a comment
Copy Link

Maybe we can add this button behaviour on other forms - I mean form for creating resources.

Maybe we can add this button behaviour on other forms - I mean form for creating resources.
EwelinaLasowy (Migrated from github.com) requested changes 2022-06-08 13:47:16 +02:00
EwelinaLasowy (Migrated from github.com) left a comment
Copy Link

I'm not sure, if hover is okay, when a button is disabled.

I'm not sure, if hover is okay, when a button is disabled.
resources/js/Pages/VacationRequest/Create.vue
@@ -301,2 +300,4 @@
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
EwelinaLasowy (Migrated from github.com) commented 2022-06-08 13:47:09 +02:00
Copy Link

Only on this page the button is not disabled, because of default state. For a while we have null in vacation type, and after that we set first vacation type (depends on user) and in this moment fronted thinks that something change, but it isn't. So, in the line (I mean after vacationTypes.value = res.data) 459 write form.defaults('vacationType',vacationTypes.value[0]).

Only on this page the button is not disabled, because of default state. For a while we have null in vacation type, and after that we set first vacation type (depends on user) and in this moment fronted thinks that something change, but it isn't. So, in the line (I mean after `vacationTypes.value = res.data`) [459](https://github.com/blumilksoftware/toby/pull/164/commits/d36ef71dd923bd088e6d5a3c86575f6130e6cba4#diff-e2fa9345d2a5f1749faabb2fc0bd4981c2efc3c46a6684c25cc16547a406198fR459) write `form.defaults('vacationType',vacationTypes.value[0])`.
kamilniemczycki (Migrated from github.com) reviewed 2022-06-08 14:21:44 +02:00
resources/js/Pages/VacationRequest/Create.vue
@@ -301,2 +300,4 @@
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
kamilniemczycki (Migrated from github.com) commented 2022-06-08 14:21:44 +02:00
Copy Link

Now it should work properly.

Now it should work properly.
EwelinaLasowy (Migrated from github.com) approved these changes 2022-06-08 15:17:16 +02:00
Baakoma (Migrated from github.com) approved these changes 2022-06-10 12:43:56 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
EwelinaLasowy
Baakoma
Labels
Clear labels
backend
backend feature
bug
obviously bugged thing - to immediately fix
content
static content update
dependencies
Pull requests that update a dependency file
discussion
ideas to discuss
documentation
improvements or additions to documentation
environment
deployment, testing and other devops stuff
feature
new feature to implement
frontend
frontend feature
investigation
things to research
javascript
Pull requests that update Javascript code
ongoing
ongoing tasks that should never end
php
Pull requests that update Php code
testing
testing stuff
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kamilniemczycki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kamilniemczycki/toby#164
No description provided.
Delete Branch "#153-behaviour-of-buttons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?