kamilniemczycki/toby
1
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Activity

#153 - button behaviour in form editing #164

Merged
kamilniemczycki merged 6 commits from #153-behaviour-of-buttons into main 2022-06-10 12:44:24 +02:00
Conversation 6 Commits 6 Files Changed 9 +28 -15
9 changed files with 28 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
resources/js/Pages/Holidays/Create.vue
View File

@@ -67,8 +67,9 @@
</InertiaLink>
<button
type="submit"
:disabled="form.processing"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
</button>

5
resources/js/Pages/Holidays/Edit.vue
View File

@@ -66,8 +66,9 @@
</InertiaLink>
<button
type="submit"
:disabled="form.processing"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
</button>

4
resources/js/Pages/Resumes/Create.vue
View File

@@ -531,7 +531,9 @@
</InertiaLink>
<button
type="submit"
class="inline-flex justify-center py-2 px-4 ml-3 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 ml-3 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
</button>

4
resources/js/Pages/Resumes/Edit.vue
View File

@@ -531,7 +531,9 @@
</InertiaLink>
<button
type="submit"
class="inline-flex justify-center py-2 px-4 ml-3 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 ml-3 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
</button>

5
resources/js/Pages/Technologies.vue
View File

@@ -187,8 +187,9 @@
</button>
<button
type="submit"
:disabled="form.processing"
class="inline-flex justify-center py-2 px-4 text-base font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm sm:text-sm"
class="inline-flex justify-center py-2 px-4 text-base font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm sm:text-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Dodaj
</button>

5
resources/js/Pages/Users/Create.vue
View File

@@ -290,8 +290,9 @@
</InertiaLink>
<button
type="submit"
:disabled="form.processing"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
</button>

5
resources/js/Pages/Users/Edit.vue
View File

@@ -297,8 +297,9 @@
</InertiaLink>
<button
type="submit"
:disabled="form.processing"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
</button>

4
resources/js/Pages/VacationLimits.vue
View File

@@ -121,7 +121,9 @@
<div class="flex justify-end py-3 px-4">
<button
type="submit"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
</button>

6
resources/js/Pages/VacationRequest/Create.vue
View File

@@ -296,8 +296,9 @@
</InertiaLink>
<button
type="submit"
:disabled="form.processing"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 hover:bg-blumilk-700 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
class="inline-flex justify-center py-2 px-4 text-sm font-medium text-white bg-blumilk-600 rounded-md border border-transparent focus:outline-none focus:ring-2 focus:ring-blumilk-500 focus:ring-offset-2 shadow-sm"
:class="[form.processing || !form.isDirty ? 'disabled:opacity-60' : 'hover:bg-blumilk-700']"
:disabled="form.processing || !form.isDirty"
>
Zapisz
EwelinaLasowy commented 2022-06-08 13:47:09 +02:00 (Migrated from github.com)
Review
Copy Link

Only on this page the button is not disabled, because of default state. For a while we have null in vacation type, and after that we set first vacation type (depends on user) and in this moment fronted thinks that something change, but it isn't. So, in the line (I mean after vacationTypes.value = res.data) 459 write form.defaults('vacationType',vacationTypes.value[0]).

Only on this page the button is not disabled, because of default state. For a while we have null in vacation type, and after that we set first vacation type (depends on user) and in this moment fronted thinks that something change, but it isn't. So, in the line (I mean after `vacationTypes.value = res.data`) [459](https://github.com/blumilksoftware/toby/pull/164/commits/d36ef71dd923bd088e6d5a3c86575f6130e6cba4#diff-e2fa9345d2a5f1749faabb2fc0bd4981c2efc3c46a6684c25cc16547a406198fR459) write `form.defaults('vacationType',vacationTypes.value[0])`.
kamilniemczycki commented 2022-06-08 14:21:44 +02:00 (Migrated from github.com)
Review
Copy Link

Now it should work properly.

Now it should work properly.
</button>
@@ -465,6 +466,7 @@ async function refreshAvailableTypes(user) {
vacationTypes.value = res.data
form.vacationType = vacationTypes.value[0]
form.defaults('vacationType', vacationTypes.value[0])
}
</script>